From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v5 15/15] floppy: make isa_fdc_get_drive_max_chs static
Date: Wed, 13 May 2020 16:41:37 -0400 [thread overview]
Message-ID: <6e8e7d83-47f9-5b13-c275-4dcbbe007cab@redhat.com> (raw)
In-Reply-To: <62b2b0dc-9aa1-48f3-04e9-6957fbbdd087@redhat.com>
On 5/7/20 10:06 AM, Philippe Mathieu-Daudé wrote:
> On 5/7/20 3:16 PM, Gerd Hoffmann wrote:
>> acpi aml generator needs this, but it is in floppy code now
>> so we can make the function static.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: John Snow <jsnow@redhat.com>
I trust Philippe :)
prev parent reply other threads:[~2020-05-13 20:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 13:16 [PATCH v5 00/15] acpi: i386 tweaks Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 01/15] qtest: allow DSDT acpi table changes Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 02/15] acpi: move aml builder code for rtc device Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 03/15] acpi: rtc: use a single crs range Gerd Hoffmann
2020-05-11 19:26 ` Igor Mammedov
2020-06-03 23:44 ` Cameron Esfahani
2020-05-07 13:16 ` [PATCH v5 04/15] acpi: serial: don't use _STA method Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 05/15] acpi: move aml builder code for serial device Gerd Hoffmann
2020-05-07 13:53 ` Philippe Mathieu-Daudé
2020-05-07 13:16 ` [PATCH v5 06/15] acpi: parallel: don't use _STA method Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 07/15] acpi: move aml builder code for parallel device Gerd Hoffmann
2020-05-07 13:54 ` Philippe Mathieu-Daudé
2020-05-07 13:16 ` [PATCH v5 08/15] acpi: move aml builder code for floppy device Gerd Hoffmann
2020-05-07 14:05 ` Philippe Mathieu-Daudé
2020-05-13 20:43 ` John Snow
2020-05-14 5:51 ` Thomas Huth
2020-05-15 14:47 ` Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 09/15] acpi: move aml builder code for i8042 (kbd+mouse) device Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 10/15] acpi: factor out fw_cfg_add_acpi_dsdt() Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 11/15] acpi: simplify build_isa_devices_aml() Gerd Hoffmann
2020-05-07 13:16 ` [PATCH v5 12/15] acpi: drop serial/parallel enable bits from dsdt Gerd Hoffmann
2020-05-11 19:33 ` Igor Mammedov
2020-05-07 13:16 ` [PATCH v5 13/15] acpi: drop build_piix4_pm() Gerd Hoffmann
2020-05-11 19:37 ` Igor Mammedov
2020-05-12 11:16 ` Gerd Hoffmann
2020-05-12 15:08 ` Igor Mammedov
2020-05-07 13:16 ` [PATCH v5 14/15] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion Gerd Hoffmann
2020-05-11 19:38 ` Igor Mammedov
2020-05-07 13:16 ` [PATCH v5 15/15] floppy: make isa_fdc_get_drive_max_chs static Gerd Hoffmann
2020-05-07 14:06 ` Philippe Mathieu-Daudé
2020-05-13 20:41 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e8e7d83-47f9-5b13-c275-4dcbbe007cab@redhat.com \
--to=jsnow@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).