qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] qtest: bios-tables-test: fix a memory leak
@ 2020-07-14 15:35 Li Qiang
  2020-07-15  9:07 ` Auger Eric
  2020-07-15 13:47 ` Igor Mammedov
  0 siblings, 2 replies; 3+ messages in thread
From: Li Qiang @ 2020-07-14 15:35 UTC (permalink / raw)
  To: eric.auger, imammedo, thuth, lvivier, pbonzini
  Cc: Li Qiang, liq3ea, qemu-devel

Fixes: 5da7c35e25a("bios-tables-test: Add Q35/TPM-TIS test")
Signed-off-by: Li Qiang <liq3ea@163.com>
---
 tests/qtest/bios-tables-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index c315156858..d49b3988ec 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -924,6 +924,7 @@ static void test_acpi_tcg_tpm(const char *machine, const char *tpm_if,
     g_free(variant);
     g_free(tmp_path);
     g_free(tmp_dir_name);
+    g_free(args);
     free_test_data(&data);
 #else
     g_test_skip("TPM disabled");
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] qtest: bios-tables-test: fix a memory leak
  2020-07-14 15:35 [PATCH] qtest: bios-tables-test: fix a memory leak Li Qiang
@ 2020-07-15  9:07 ` Auger Eric
  2020-07-15 13:47 ` Igor Mammedov
  1 sibling, 0 replies; 3+ messages in thread
From: Auger Eric @ 2020-07-15  9:07 UTC (permalink / raw)
  To: Li Qiang, imammedo, thuth, lvivier, pbonzini; +Cc: liq3ea, qemu-devel

Hi Li,

On 7/14/20 5:35 PM, Li Qiang wrote:
> Fixes: 5da7c35e25a("bios-tables-test: Add Q35/TPM-TIS test")
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
>  tests/qtest/bios-tables-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index c315156858..d49b3988ec 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -924,6 +924,7 @@ static void test_acpi_tcg_tpm(const char *machine, const char *tpm_if,
>      g_free(variant);
>      g_free(tmp_path);
>      g_free(tmp_dir_name);
> +    g_free(args);
>      free_test_data(&data);
>  #else
>      g_test_skip("TPM disabled");
> 
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks!

Eric



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] qtest: bios-tables-test: fix a memory leak
  2020-07-14 15:35 [PATCH] qtest: bios-tables-test: fix a memory leak Li Qiang
  2020-07-15  9:07 ` Auger Eric
@ 2020-07-15 13:47 ` Igor Mammedov
  1 sibling, 0 replies; 3+ messages in thread
From: Igor Mammedov @ 2020-07-15 13:47 UTC (permalink / raw)
  To: Li Qiang; +Cc: lvivier, thuth, liq3ea, qemu-devel, eric.auger, pbonzini

On Tue, 14 Jul 2020 08:35:36 -0700
Li Qiang <liq3ea@163.com> wrote:

> Fixes: 5da7c35e25a("bios-tables-test: Add Q35/TPM-TIS test")
> Signed-off-by: Li Qiang <liq3ea@163.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  tests/qtest/bios-tables-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index c315156858..d49b3988ec 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -924,6 +924,7 @@ static void test_acpi_tcg_tpm(const char *machine, const char *tpm_if,
>      g_free(variant);
>      g_free(tmp_path);
>      g_free(tmp_dir_name);
> +    g_free(args);
>      free_test_data(&data);
>  #else
>      g_test_skip("TPM disabled");



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-15 13:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 15:35 [PATCH] qtest: bios-tables-test: fix a memory leak Li Qiang
2020-07-15  9:07 ` Auger Eric
2020-07-15 13:47 ` Igor Mammedov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).