qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Josh DuBois <duboisj@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	Josh DuBois <josh@joshdubois.com>
Subject: Re: [PATCH] trace/simple: Allow enabling simple traces from command line
Date: Wed, 29 Jul 2020 14:05:35 +0100	[thread overview]
Message-ID: <20200729130535.GI37763@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200723053359.256928-1-josh@joshdubois.com>

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

On Thu, Jul 23, 2020 at 12:33:59AM -0500, Josh DuBois wrote:
> The simple trace backend is enabled / disabled with a call
> to st_set_trace_file_enabled().  When initializing tracing
> from the command-line, this must be enabled on startup.
> (Prior to db25d56c014aa1a9, command-line initialization of
> simple trace worked because every call to st_set_trace_file
> enabled tracing.)
> 
> Fixes: db25d56c014aa1a96319c663e0a60346a223b31e
> Signed-off-by: Josh DuBois <josh@joshdubois.com>
> ---
>  trace/control.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-07-29 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23  5:33 [PATCH] trace/simple: Allow enabling simple traces from command line Josh DuBois
2020-07-29 13:05 ` Stefan Hajnoczi [this message]
2020-07-30 22:50   ` Josh DuBois
2020-08-03  9:08     ` Markus Armbruster
2020-08-04 17:41       ` Josh DuBois
2020-08-05  4:38         ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729130535.GI37763@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=duboisj@gmail.com \
    --cc=josh@joshdubois.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).