From: Eduardo Habkost <ehabkost@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef
Date: Fri, 31 Jul 2020 16:42:19 -0400 [thread overview]
Message-ID: <20200731204219.GK225270@habkost.net> (raw)
In-Reply-To: <303faba8-851f-a0da-4df3-0d57ffd1ff14@redhat.com>
On Wed, Jun 03, 2020 at 07:04:26AM +0200, Philippe Mathieu-Daudé wrote:
> On 5/5/20 4:28 PM, Philippe Mathieu-Daudé wrote:
> > Drop superfluous parenthesis around VMPortReadFunc typedef
> > (added in d67f679d99, missed to remove when moved in e595112985).
> >
> > Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > hw/i386/vmport.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/i386/vmport.h b/hw/i386/vmport.h
> > index 47eda7a22b..a6624e3045 100644
> > --- a/hw/i386/vmport.h
> > +++ b/hw/i386/vmport.h
> > @@ -27,7 +27,7 @@
> >
> > #define TYPE_VMPORT "vmport"
> >
> > -typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
> > +typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address);
> >
> > void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
> >
> >
>
> ping?
Queued for 5.2. Sorry for missing it.
--
Eduardo
prev parent reply other threads:[~2020-07-31 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 14:28 [PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef Philippe Mathieu-Daudé
2020-06-03 5:04 ` Philippe Mathieu-Daudé
2020-07-31 20:42 ` Eduardo Habkost [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731204219.GK225270@habkost.net \
--to=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).