Re: [PATCH v8 08/20] multi-process: Initialize message handler in remote device

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On Fri, Jul 31, 2020 at 02:20:15PM -0400, Jagannathan Raman wrote:
> +gboolean mpqemu_process_msg(QIOChannel *ioc, GIOCondition cond,
> +                            gpointer opaque)
> +{
> +    PCIDevice *pci_dev = (PCIDevice *)opaque;
> +    Error *local_err = NULL;
> +    MPQemuMsg msg = { 0 };
> +
> +    if (cond & G_IO_HUP) {
> +        qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
> +        return FALSE;
> +    }
> +
> +    if (cond & (G_IO_ERR | G_IO_NVAL)) {
> +        error_report("Error %d while processing message from proxy \
> +                   in remote process pid=%d", errno, getpid());

String literals don't wrap with backslash in C. Please use:

  "Error %d while processing message from proxy "
  "in remote process pid=%d", ...

instead.

> +        return FALSE;
> +    }
> +
> +    mpqemu_msg_recv(&msg, ioc, &local_err);
> +    if (local_err) {
> +        goto exit;
> +    }
> +
> +    if (!mpqemu_msg_valid(&msg)) {
> +        error_report("Received invalid message from proxy \
> +                     in remote process pid=%d", getpid());

Same here.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]