From: Roman Bolshakov <r.bolshakov@yadro.com>
To: <qemu-devel@nongnu.org>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Subject: [PATCH 4/4] configure: Test if $make actually exists
Date: Sun, 23 Aug 2020 00:21:29 +0300 [thread overview]
Message-ID: <20200822212129.97758-5-r.bolshakov@yadro.com> (raw)
In-Reply-To: <20200822212129.97758-1-r.bolshakov@yadro.com>
configure doesn't detect if $make is installed on the build host.
This is also helpful for hosts where an alias for make is used, i.e.
configure would fail if gmake is not present on macOS.
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
configure | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/configure b/configure
index 90b02b7271..c324252f60 100755
--- a/configure
+++ b/configure
@@ -2021,6 +2021,10 @@ if test -z "$python"
then
error_exit "Python not found. Use --python=/path/to/python"
fi
+if ! has "$make"
+then
+ error_exit "GNU make ($make) not found"
+fi
# Note that if the Python conditional here evaluates True we will exit
# with status 1 which is a shell 'false' value.
--
2.28.0
next prev parent reply other threads:[~2020-08-22 21:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 21:21 [PATCH 0/4] Compatibility make fixes for meson Roman Bolshakov
2020-08-22 21:21 ` [PATCH 1/4] configure: Use discovered make for in-source build Roman Bolshakov
2020-08-24 14:31 ` Daniel P. Berrangé
2020-08-24 14:37 ` Eric Blake
2020-08-24 22:07 ` Roman Bolshakov
2020-08-25 10:16 ` Roman Bolshakov
2020-08-25 14:06 ` Eric Blake
2020-08-24 14:43 ` Eric Blake
2020-08-22 21:21 ` [PATCH 2/4] Makefile: Require GNU make 3.82+ Roman Bolshakov
2020-08-24 14:32 ` Daniel P. Berrangé
2020-08-22 21:21 ` [PATCH 3/4] configure: Prefer gmake on darwin Roman Bolshakov
2020-08-24 14:48 ` Daniel P. Berrangé
2020-08-24 14:49 ` Eric Blake
2020-08-24 14:51 ` Daniel P. Berrangé
2020-08-24 14:56 ` Eric Blake
2020-08-24 15:57 ` Peter Maydell
2020-08-25 9:25 ` Roman Bolshakov
2020-08-22 21:21 ` Roman Bolshakov [this message]
2020-08-24 14:49 ` [PATCH 4/4] configure: Test if $make actually exists Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200822212129.97758-5-r.bolshakov@yadro.com \
--to=r.bolshakov@yadro.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).