From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Roman Bolshakov <r.bolshakov@yadro.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/4] Makefile: Require GNU make 3.82+
Date: Mon, 24 Aug 2020 15:32:20 +0100 [thread overview]
Message-ID: <20200824143220.GN10011@redhat.com> (raw)
In-Reply-To: <20200822212129.97758-3-r.bolshakov@yadro.com>
On Sun, Aug 23, 2020 at 12:21:27AM +0300, Roman Bolshakov wrote:
> QEMU build fails with cryptic messages if make is too old:
>
> Makefile.ninja:2655: *** multiple target patterns. Stop.
>
> To avoid the confusion it's worth to fail the build right away and print
> a friendly error message.
>
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
> Makefile | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-08-24 14:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 21:21 [PATCH 0/4] Compatibility make fixes for meson Roman Bolshakov
2020-08-22 21:21 ` [PATCH 1/4] configure: Use discovered make for in-source build Roman Bolshakov
2020-08-24 14:31 ` Daniel P. Berrangé
2020-08-24 14:37 ` Eric Blake
2020-08-24 22:07 ` Roman Bolshakov
2020-08-25 10:16 ` Roman Bolshakov
2020-08-25 14:06 ` Eric Blake
2020-08-24 14:43 ` Eric Blake
2020-08-22 21:21 ` [PATCH 2/4] Makefile: Require GNU make 3.82+ Roman Bolshakov
2020-08-24 14:32 ` Daniel P. Berrangé [this message]
2020-08-22 21:21 ` [PATCH 3/4] configure: Prefer gmake on darwin Roman Bolshakov
2020-08-24 14:48 ` Daniel P. Berrangé
2020-08-24 14:49 ` Eric Blake
2020-08-24 14:51 ` Daniel P. Berrangé
2020-08-24 14:56 ` Eric Blake
2020-08-24 15:57 ` Peter Maydell
2020-08-25 9:25 ` Roman Bolshakov
2020-08-22 21:21 ` [PATCH 4/4] configure: Test if $make actually exists Roman Bolshakov
2020-08-24 14:49 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824143220.GN10011@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).