From: Klaus Jensen <its@irrelevant.dk>
To: Andrzej Jakowski <andrzej.jakowski@linux.intel.com>
Cc: kbusch@kernel.org, kwolf@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v6 2/2] nvme: allow cmb and pmr to be enabled on same device
Date: Tue, 22 Sep 2020 11:04:25 +0200 [thread overview]
Message-ID: <20200922090425.GA1236186@apples.localdomain> (raw)
In-Reply-To: <20200817062911.GA7412@apples.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
On Aug 17 08:29, Klaus Jensen wrote:
> On Jul 30 00:50, Klaus Jensen wrote:
> > On Jul 29 15:01, Andrzej Jakowski wrote:
> > > So far it was not possible to have CMB and PMR emulated on the same
> > > device, because BAR2 was used exclusively either of PMR or CMB. This
> > > patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors.
> > >
> > > Signed-off-by: Andrzej Jakowski <andrzej.jakowski@linux.intel.com>
> > > ---
> >
> > Well, I'm certainly happy now. LGTM!
> >
> > Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
> >
>
> Are anyone willing to chip in with another review on this?
>
I think this patch is ready (and have been for some time) for inclusion,
but would really like an additional review on this; preferably from
Keith, since he is the one that originally mentioned that we could do
something like this.
I've mentioned it before, but I would prefer that the MSI-X stuff was in
BAR0 instead of mixing it with the CMB, but that's bikeshedding and my
R-b still holds of course.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-22 9:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 22:01 [PATCH v6] nvme: allow cmb and pmr emulation on same device Andrzej Jakowski
2020-07-29 22:01 ` [PATCH v6 1/2] nvme: indicate CMB support through controller capabilities register Andrzej Jakowski
2020-07-29 22:01 ` [PATCH v6 2/2] nvme: allow cmb and pmr to be enabled on same device Andrzej Jakowski
2020-07-29 22:50 ` Klaus Jensen
2020-08-17 6:29 ` Klaus Jensen
2020-09-22 9:04 ` Klaus Jensen [this message]
2020-09-22 15:30 ` Keith Busch
2020-09-28 10:51 ` [PATCH v6] nvme: allow cmb and pmr emulation " Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922090425.GA1236186@apples.localdomain \
--to=its@irrelevant.dk \
--cc=andrzej.jakowski@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).