From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Julia Suvorova <jusual@redhat.com>
Cc: Ani Sinha <ani@anisinha.ca>, Igor Mammedov <imammedo@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [RFC PATCH v3 6/7] hw/acpi/ich9: Set ACPI PCI hot-plug as default
Date: Thu, 24 Sep 2020 11:36:31 +0100 [thread overview]
Message-ID: <20200924103631.GC2097005@redhat.com> (raw)
In-Reply-To: <20200924070013.165026-7-jusual@redhat.com>
On Thu, Sep 24, 2020 at 09:00:12AM +0200, Julia Suvorova wrote:
There needs to be a commit message to explain / justify why this change
is a benefit. You have a nice list of pros/cons in the cover letter
which could serve as a good commit message here.
The cover letter gets discarded, only the commit message is in git
history, so its beneficial to capture that info here.
> Signed-off-by: Julia Suvorova <jusual@redhat.com>
> ---
> hw/acpi/ich9.c | 2 +-
> hw/i386/pc.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
> index 987f23e388..c67c20de4e 100644
> --- a/hw/acpi/ich9.c
> +++ b/hw/acpi/ich9.c
> @@ -425,7 +425,7 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
> pm->disable_s3 = 0;
> pm->disable_s4 = 0;
> pm->s4_val = 2;
> - pm->use_acpi_hotplug_bridge = false;
> + pm->use_acpi_hotplug_bridge = true;
>
> object_property_add_uint32_ptr(obj, ACPI_PM_PROP_PM_IO_BASE,
> &pm->pm_io_base, OBJ_PROP_FLAG_READ);
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index b55369357e..5de4475570 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -101,6 +101,7 @@ GlobalProperty pc_compat_5_1[] = {};
> const size_t pc_compat_5_1_len = G_N_ELEMENTS(pc_compat_5_1);
>
> GlobalProperty pc_compat_5_0[] = {
> + { "ICH9-LPC", "acpi-pci-hotplug-with-bridge-support", "off" },
> };
> const size_t pc_compat_5_0_len = G_N_ELEMENTS(pc_compat_5_0);
>
> --
> 2.25.4
>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-09-24 10:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 7:00 [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35 Julia Suvorova
2020-09-24 7:00 ` [RFC PATCH v3 1/7] hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35 Julia Suvorova
2020-09-24 10:53 ` Igor Mammedov
2020-09-24 10:54 ` Ani Sinha
2020-09-24 7:00 ` [RFC PATCH v3 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35 Julia Suvorova
2020-09-24 11:04 ` Igor Mammedov
2020-09-25 8:20 ` Gerd Hoffmann
2020-09-24 13:15 ` Ani Sinha
2020-09-24 13:58 ` Julia Suvorova
2020-09-24 7:00 ` [RFC PATCH v3 3/7] hw/pci/pcie: Do not initialize slot capability if acpihp is used Julia Suvorova
2020-09-24 7:36 ` Michael S. Tsirkin
2020-09-24 8:23 ` Julia Suvorova
2020-09-24 9:02 ` Michael S. Tsirkin
2020-09-24 11:54 ` Ani Sinha
2020-09-24 11:14 ` Igor Mammedov
2020-09-24 11:37 ` Ani Sinha
2020-09-24 7:00 ` [RFC PATCH v3 4/7] hw/acpi/ich9: Enable ACPI PCI hot-plug Julia Suvorova
2020-09-24 7:37 ` Michael S. Tsirkin
2020-09-24 11:28 ` Ani Sinha
2020-09-24 14:27 ` Julia Suvorova
2020-09-24 7:00 ` [RFC PATCH v3 5/7] bios-tables-test: Allow changes in DSDT ACPI tables Julia Suvorova
2020-09-24 10:57 ` Ani Sinha
2020-09-24 7:00 ` [RFC PATCH v3 6/7] hw/acpi/ich9: Set ACPI PCI hot-plug as default Julia Suvorova
2020-09-24 9:33 ` Igor Mammedov
2020-09-24 9:41 ` Michael S. Tsirkin
2020-09-24 10:36 ` Daniel P. Berrangé [this message]
2020-09-24 14:24 ` Julia Suvorova
2020-09-24 7:00 ` [RFC PATCH v3 7/7] bios-tables-test: Update golden binaries Julia Suvorova
2020-09-24 8:57 ` [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35 no-reply
2020-09-24 9:03 ` no-reply
2020-09-24 9:20 ` Michael S. Tsirkin
2020-10-01 8:55 ` Julia Suvorova
2020-10-01 11:40 ` Michael S. Tsirkin
2020-10-01 13:01 ` Ani Sinha
2020-10-01 15:25 ` Julia Suvorova
2020-10-01 15:54 ` Julia Suvorova
2020-10-01 16:11 ` Ani Sinha
2020-10-06 6:44 ` Michael S. Tsirkin
2020-09-24 9:30 ` Igor Mammedov
2020-09-24 9:39 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924103631.GC2097005@redhat.com \
--to=berrange@redhat.com \
--cc=ani@anisinha.ca \
--cc=imammedo@redhat.com \
--cc=jusual@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).