From: "Michael S. Tsirkin" <mst@redhat.com>
To: Julia Suvorova <jusual@redhat.com>
Cc: Ani Sinha <ani@anisinha.ca>, Igor Mammedov <imammedo@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35
Date: Tue, 6 Oct 2020 02:44:50 -0400 [thread overview]
Message-ID: <20201006023922-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAMDeoFXCApc0zqeXc9AO8smJgLk4EvZA7XdL-dsN9HZTJa4MDA@mail.gmail.com>
On Thu, Oct 01, 2020 at 05:54:39PM +0200, Julia Suvorova wrote:
> > > Right now I disable native if there is acpihp anywhere, but even if
> > > you enable it for hotplugged devices, native hot-plug will not work.
> >
> > So that's a minor regression in functionality, right?
> > Why is that the case? Because you disable it in ACPI?
> > What if we don't?
>
> I meant that I disable slot hotplug capabilities, nothing in ACPI
> prevents native from working. Actually, I don't see if there's any
> regression at all. Configurations like hot-plugging downstream port or
> switch to another downstream port haven't worked before, and they
> don't work now. I can enable native for hotplugged bridges, but that
> doesn't make sense, because you won't be able to hot-plug anything to
> it.
You can do the following hack right now:
1- add an upstream port as function 1
2- add a downstream port behind it
3- add some other device (e.g. another upstream port?) as function 0
As this point both ports should be detected.
Going forward we can consider support for adding ports in a hidden state
(not visible to guest) so one won't need an extra function.
> It's not an issue of ACPI, it's PCIe behaviour. Also, native-acpi
> combination may seem bizarre to os
Maybe, maybe not ...
Worth testing whether this works with existing guests.
> (slot enumeration is independent,
> that's why I suggested disabling pcie slot flags).
Yes that part makes sense imho.
--
MST
next prev parent reply other threads:[~2020-10-06 6:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 7:00 [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35 Julia Suvorova
2020-09-24 7:00 ` [RFC PATCH v3 1/7] hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35 Julia Suvorova
2020-09-24 10:53 ` Igor Mammedov
2020-09-24 10:54 ` Ani Sinha
2020-09-24 7:00 ` [RFC PATCH v3 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35 Julia Suvorova
2020-09-24 11:04 ` Igor Mammedov
2020-09-25 8:20 ` Gerd Hoffmann
2020-09-24 13:15 ` Ani Sinha
2020-09-24 13:58 ` Julia Suvorova
2020-09-24 7:00 ` [RFC PATCH v3 3/7] hw/pci/pcie: Do not initialize slot capability if acpihp is used Julia Suvorova
2020-09-24 7:36 ` Michael S. Tsirkin
2020-09-24 8:23 ` Julia Suvorova
2020-09-24 9:02 ` Michael S. Tsirkin
2020-09-24 11:54 ` Ani Sinha
2020-09-24 11:14 ` Igor Mammedov
2020-09-24 11:37 ` Ani Sinha
2020-09-24 7:00 ` [RFC PATCH v3 4/7] hw/acpi/ich9: Enable ACPI PCI hot-plug Julia Suvorova
2020-09-24 7:37 ` Michael S. Tsirkin
2020-09-24 11:28 ` Ani Sinha
2020-09-24 14:27 ` Julia Suvorova
2020-09-24 7:00 ` [RFC PATCH v3 5/7] bios-tables-test: Allow changes in DSDT ACPI tables Julia Suvorova
2020-09-24 10:57 ` Ani Sinha
2020-09-24 7:00 ` [RFC PATCH v3 6/7] hw/acpi/ich9: Set ACPI PCI hot-plug as default Julia Suvorova
2020-09-24 9:33 ` Igor Mammedov
2020-09-24 9:41 ` Michael S. Tsirkin
2020-09-24 10:36 ` Daniel P. Berrangé
2020-09-24 14:24 ` Julia Suvorova
2020-09-24 7:00 ` [RFC PATCH v3 7/7] bios-tables-test: Update golden binaries Julia Suvorova
2020-09-24 8:57 ` [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35 no-reply
2020-09-24 9:03 ` no-reply
2020-09-24 9:20 ` Michael S. Tsirkin
2020-10-01 8:55 ` Julia Suvorova
2020-10-01 11:40 ` Michael S. Tsirkin
2020-10-01 13:01 ` Ani Sinha
2020-10-01 15:25 ` Julia Suvorova
2020-10-01 15:54 ` Julia Suvorova
2020-10-01 16:11 ` Ani Sinha
2020-10-06 6:44 ` Michael S. Tsirkin [this message]
2020-09-24 9:30 ` Igor Mammedov
2020-09-24 9:39 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006023922-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ani@anisinha.ca \
--cc=imammedo@redhat.com \
--cc=jusual@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).