* [PATCH] vnc-stubs: Allow -vnc none
@ 2020-10-09 1:40 Jason Andryuk
2020-10-13 10:52 ` Gerd Hoffmann
0 siblings, 1 reply; 2+ messages in thread
From: Jason Andryuk @ 2020-10-09 1:40 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: Jason Andryuk
Currently `-vnc none` is fatal when built with `--disable-vnc`. Make
vnc_parse accept "none", so QEMU still run without using vnc.
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
ui/vnc-stubs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/vnc-stubs.c b/ui/vnc-stubs.c
index 06c4ac6296..c6b737dcec 100644
--- a/ui/vnc-stubs.c
+++ b/ui/vnc-stubs.c
@@ -12,6 +12,9 @@ int vnc_display_pw_expire(const char *id, time_t expires)
};
QemuOpts *vnc_parse(const char *str, Error **errp)
{
+ if (strcmp(str, "none") == 0) {
+ return NULL;
+ }
error_setg(errp, "VNC support is disabled");
return NULL;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vnc-stubs: Allow -vnc none
2020-10-09 1:40 [PATCH] vnc-stubs: Allow -vnc none Jason Andryuk
@ 2020-10-13 10:52 ` Gerd Hoffmann
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Hoffmann @ 2020-10-13 10:52 UTC (permalink / raw)
To: Jason Andryuk; +Cc: qemu-devel
On Thu, Oct 08, 2020 at 09:40:32PM -0400, Jason Andryuk wrote:
> Currently `-vnc none` is fatal when built with `--disable-vnc`. Make
> vnc_parse accept "none", so QEMU still run without using vnc.
>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Makes sense. Added to UI queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-13 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-09 1:40 [PATCH] vnc-stubs: Allow -vnc none Jason Andryuk
2020-10-13 10:52 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).