From: Gerd Hoffmann <kraxel@redhat.com>
To: Havard Skinnemoen <hskinnemoen@google.com>
Cc: peter.maydell@linaro.org, f4bug@amsat.org, qemu-devel@nongnu.org,
kfting@nuvoton.com, qemu-arm@nongnu.org, Avi.Fishman@nuvoton.com,
clg@kaod.org
Subject: Re: [PATCH 5/6] hw/arm/npcm7xx: Add EHCI and OHCI controllers
Date: Tue, 13 Oct 2020 09:05:30 +0200 [thread overview]
Message-ID: <20201013070530.nq5zhuotqaucj3ja@sirius.home.kraxel.org> (raw)
In-Reply-To: <20201008232154.94221-6-hskinnemoen@google.com>
On Thu, Oct 08, 2020 at 04:21:53PM -0700, Havard Skinnemoen wrote:
> The NPCM730 and NPCM750 chips have a single USB host port shared between
> a USB 2.0 EHCI host controller and a USB 1.1 OHCI host controller. This
> adds support for both of them.
>
> Testing notes:
> * With -device usb-kbd, qemu will automatically insert a full-speed
> hub, and the keyboard becomes controlled by the OHCI controller.
> * With -device usb-kbd,bus=usb-bus.0,port=1, the keyboard is directly
> attached to the port without any hubs, and the device becomes
> controlled by the EHCI controller since it's high speed capable.
> * With -device usb-kbd,bus=usb-bus.0,port=1,usb_version=1, the
> keyboard is directly attached to the port, but it only advertises
> itself as full-speed capable, so it becomes controlled by the OHCI
> controller.
>
> In all cases, the keyboard device enumerates correctly.
Looks good. Goes through the arm queue I guess?
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
next prev parent reply other threads:[~2020-10-13 7:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 23:21 [PATCH 0/6] Additional NPCM7xx features, devices and tests Havard Skinnemoen via
2020-10-08 23:21 ` [PATCH 1/6] tests/qtest: Add npcm7xx timer test Havard Skinnemoen via
2020-10-08 23:21 ` [PATCH 2/6] Move npcm7xx_timer_reached_zero call out of npcm7xx_timer_pause Havard Skinnemoen via
2020-10-19 16:00 ` Philippe Mathieu-Daudé
2020-10-08 23:21 ` [PATCH 3/6] hw/timer: Adding watchdog for NPCM7XX Timer Havard Skinnemoen via
2020-10-20 12:55 ` Peter Maydell
2020-10-08 23:21 ` [PATCH 4/6] hw/misc: Add npcm7xx random number generator Havard Skinnemoen via
2020-10-20 13:02 ` Peter Maydell
2020-10-20 23:40 ` Havard Skinnemoen
2020-10-08 23:21 ` [PATCH 5/6] hw/arm/npcm7xx: Add EHCI and OHCI controllers Havard Skinnemoen via
2020-10-13 7:05 ` Gerd Hoffmann [this message]
2020-10-08 23:21 ` [PATCH 6/6] hw/gpio: Add GPIO model for Nuvoton NPCM7xx Havard Skinnemoen via
2020-10-20 13:07 ` Peter Maydell
2020-10-20 13:12 ` [PATCH 0/6] Additional NPCM7xx features, devices and tests Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013070530.nq5zhuotqaucj3ja@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=Avi.Fishman@nuvoton.com \
--cc=clg@kaod.org \
--cc=f4bug@amsat.org \
--cc=hskinnemoen@google.com \
--cc=kfting@nuvoton.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).