* [PATCH] hw/arm/trace-events: Fix misuse of '0x' prefix with '%d' format
@ 2020-10-19 19:07 Peter Maydell
2020-10-19 19:49 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2020-10-19 19:07 UTC (permalink / raw)
To: qemu-arm, qemu-devel; +Cc: Eric Auger
The smmuv3_cmdq_cfgi_ste_range trace event prints decimal values with
an 0x prefix, which is confusing. We're printing a range of stream IDs
here, which elsewhere we do in decimal, so use decimal here too and
just drop the '0x' prefix.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/arm/trace-events | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/trace-events b/hw/arm/trace-events
index c8a4d80f6bd..806e1d89d2b 100644
--- a/hw/arm/trace-events
+++ b/hw/arm/trace-events
@@ -41,7 +41,7 @@ smmuv3_get_cd(uint64_t addr) "CD addr: 0x%"PRIx64
smmuv3_decode_cd(uint32_t oas) "oas=%d"
smmuv3_decode_cd_tt(int i, uint32_t tsz, uint64_t ttb, uint32_t granule_sz, bool had) "TT[%d]:tsz:%d ttb:0x%"PRIx64" granule_sz:%d had:%d"
smmuv3_cmdq_cfgi_ste(int streamid) "streamid =%d"
-smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%d - end=0x%d"
+smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=%d - end=%d"
smmuv3_cmdq_cfgi_cd(uint32_t sid) "streamid = %d"
smmuv3_config_cache_hit(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) "Config cache HIT for sid %d (hits=%d, misses=%d, hit rate=%d)"
smmuv3_config_cache_miss(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) "Config cache MISS for sid %d (hits=%d, misses=%d, hit rate=%d)"
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/arm/trace-events: Fix misuse of '0x' prefix with '%d' format
2020-10-19 19:07 [PATCH] hw/arm/trace-events: Fix misuse of '0x' prefix with '%d' format Peter Maydell
@ 2020-10-19 19:49 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-19 19:49 UTC (permalink / raw)
To: Peter Maydell, qemu-arm, qemu-devel; +Cc: Eric Auger
On 10/19/20 9:07 PM, Peter Maydell wrote:
> The smmuv3_cmdq_cfgi_ste_range trace event prints decimal values with
> an 0x prefix, which is confusing. We're printing a range of stream IDs
> here, which elsewhere we do in decimal, so use decimal here too and
> just drop the '0x' prefix.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/arm/trace-events | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-19 19:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 19:07 [PATCH] hw/arm/trace-events: Fix misuse of '0x' prefix with '%d' format Peter Maydell
2020-10-19 19:49 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).