* [PATCH] fuzz: avoid double-fetches by default
@ 2020-12-02 16:42 Alexander Bulekov
2020-12-03 14:27 ` Darren Kenny
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Bulekov @ 2020-12-02 16:42 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Thomas Huth, Alexander Bulekov, Bandan Das,
Stefan Hajnoczi, Paolo Bonzini, Philippe Mathieu-Daudé
The generic fuzzer can find double-fetch bugs. However:
* We currently have no good way of producing qemu-system reproducers for
double-fetch bugs. Even if we can get developers to run the binary-blob
reproducers with the qemu-fuzz builds, we currently don't have a minimizer for
these reproducers, so they are usually not easy to follow.
* Often times the fuzzer will provide a reproducer containing a
double-fetch for a bug that can be reproduced without double-fetching.
Until we find a way to build nice double-fetch reproducers that
developers are willing to look at, lets tell OSS-Fuzz to avoid
double-fetches.
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
tests/qtest/fuzz/generic_fuzz.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c
index 262a963d2e..07ad690683 100644
--- a/tests/qtest/fuzz/generic_fuzz.c
+++ b/tests/qtest/fuzz/generic_fuzz.c
@@ -916,6 +916,7 @@ static GString *generic_fuzz_predefined_config_cmdline(FuzzTarget *t)
g_assert(t->opaque);
config = t->opaque;
+ setenv("QEMU_AVOID_DOUBLE_FETCH", "1", 1);
setenv("QEMU_FUZZ_ARGS", config->args, 1);
setenv("QEMU_FUZZ_OBJECTS", config->objects, 1);
return generic_fuzz_cmdline(t);
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fuzz: avoid double-fetches by default
2020-12-02 16:42 [PATCH] fuzz: avoid double-fetches by default Alexander Bulekov
@ 2020-12-03 14:27 ` Darren Kenny
0 siblings, 0 replies; 2+ messages in thread
From: Darren Kenny @ 2020-12-03 14:27 UTC (permalink / raw)
To: Alexander Bulekov, qemu-devel
Cc: Laurent Vivier, Thomas Huth, Alexander Bulekov, Bandan Das,
Stefan Hajnoczi, Paolo Bonzini, Philippe Mathieu-Daudé
On Wednesday, 2020-12-02 at 11:42:14 -05, Alexander Bulekov wrote:
> The generic fuzzer can find double-fetch bugs. However:
> * We currently have no good way of producing qemu-system reproducers for
> double-fetch bugs. Even if we can get developers to run the binary-blob
> reproducers with the qemu-fuzz builds, we currently don't have a minimizer for
> these reproducers, so they are usually not easy to follow.
> * Often times the fuzzer will provide a reproducer containing a
> double-fetch for a bug that can be reproduced without double-fetching.
>
> Until we find a way to build nice double-fetch reproducers that
> developers are willing to look at, lets tell OSS-Fuzz to avoid
> double-fetches.
>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
> ---
> tests/qtest/fuzz/generic_fuzz.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuzz.c
> index 262a963d2e..07ad690683 100644
> --- a/tests/qtest/fuzz/generic_fuzz.c
> +++ b/tests/qtest/fuzz/generic_fuzz.c
> @@ -916,6 +916,7 @@ static GString *generic_fuzz_predefined_config_cmdline(FuzzTarget *t)
> g_assert(t->opaque);
>
> config = t->opaque;
> + setenv("QEMU_AVOID_DOUBLE_FETCH", "1", 1);
> setenv("QEMU_FUZZ_ARGS", config->args, 1);
> setenv("QEMU_FUZZ_OBJECTS", config->objects, 1);
> return generic_fuzz_cmdline(t);
> --
> 2.28.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-03 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 16:42 [PATCH] fuzz: avoid double-fetches by default Alexander Bulekov
2020-12-03 14:27 ` Darren Kenny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).