From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [PATCH v2 0/2] Fix _send_qemu_cmd with bash 5.1
Date: Thu, 17 Dec 2020 16:38:01 +0100 [thread overview]
Message-ID: <20201217153803.101231-1-mreitz@redhat.com> (raw)
Hi,
See patch 2 for what’s changed in bash 5.1 that makes this series
necessary, and what we need to do. (tl;dr: Bash presumably fixed a bug
for array slices, and that now breaks nearly all iotests that use
_send_qemu_cmd – but we don’t even need an array slice there.)
Patch 1 fixes a bug in 102 in how it calls _send_qemu_cmd. (This
becomes really visible with the change in patch 2.)
Comparing patch 2 to v1 (“iotests: Quote $cmd in _send_qemu_cmd”), the
reference output diffs haven’t changed, only the common.qemu hunk is
different.
Max Reitz (2):
iotests/102: Pass $QEMU_HANDLE to _send_qemu_cmd
iotests: Fix _send_qemu_cmd with bash 5.1
tests/qemu-iotests/085.out | 167 ++++++++++++++++++++++++++++-----
tests/qemu-iotests/094.out | 10 +-
tests/qemu-iotests/095.out | 4 +-
tests/qemu-iotests/102 | 2 +-
tests/qemu-iotests/102.out | 2 +-
tests/qemu-iotests/109.out | 88 ++++++++++++-----
tests/qemu-iotests/117.out | 13 ++-
tests/qemu-iotests/127.out | 12 ++-
tests/qemu-iotests/140.out | 10 +-
tests/qemu-iotests/141.out | 128 +++++++++++++++++++------
tests/qemu-iotests/143.out | 4 +-
tests/qemu-iotests/144.out | 28 +++++-
tests/qemu-iotests/153.out | 18 ++--
tests/qemu-iotests/156.out | 39 ++++++--
tests/qemu-iotests/161.out | 18 +++-
tests/qemu-iotests/173.out | 25 ++++-
tests/qemu-iotests/182.out | 42 +++++++--
tests/qemu-iotests/183.out | 19 +++-
tests/qemu-iotests/185.out | 45 +++++++--
tests/qemu-iotests/191.out | 12 ++-
tests/qemu-iotests/223.out | 92 ++++++++++++------
tests/qemu-iotests/229.out | 13 ++-
tests/qemu-iotests/249.out | 16 +++-
tests/qemu-iotests/308.out | 103 +++++++++++++++++---
tests/qemu-iotests/312.out | 10 +-
tests/qemu-iotests/common.qemu | 11 +--
26 files changed, 730 insertions(+), 201 deletions(-)
--
2.29.2
next reply other threads:[~2020-12-17 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 15:38 Max Reitz [this message]
2020-12-17 15:38 ` [PATCH v2 1/2] iotests/102: Pass $QEMU_HANDLE to _send_qemu_cmd Max Reitz
2020-12-17 15:38 ` [PATCH v2 2/2] iotests: Fix _send_qemu_cmd with bash 5.1 Max Reitz
2020-12-18 10:24 ` [PATCH v2 0/2] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217153803.101231-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).