From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v2 0/2] Fix _send_qemu_cmd with bash 5.1
Date: Fri, 18 Dec 2020 11:24:29 +0100 [thread overview]
Message-ID: <20201218102429.GD9596@merkur.fritz.box> (raw)
In-Reply-To: <20201217153803.101231-1-mreitz@redhat.com>
Am 17.12.2020 um 16:38 hat Max Reitz geschrieben:
> Hi,
>
> See patch 2 for what’s changed in bash 5.1 that makes this series
> necessary, and what we need to do. (tl;dr: Bash presumably fixed a bug
> for array slices, and that now breaks nearly all iotests that use
> _send_qemu_cmd – but we don’t even need an array slice there.)
>
> Patch 1 fixes a bug in 102 in how it calls _send_qemu_cmd. (This
> becomes really visible with the change in patch 2.)
>
> Comparing patch 2 to v1 (“iotests: Quote $cmd in _send_qemu_cmd”), the
> reference output diffs haven’t changed, only the common.qemu hunk is
> different.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
prev parent reply other threads:[~2020-12-18 10:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 15:38 [PATCH v2 0/2] Fix _send_qemu_cmd with bash 5.1 Max Reitz
2020-12-17 15:38 ` [PATCH v2 1/2] iotests/102: Pass $QEMU_HANDLE to _send_qemu_cmd Max Reitz
2020-12-17 15:38 ` [PATCH v2 2/2] iotests: Fix _send_qemu_cmd with bash 5.1 Max Reitz
2020-12-18 10:24 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201218102429.GD9596@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).