From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PULL 11/23] accel/tcg: Create io_recompile_replay_branch hook
Date: Thu, 18 Feb 2021 09:46:54 +0000 [thread overview]
Message-ID: <20210218094706.23038-12-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210218094706.23038-1-alex.bennee@linaro.org>
From: Richard Henderson <richard.henderson@linaro.org>
Create a hook in which to split out the mips and
sh4 ifdefs from cpu_io_recompile.
[AJB: s/stoped/stopped/]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210208233906.479571-3-richard.henderson@linaro.org>
Message-Id: <20210213130325.14781-12-alex.bennee@linaro.org>
diff --git a/include/hw/core/tcg-cpu-ops.h b/include/hw/core/tcg-cpu-ops.h
index ac3bb051f2..72d791438c 100644
--- a/include/hw/core/tcg-cpu-ops.h
+++ b/include/hw/core/tcg-cpu-ops.h
@@ -88,6 +88,16 @@ struct TCGCPUOps {
*/
bool (*debug_check_watchpoint)(CPUState *cpu, CPUWatchpoint *wp);
+ /**
+ * @io_recompile_replay_branch: Callback for cpu_io_recompile.
+ *
+ * The cpu has been stopped, and cpu_restore_state_from_tb has been
+ * called. If the faulting instruction is in a delay slot, and the
+ * target architecture requires re-execution of the branch, then
+ * adjust the cpu state as required and return true.
+ */
+ bool (*io_recompile_replay_branch)(CPUState *cpu,
+ const TranslationBlock *tb);
#endif /* CONFIG_SOFTMMU */
#endif /* NEED_CPU_H */
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 2c34adccce..99ca6f36b9 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -60,6 +60,7 @@
#include "sysemu/cpu-timers.h"
#include "sysemu/tcg.h"
#include "qapi/error.h"
+#include "hw/core/tcg-cpu-ops.h"
#include "internal.h"
/* #define DEBUG_TB_INVALIDATE */
@@ -2421,6 +2422,7 @@ void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr)
CPUArchState *env = cpu->env_ptr;
#endif
TranslationBlock *tb;
+ CPUClass *cc;
uint32_t n;
tb = tcg_tb_lookup(retaddr);
@@ -2430,11 +2432,18 @@ void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr)
}
cpu_restore_state_from_tb(cpu, tb, retaddr, true);
- /* On MIPS and SH, delay slot instructions can only be restarted if
- they were already the first instruction in the TB. If this is not
- the first instruction in a TB then re-execute the preceding
- branch. */
+ /*
+ * Some guests must re-execute the branch when re-executing a delay
+ * slot instruction. When this is the case, adjust icount and N
+ * to account for the re-execution of the branch.
+ */
n = 1;
+ cc = CPU_GET_CLASS(cpu);
+ if (cc->tcg_ops->io_recompile_replay_branch &&
+ cc->tcg_ops->io_recompile_replay_branch(cpu, tb)) {
+ cpu_neg(cpu)->icount_decr.u16.low++;
+ n = 2;
+ }
#if defined(TARGET_MIPS)
if ((env->hflags & MIPS_HFLAG_BMASK) != 0
&& env->active_tc.PC != tb->pc) {
--
2.20.1
next prev parent reply other threads:[~2021-02-18 9:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 9:46 [PULL 00/23] plugin updates (hwprofile, CF_NOCACHE, io_recompile) Alex Bennée
2021-02-18 9:46 ` [PULL 01/23] hw/virtio/pci: include vdev name in registered PCI sections Alex Bennée
2021-02-18 9:46 ` [PULL 02/23] plugins: add API to return a name for a IO device Alex Bennée
2021-02-18 9:46 ` [PULL 03/23] plugins: new hwprofile plugin Alex Bennée
2021-02-18 9:46 ` [PULL 04/23] contrib: Don't use '#' flag of printf format Alex Bennée
2021-02-18 9:46 ` [PULL 05/23] contrib: Fix some code style problems, ERROR: "foo * bar" should be "foo *bar" Alex Bennée
2021-02-18 9:46 ` [PULL 06/23] contrib: Add spaces around operator Alex Bennée
2021-02-18 9:46 ` [PULL 07/23] contrib: space required after that ',' Alex Bennée
2021-02-18 9:46 ` [PULL 08/23] contrib: Open brace '{' following struct go on the same line Alex Bennée
2021-02-18 9:46 ` [PULL 09/23] accel/tcg/plugin-gen: fix the call signature for inline callbacks Alex Bennée
2021-02-18 9:46 ` [PULL 10/23] exec: Move TranslationBlock typedef to qemu/typedefs.h Alex Bennée
2021-02-18 9:46 ` Alex Bennée [this message]
2021-02-18 9:46 ` [PULL 12/23] target/mips: Create mips_io_recompile_replay_branch Alex Bennée
2021-02-18 9:46 ` [PULL 13/23] target/sh4: Create superh_io_recompile_replay_branch Alex Bennée
2021-02-18 9:46 ` [PULL 14/23] tests/plugin: expand insn test to detect duplicate instructions Alex Bennée
2021-02-18 9:46 ` [PULL 15/23] tests/acceptance: add a new set of tests to exercise plugins Alex Bennée
2021-02-18 9:46 ` [PULL 16/23] accel/tcg: actually cache our partial icount TB Alex Bennée
2021-02-18 9:47 ` [PULL 17/23] accel/tcg: cache single instruction TB on pending replay exception Alex Bennée
2021-02-18 9:47 ` [PULL 18/23] accel/tcg: re-factor non-RAM execution code Alex Bennée
2021-04-15 13:18 ` Peter Maydell
2021-04-15 13:37 ` Peter Maydell
2021-04-15 14:31 ` Alex Bennée
2021-04-15 14:54 ` Peter Maydell
2021-04-15 15:55 ` Philippe Mathieu-Daudé
2021-04-15 17:18 ` [EXTERNAL] " Cédric Le Goater
2021-04-15 17:34 ` Peter Maydell
2021-04-16 7:55 ` Cédric Le Goater
2021-04-16 9:14 ` Alex Bennée
2021-04-16 10:14 ` Cédric Le Goater
2021-02-18 9:47 ` [PULL 19/23] accel/tcg: remove CF_NOCACHE and special cases Alex Bennée
2021-02-18 9:47 ` [PULL 20/23] accel/tcg: allow plugin instrumentation to be disable via cflags Alex Bennée
2021-02-18 9:47 ` [PULL 21/23] tests/acceptance: add a new tests to detect counting errors Alex Bennée
2021-02-18 9:47 ` [PULL 22/23] tests/plugin: allow memory plugin to do both inline and callbacks Alex Bennée
2021-02-18 9:47 ` [PULL 23/23] tests/acceptance: add a memory callback check Alex Bennée
2021-02-18 15:13 ` [PULL 00/23] plugin updates (hwprofile, CF_NOCACHE, io_recompile) Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218094706.23038-12-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).