qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org, zhouyang <zhouyang789@huawei.com>
Subject: [PULL 07/23] contrib: space required after that ','
Date: Thu, 18 Feb 2021 09:46:50 +0000	[thread overview]
Message-ID: <20210218094706.23038-8-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210218094706.23038-1-alex.bennee@linaro.org>

From: zhouyang <zhouyang789@huawei.com>

I am reading contrib related code and found some style problems while
check the code using checkpatch.pl. This commit fixs the issue below:
ERROR: space required after that ','

Signed-off-by: zhouyang <zhouyang789@huawei.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210118031004.1662363-5-zhouyang789@huawei.com>
Message-Id: <20210213130325.14781-8-alex.bennee@linaro.org>

diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c
index 2f892da17d..9d6fa33297 100644
--- a/contrib/plugins/howvec.c
+++ b/contrib/plugins/howvec.c
@@ -68,7 +68,7 @@ static InsnClassExecCount aarch64_insn_classes[] = {
     { "Reserved",            "res",    0x1e000000, 0x00000000, COUNT_CLASS},
     /* Data Processing Immediate */
     { "  PCrel addr",        "pcrel",  0x1f000000, 0x10000000, COUNT_CLASS},
-    { "  Add/Sub (imm,tags)","asit",   0x1f800000, 0x11800000, COUNT_CLASS},
+    { "  Add/Sub (imm,tags)", "asit",   0x1f800000, 0x11800000, COUNT_CLASS},
     { "  Add/Sub (imm)",     "asi",    0x1f000000, 0x11000000, COUNT_CLASS},
     { "  Logical (imm)",     "logi",   0x1f800000, 0x12000000, COUNT_CLASS},
     { "  Move Wide (imm)",   "movwi",  0x1f800000, 0x12800000, COUNT_CLASS},
@@ -91,17 +91,17 @@ static InsnClassExecCount aarch64_insn_classes[] = {
     { "Branches",            "branch", 0x1c000000, 0x14000000, COUNT_CLASS},
     /* Loads and Stores */
     { "  AdvSimd ldstmult",  "advlsm", 0xbfbf0000, 0x0c000000, COUNT_CLASS},
-    { "  AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS},
+    { "  AdvSimd ldstmult++", "advlsmp", 0xbfb00000, 0x0c800000, COUNT_CLASS},
     { "  AdvSimd ldst",      "advlss", 0xbf9f0000, 0x0d000000, COUNT_CLASS},
-    { "  AdvSimd ldst++",    "advlssp",0xbf800000, 0x0d800000, COUNT_CLASS},
+    { "  AdvSimd ldst++",    "advlssp", 0xbf800000, 0x0d800000, COUNT_CLASS},
     { "  ldst excl",         "ldstx",  0x3f000000, 0x08000000, COUNT_CLASS},
     { "    Prefetch",        "prfm",   0xff000000, 0xd8000000, COUNT_CLASS},
     { "  Load Reg (lit)",    "ldlit",  0x1b000000, 0x18000000, COUNT_CLASS},
-    { "  ldst noalloc pair", "ldstnap",0x3b800000, 0x28000000, COUNT_CLASS},
+    { "  ldst noalloc pair", "ldstnap", 0x3b800000, 0x28000000, COUNT_CLASS},
     { "  ldst pair",         "ldstp",  0x38000000, 0x28000000, COUNT_CLASS},
     { "  ldst reg",          "ldstr",  0x3b200000, 0x38000000, COUNT_CLASS},
     { "  Atomic ldst",       "atomic", 0x3b200c00, 0x38200000, COUNT_CLASS},
-    { "  ldst reg (reg off)","ldstro", 0x3b200b00, 0x38200800, COUNT_CLASS},
+    { "  ldst reg (reg off)", "ldstro", 0x3b200b00, 0x38200800, COUNT_CLASS},
     { "  ldst reg (pac)",    "ldstpa", 0x3b200200, 0x38200800, COUNT_CLASS},
     { "  ldst reg (imm)",    "ldsti",  0x3b000000, 0x39000000, COUNT_CLASS},
     { "Loads & Stores",      "ldst",   0x0a000000, 0x08000000, COUNT_CLASS},
@@ -202,7 +202,7 @@ static void plugin_exit(qemu_plugin_id_t id, void *p)
 
     counts = g_hash_table_get_values(insns);
     if (counts && g_list_next(counts)) {
-        g_string_append_printf(report,"Individual Instructions:\n");
+        g_string_append_printf(report, "Individual Instructions:\n");
         counts = g_list_sort(counts, cmp_exec_count);
 
         for (i = 0; i < limit && g_list_next(counts);
-- 
2.20.1



  parent reply	other threads:[~2021-02-18  9:52 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18  9:46 [PULL 00/23] plugin updates (hwprofile, CF_NOCACHE, io_recompile) Alex Bennée
2021-02-18  9:46 ` [PULL 01/23] hw/virtio/pci: include vdev name in registered PCI sections Alex Bennée
2021-02-18  9:46 ` [PULL 02/23] plugins: add API to return a name for a IO device Alex Bennée
2021-02-18  9:46 ` [PULL 03/23] plugins: new hwprofile plugin Alex Bennée
2021-02-18  9:46 ` [PULL 04/23] contrib: Don't use '#' flag of printf format Alex Bennée
2021-02-18  9:46 ` [PULL 05/23] contrib: Fix some code style problems, ERROR: "foo * bar" should be "foo *bar" Alex Bennée
2021-02-18  9:46 ` [PULL 06/23] contrib: Add spaces around operator Alex Bennée
2021-02-18  9:46 ` Alex Bennée [this message]
2021-02-18  9:46 ` [PULL 08/23] contrib: Open brace '{' following struct go on the same line Alex Bennée
2021-02-18  9:46 ` [PULL 09/23] accel/tcg/plugin-gen: fix the call signature for inline callbacks Alex Bennée
2021-02-18  9:46 ` [PULL 10/23] exec: Move TranslationBlock typedef to qemu/typedefs.h Alex Bennée
2021-02-18  9:46 ` [PULL 11/23] accel/tcg: Create io_recompile_replay_branch hook Alex Bennée
2021-02-18  9:46 ` [PULL 12/23] target/mips: Create mips_io_recompile_replay_branch Alex Bennée
2021-02-18  9:46 ` [PULL 13/23] target/sh4: Create superh_io_recompile_replay_branch Alex Bennée
2021-02-18  9:46 ` [PULL 14/23] tests/plugin: expand insn test to detect duplicate instructions Alex Bennée
2021-02-18  9:46 ` [PULL 15/23] tests/acceptance: add a new set of tests to exercise plugins Alex Bennée
2021-02-18  9:46 ` [PULL 16/23] accel/tcg: actually cache our partial icount TB Alex Bennée
2021-02-18  9:47 ` [PULL 17/23] accel/tcg: cache single instruction TB on pending replay exception Alex Bennée
2021-02-18  9:47 ` [PULL 18/23] accel/tcg: re-factor non-RAM execution code Alex Bennée
2021-04-15 13:18   ` Peter Maydell
2021-04-15 13:37     ` Peter Maydell
2021-04-15 14:31       ` Alex Bennée
2021-04-15 14:54         ` Peter Maydell
2021-04-15 15:55           ` Philippe Mathieu-Daudé
2021-04-15 17:18             ` [EXTERNAL] " Cédric Le Goater
2021-04-15 17:34               ` Peter Maydell
2021-04-16  7:55                 ` Cédric Le Goater
2021-04-16  9:14                   ` Alex Bennée
2021-04-16 10:14                     ` Cédric Le Goater
2021-02-18  9:47 ` [PULL 19/23] accel/tcg: remove CF_NOCACHE and special cases Alex Bennée
2021-02-18  9:47 ` [PULL 20/23] accel/tcg: allow plugin instrumentation to be disable via cflags Alex Bennée
2021-02-18  9:47 ` [PULL 21/23] tests/acceptance: add a new tests to detect counting errors Alex Bennée
2021-02-18  9:47 ` [PULL 22/23] tests/plugin: allow memory plugin to do both inline and callbacks Alex Bennée
2021-02-18  9:47 ` [PULL 23/23] tests/acceptance: add a memory callback check Alex Bennée
2021-02-18 15:13 ` [PULL 00/23] plugin updates (hwprofile, CF_NOCACHE, io_recompile) Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210218094706.23038-8-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhouyang789@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).