From: Samuel Thibault <samuel.thibault@gnu.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Doug Evans" <dje@google.com>,
"Markus Armbruster" <armbru@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse
Date: Sun, 28 Feb 2021 23:20:37 +0100 [thread overview]
Message-ID: <20210228222037.2k2zaccdf3egbivw@begin> (raw)
In-Reply-To: <20210228213957.xkc4cceh5o6rgd5n@begin>
Samuel Thibault, le dim. 28 févr. 2021 22:39:57 +0100, a ecrit:
> It was simpler to have e.g. udp_listen and udp6_listen separate to keep
> uint32_t / in6_addr parameters, but there is no strict reason for this:
> the haddr is only passed to the bind() call, and the laddr is only
> recorded in the so. Put another way, a refactoring patch could be to
> just hand udp_listen two sockaddrs, and it will just work fine.
I have submitted that part to
https://gitlab.freedesktop.org/slirp/libslirp/-/merge_requests/74
Could you review it?
> We'd then introduce a slirp_add_xhostfwd that takes two sockaddr
> instead of host/port.
That should then be easy to introduce indeed, and immediately more
powerful than the slirp_add/remove_ipv6_hostfwd. Possibly you could just
replace in qemu the existing slirp_add/remove_hostfwd call, and thus
make the whole code simpler: ideally it's the address parsing function
that would produce a sockaddr.
Samuel
next prev parent reply other threads:[~2021-02-28 22:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 20:15 [PATCH v4 0/4] Add support for ipv6 host forwarding Doug Evans via
2021-02-18 20:15 ` [PATCH v4 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support Doug Evans via
2021-02-19 9:38 ` Daniel P. Berrangé
2021-02-19 21:43 ` Doug Evans
2021-02-18 20:15 ` [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse Doug Evans via
2021-02-19 10:00 ` Daniel P. Berrangé
2021-02-19 22:17 ` Doug Evans
2021-02-22 9:39 ` Daniel P. Berrangé
2021-02-23 18:23 ` Doug Evans
2021-02-28 21:39 ` Samuel Thibault
2021-02-28 22:20 ` Samuel Thibault [this message]
2021-03-01 8:15 ` Markus Armbruster
2021-03-01 8:31 ` Samuel Thibault
2021-03-01 16:07 ` Doug Evans
2021-03-01 16:26 ` Samuel Thibault
2021-03-01 20:39 ` Samuel Thibault
2021-03-01 16:23 ` Doug Evans
2021-03-01 16:27 ` Samuel Thibault
2021-03-01 21:05 ` Samuel Thibault
2021-03-03 18:06 ` Doug Evans
2021-03-03 18:11 ` Daniel P. Berrangé
2021-03-05 21:28 ` Samuel Thibault
2021-03-05 21:51 ` Doug Evans
2021-03-05 22:21 ` Doug Evans
2021-03-06 0:05 ` Doug Evans
2021-03-06 0:10 ` Samuel Thibault
2021-03-06 1:00 ` Doug Evans
2021-03-06 19:29 ` Samuel Thibault
2021-03-14 19:52 ` Doug Evans
2021-02-18 20:15 ` [PATCH v4 3/4] net/slirp.c: Refactor address parsing Doug Evans via
2021-02-18 20:15 ` [PATCH v4 4/4] net: Extend host forwarding to support IPv6 Doug Evans via
2021-02-18 20:34 ` [PATCH v4 0/4] Add support for ipv6 host forwarding no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210228222037.2k2zaccdf3egbivw@begin \
--to=samuel.thibault@gnu.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dje@google.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).