From: Doug Evans <dje@google.com>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Subject: Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse
Date: Mon, 1 Mar 2021 08:07:19 -0800 [thread overview]
Message-ID: <CADPb22RMRfRAe1Wto1dH8WaCFuMXwkWVEsNo-kXCY607=v4J_w@mail.gmail.com> (raw)
In-Reply-To: <20210228213957.xkc4cceh5o6rgd5n@begin>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault <samuel.thibault@gnu.org>
wrote:
> Hello,
>
> Daniel P. Berrangé, le lun. 22 févr. 2021 09:39:41 +0000, a ecrit:
>
> > The is_v6 flag is only needed
> > for the legacy compat needs in slirp, even that is only if we want to
> > have strict equivalence with historical behaviour, as opposed to changing
> > empty string to mean to listen on both IPv4+6 concurrently..
>
> I would say that empty address meaning ipv4+6 looks better to me.
>
It's not my call, but I have some questions.
Are there any users that this functional change would break?
[Previously the empty address meant qemu would only listen on ipv4
addr-any.]
What if a user wants only ipv4 addr-any (or only ipv6 addr-any) ?
What does hostfwd "::12345-6.7.8.9:10" mean?
Does the presence of the empty host address mean forward both ipv4 and ipv6
to guest ipv4 6.7.8.9?
[-- Attachment #2: Type: text/html, Size: 1936 bytes --]
next prev parent reply other threads:[~2021-03-01 16:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 20:15 [PATCH v4 0/4] Add support for ipv6 host forwarding Doug Evans via
2021-02-18 20:15 ` [PATCH v4 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support Doug Evans via
2021-02-19 9:38 ` Daniel P. Berrangé
2021-02-19 21:43 ` Doug Evans
2021-02-18 20:15 ` [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse Doug Evans via
2021-02-19 10:00 ` Daniel P. Berrangé
2021-02-19 22:17 ` Doug Evans
2021-02-22 9:39 ` Daniel P. Berrangé
2021-02-23 18:23 ` Doug Evans
2021-02-28 21:39 ` Samuel Thibault
2021-02-28 22:20 ` Samuel Thibault
2021-03-01 8:15 ` Markus Armbruster
2021-03-01 8:31 ` Samuel Thibault
2021-03-01 16:07 ` Doug Evans [this message]
2021-03-01 16:26 ` Samuel Thibault
2021-03-01 20:39 ` Samuel Thibault
2021-03-01 16:23 ` Doug Evans
2021-03-01 16:27 ` Samuel Thibault
2021-03-01 21:05 ` Samuel Thibault
2021-03-03 18:06 ` Doug Evans
2021-03-03 18:11 ` Daniel P. Berrangé
2021-03-05 21:28 ` Samuel Thibault
2021-03-05 21:51 ` Doug Evans
2021-03-05 22:21 ` Doug Evans
2021-03-06 0:05 ` Doug Evans
2021-03-06 0:10 ` Samuel Thibault
2021-03-06 1:00 ` Doug Evans
2021-03-06 19:29 ` Samuel Thibault
2021-03-14 19:52 ` Doug Evans
2021-02-18 20:15 ` [PATCH v4 3/4] net/slirp.c: Refactor address parsing Doug Evans via
2021-02-18 20:15 ` [PATCH v4 4/4] net: Extend host forwarding to support IPv6 Doug Evans via
2021-02-18 20:34 ` [PATCH v4 0/4] Add support for ipv6 host forwarding no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22RMRfRAe1Wto1dH8WaCFuMXwkWVEsNo-kXCY607=v4J_w@mail.gmail.com' \
--to=dje@google.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).