qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM
@ 2021-03-16 11:03 Philippe Mathieu-Daudé
  2021-04-08 13:16 ` [PATCH-for-6.0? " Philippe Mathieu-Daudé
  0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-03-16 11:03 UTC (permalink / raw)
  To: qemu-devel; +Cc: Thomas Huth, Philippe Mathieu-Daudé

TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
requires APM to be selected.

Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Rebased on usb-20210315-pull-request
Based-on: <20210315180240.1597240-1-kraxel@redhat.com>
---
 hw/isa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index 2691eae2f0c..55e0003ce40 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -48,6 +48,7 @@ config VT82C686
     select SERIAL_ISA
     select FDC
     select USB_UHCI
+    select APM
 
 config SMC37C669
     bool
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH-for-6.0? v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM
  2021-03-16 11:03 [PATCH v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM Philippe Mathieu-Daudé
@ 2021-04-08 13:16 ` Philippe Mathieu-Daudé
  2021-04-08 13:22   ` BALATON Zoltan
  0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-08 13:16 UTC (permalink / raw)
  To: qemu-devel, Paolo Bonzini; +Cc: Thomas Huth

This patch apparently got lost.

On 3/16/21 12:03 PM, Philippe Mathieu-Daudé wrote:
> TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
> requires APM to be selected.
> 
> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Rebased on usb-20210315-pull-request
> Based-on: <20210315180240.1597240-1-kraxel@redhat.com>
> ---
>  hw/isa/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 2691eae2f0c..55e0003ce40 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -48,6 +48,7 @@ config VT82C686
>      select SERIAL_ISA
>      select FDC
>      select USB_UHCI
> +    select APM
>  
>  config SMC37C669
>      bool
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH-for-6.0? v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM
  2021-04-08 13:16 ` [PATCH-for-6.0? " Philippe Mathieu-Daudé
@ 2021-04-08 13:22   ` BALATON Zoltan
  2021-04-08 13:32     ` Philippe Mathieu-Daudé
  0 siblings, 1 reply; 4+ messages in thread
From: BALATON Zoltan @ 2021-04-08 13:22 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé
  Cc: Paolo Bonzini, Thomas Huth, qemu-devel, David Gibson

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

On Thu, 8 Apr 2021, Philippe Mathieu-Daudé wrote:
> This patch apparently got lost.

No, it's queued for 6.1 as part of my pegasos2 series in David's tree:

https://github.com/dgibson/qemu/commits/ppc-for-6.1

Regards,
BALATON Zoltan

> On 3/16/21 12:03 PM, Philippe Mathieu-Daudé wrote:
>> TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
>> requires APM to be selected.
>>
>> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> Rebased on usb-20210315-pull-request
>> Based-on: <20210315180240.1597240-1-kraxel@redhat.com>
>> ---
>>  hw/isa/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
>> index 2691eae2f0c..55e0003ce40 100644
>> --- a/hw/isa/Kconfig
>> +++ b/hw/isa/Kconfig
>> @@ -48,6 +48,7 @@ config VT82C686
>>      select SERIAL_ISA
>>      select FDC
>>      select USB_UHCI
>> +    select APM
>>
>>  config SMC37C669
>>      bool
>>
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH-for-6.0? v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM
  2021-04-08 13:22   ` BALATON Zoltan
@ 2021-04-08 13:32     ` Philippe Mathieu-Daudé
  0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-08 13:32 UTC (permalink / raw)
  To: BALATON Zoltan; +Cc: Paolo Bonzini, Thomas Huth, qemu-devel, David Gibson

On 4/8/21 3:22 PM, BALATON Zoltan wrote:
> On Thu, 8 Apr 2021, Philippe Mathieu-Daudé wrote:
>> This patch apparently got lost.
> 
> No, it's queued for 6.1 as part of my pegasos2 series in David's tree:
> 
> https://github.com/dgibson/qemu/commits/ppc-for-6.1

Ah great, thank you both.

> 
> Regards,
> BALATON Zoltan
> 
>> On 3/16/21 12:03 PM, Philippe Mathieu-Daudé wrote:
>>> TYPE_VIA_PM calls apm_init() in via_pm_realize(), so
>>> requires APM to be selected.
>>>
>>> Reported-by: BALATON Zoltan <balaton@eik.bme.hu>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> Rebased on usb-20210315-pull-request
>>> Based-on: <20210315180240.1597240-1-kraxel@redhat.com>
>>> ---
>>>  hw/isa/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
>>> index 2691eae2f0c..55e0003ce40 100644
>>> --- a/hw/isa/Kconfig
>>> +++ b/hw/isa/Kconfig
>>> @@ -48,6 +48,7 @@ config VT82C686
>>>      select SERIAL_ISA
>>>      select FDC
>>>      select USB_UHCI
>>> +    select APM
>>>
>>>  config SMC37C669
>>>      bool
>>>
>>
>>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-04-08 13:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 11:03 [PATCH v2] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM Philippe Mathieu-Daudé
2021-04-08 13:16 ` [PATCH-for-6.0? " Philippe Mathieu-Daudé
2021-04-08 13:22   ` BALATON Zoltan
2021-04-08 13:32     ` Philippe Mathieu-Daudé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).