* [PATCH v1] scripts: fix generation update-binfmts templates
@ 2021-03-23 12:34 Silvano Cirujano Cuesta
2021-04-30 16:46 ` Laurent Vivier
2021-04-30 17:23 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Silvano Cirujano Cuesta @ 2021-03-23 12:34 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
This patch fixes the update-binfmts templates being used in the script
scripts/qemu-binfmt-conf.sh when the option --debian is used.
Fixed issues are:
- Typo in flag 'credentials' (previously 'credential').
- Missing flags 'preserve' and 'fix_binary'.
Reference: https://manpages.debian.org/buster/binfmt-support/update-binfmts.8.en.html#FORMAT_FILES
Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
---
scripts/qemu-binfmt-conf.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
index 573b5dc6ac..7de996d536 100755
--- a/scripts/qemu-binfmt-conf.sh
+++ b/scripts/qemu-binfmt-conf.sh
@@ -294,7 +294,9 @@ package qemu-$cpu
interpreter $qemu
magic $magic
mask $mask
-credential $CREDENTIAL
+credentials $CREDENTIAL
+preserve $PRESERVE_ARG0
+fix_binary $PERSISTENT
EOF
}
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] scripts: fix generation update-binfmts templates
2021-03-23 12:34 [PATCH v1] scripts: fix generation update-binfmts templates Silvano Cirujano Cuesta
@ 2021-04-30 16:46 ` Laurent Vivier
2021-04-30 17:23 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-04-30 16:46 UTC (permalink / raw)
To: Silvano Cirujano Cuesta, qemu-devel; +Cc: qemu-trivial
Le 23/03/2021 à 13:34, Silvano Cirujano Cuesta a écrit :
> This patch fixes the update-binfmts templates being used in the script
> scripts/qemu-binfmt-conf.sh when the option --debian is used.
>
> Fixed issues are:
> - Typo in flag 'credentials' (previously 'credential').
> - Missing flags 'preserve' and 'fix_binary'.
>
> Reference: https://manpages.debian.org/buster/binfmt-support/update-binfmts.8.en.html#FORMAT_FILES
>
> Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
> ---
> scripts/qemu-binfmt-conf.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
> index 573b5dc6ac..7de996d536 100755
> --- a/scripts/qemu-binfmt-conf.sh
> +++ b/scripts/qemu-binfmt-conf.sh
> @@ -294,7 +294,9 @@ package qemu-$cpu
> interpreter $qemu
> magic $magic
> mask $mask
> -credential $CREDENTIAL
> +credentials $CREDENTIAL
> +preserve $PRESERVE_ARG0
> +fix_binary $PERSISTENT
> EOF
> }
>
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] scripts: fix generation update-binfmts templates
2021-03-23 12:34 [PATCH v1] scripts: fix generation update-binfmts templates Silvano Cirujano Cuesta
2021-04-30 16:46 ` Laurent Vivier
@ 2021-04-30 17:23 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-04-30 17:23 UTC (permalink / raw)
To: Silvano Cirujano Cuesta, qemu-devel; +Cc: qemu-trivial
Le 23/03/2021 à 13:34, Silvano Cirujano Cuesta a écrit :
> This patch fixes the update-binfmts templates being used in the script
> scripts/qemu-binfmt-conf.sh when the option --debian is used.
>
> Fixed issues are:
> - Typo in flag 'credentials' (previously 'credential').
> - Missing flags 'preserve' and 'fix_binary'.
>
> Reference: https://manpages.debian.org/buster/binfmt-support/update-binfmts.8.en.html#FORMAT_FILES
>
> Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
> ---
> scripts/qemu-binfmt-conf.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
> index 573b5dc6ac..7de996d536 100755
> --- a/scripts/qemu-binfmt-conf.sh
> +++ b/scripts/qemu-binfmt-conf.sh
> @@ -294,7 +294,9 @@ package qemu-$cpu
> interpreter $qemu
> magic $magic
> mask $mask
> -credential $CREDENTIAL
> +credentials $CREDENTIAL
> +preserve $PRESERVE_ARG0
> +fix_binary $PERSISTENT
> EOF
> }
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-30 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 12:34 [PATCH v1] scripts: fix generation update-binfmts templates Silvano Cirujano Cuesta
2021-04-30 16:46 ` Laurent Vivier
2021-04-30 17:23 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).