From: Luis Pires <luis.pires@eldorado.org.br>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: richard.henderson@linaro.org, f4bug@amsat.org,
Luis Pires <luis.pires@eldorado.org.br>,
lagarcia@br.ibm.com, bruno.larsen@eldorado.org.br,
matheus.ferst@eldorado.org.br, david@gibson.dropbear.id.au
Subject: [PATCH 3/5] decodetree: Allow custom var width load functions
Date: Tue, 13 Apr 2021 18:11:27 -0300 [thread overview]
Message-ID: <20210413211129.457272-4-luis.pires@eldorado.org.br> (raw)
In-Reply-To: <20210413211129.457272-1-luis.pires@eldorado.org.br>
This is useful in situations where you want decodetree
to handle variable width instructions but you want to
provide custom code to load the instructions. Suppressing
the generation of the load function is necessary to avoid
compilation errors due to the load function being unused.
This will be used by the PowerPC decodetree code.
Signed-off-by: Luis Pires <luis.pires@eldorado.org.br>
---
scripts/decodetree.py | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 935b2964e0..a62b8d8d76 100644
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -1278,9 +1278,10 @@ def main():
global anyextern
decode_scope = 'static '
+ noloadfunc = False
long_opts = ['decode=', 'translate=', 'output=', 'insnwidth=',
- 'static-decode=', 'varinsnwidth=']
+ 'static-decode=', 'varinsnwidth=', 'noloadfunc']
try:
(opts, args) = getopt.gnu_getopt(sys.argv[1:], 'o:vw:', long_opts)
except getopt.GetoptError as err:
@@ -1312,6 +1313,8 @@ def main():
deposit_function = 'deposit64'
elif insnwidth != 32:
error(0, 'cannot handle insns of width', insnwidth)
+ elif o == '--noloadfunc':
+ noloadfunc = True
else:
assert False, 'unhandled option'
@@ -1401,12 +1404,13 @@ def main():
output(i4, 'return false;\n')
output('}\n')
- if variablewidth:
- output('\n', decode_scope, insntype, ' ', decode_function,
- '_load(DisasContext *ctx)\n{\n',
- ' ', insntype, ' insn = 0;\n\n')
- stree.output_code(4, 0, 0, 0)
- output('}\n')
+ if not noloadfunc:
+ if variablewidth:
+ output('\n', decode_scope, insntype, ' ', decode_function,
+ '_load(DisasContext *ctx)\n{\n',
+ ' ', insntype, ' insn = 0;\n\n')
+ stree.output_code(4, 0, 0, 0)
+ output('}\n')
if output_file:
output_fd.close()
--
2.25.1
next prev parent reply other threads:[~2021-04-13 21:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 21:11 [PATCH 0/5] Base for adding PowerPC 64-bit instructions Luis Pires
2021-04-13 21:11 ` [PATCH 1/5] decodetree: Add support for " Luis Pires
2021-04-13 21:11 ` [PATCH 2/5] decodetree: Fix empty input files for varinsnwidth Luis Pires
2021-04-14 19:47 ` Richard Henderson
2021-04-13 21:11 ` Luis Pires [this message]
2021-04-13 21:11 ` [PATCH 4/5] target/ppc: Base changes to allow 32/64-bit insns Luis Pires
2021-04-14 15:26 ` Richard Henderson
2021-04-14 16:09 ` Richard Henderson
2021-04-14 16:10 ` Richard Henderson
2021-04-13 21:11 ` [PATCH 5/5] target/ppc: Implement paddi and replace addi insns Luis Pires
2021-04-13 22:41 ` Philippe Mathieu-Daudé
2021-04-14 13:00 ` Luis Fernando Fujita Pires
2021-04-14 19:11 ` Richard Henderson
2021-04-14 23:07 ` Richard Henderson
2021-04-15 16:59 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413211129.457272-4-luis.pires@eldorado.org.br \
--to=luis.pires@eldorado.org.br \
--cc=bruno.larsen@eldorado.org.br \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=lagarcia@br.ibm.com \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).