* [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation
@ 2021-04-16 15:49 Ilya Leoshkevich
2021-04-16 15:49 ` [PATCH v5 1/4] target/s390x: Fix translation exception on illegal instruction Ilya Leoshkevich
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: Ilya Leoshkevich @ 2021-04-16 15:49 UTC (permalink / raw)
To: Cornelia Huck, Thomas Huth, Richard Henderson, David Hildenbrand,
Paolo Bonzini, Peter Maydell, Max Filippov
Cc: Christian Borntraeger, qemu-s390x, qemu-arm, qemu-devel,
Ilya Leoshkevich
If arch-specific code generates a translation block of size 0,
tb_gen_code() may generate a spurious exception.
Fix s390x (patch 1), ARM (patch 2) and xtensa (patch 3) and add an
assertion in order to catch such situations earlier (patch 4).
v1: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02037.html
v1 -> v2: Fix target/s390x instead of trying to tolerate tb->size == 0
in tb_gen_code().
v2: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02101.html
v2 -> v3: Split the common code change into a separate patch, add the
ARM patch in order to fix
https://gitlab.com/cohuck/qemu/-/jobs/1178409450
v3: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02332.html
v3 -> v4: Add the xtensa patch in order to fix
https://gitlab.com/cohuck/qemu/-/jobs/1178409540
v4: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02592.html
v4 -> v5: Handle thumb: the following C code triggers the assertion:
typedef void (*funcptr)(void);
int main() { funcptr f = (funcptr)0xffff0001; f(); }
Ilya Leoshkevich (4):
target/s390x: Fix translation exception on illegal instruction
target/arm: Make sure that commpage's tb->size != 0
target/xtensa: Make sure that tb->size != 0
accel/tcg: Assert that tb->size != 0 after translation
accel/tcg/translate-all.c | 1 +
target/arm/translate.c | 2 ++
target/s390x/translate.c | 16 +++++++++++-----
target/xtensa/translate.c | 3 +++
4 files changed, 17 insertions(+), 5 deletions(-)
--
2.29.2
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v5 1/4] target/s390x: Fix translation exception on illegal instruction
2021-04-16 15:49 [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation Ilya Leoshkevich
@ 2021-04-16 15:49 ` Ilya Leoshkevich
2021-04-16 15:49 ` [PATCH v5 2/4] target/arm: Make sure that commpage's tb->size != 0 Ilya Leoshkevich
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Ilya Leoshkevich @ 2021-04-16 15:49 UTC (permalink / raw)
To: Cornelia Huck, Thomas Huth, Richard Henderson, David Hildenbrand,
Paolo Bonzini, Peter Maydell, Max Filippov
Cc: Christian Borntraeger, qemu-s390x, qemu-arm, qemu-devel,
Ilya Leoshkevich
Hitting an uretprobe in a s390x TCG guest causes a SIGSEGV. What
happens is:
* uretprobe maps a userspace page containing an invalid instruction.
* uretprobe replaces the target function's return address with the
address of that page.
* When tb_gen_code() is called on that page, tb->size ends up being 0
(because the page starts with the invalid instruction), which causes
virt_page2 to point to the previous page.
* The previous page is not mapped, so this causes a spurious
translation exception.
tb->size must never be 0: even if there is an illegal instruction, the
instruction bytes that have been looked at must count towards tb->size.
So adjust s390x's translate_one() to act this way for both illegal
instructions and instructions that are known to generate exceptions.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
target/s390x/translate.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 4f953ddfba..e243624d2a 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -6412,7 +6412,8 @@ static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s)
qemu_log_mask(LOG_UNIMP, "unimplemented opcode 0x%02x%02x\n",
s->fields.op, s->fields.op2);
gen_illegal_opcode(s);
- return DISAS_NORETURN;
+ ret = DISAS_NORETURN;
+ goto out;
}
#ifndef CONFIG_USER_ONLY
@@ -6428,7 +6429,8 @@ static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s)
/* privileged instruction */
if ((s->base.tb->flags & FLAG_MASK_PSTATE) && (insn->flags & IF_PRIV)) {
gen_program_exception(s, PGM_PRIVILEGED);
- return DISAS_NORETURN;
+ ret = DISAS_NORETURN;
+ goto out;
}
/* if AFP is not enabled, instructions and registers are forbidden */
@@ -6455,7 +6457,8 @@ static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s)
}
if (dxc) {
gen_data_exception(dxc);
- return DISAS_NORETURN;
+ ret = DISAS_NORETURN;
+ goto out;
}
}
@@ -6463,7 +6466,8 @@ static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s)
if (insn->flags & IF_VEC) {
if (!((s->base.tb->flags & FLAG_MASK_VECTOR))) {
gen_data_exception(0xfe);
- return DISAS_NORETURN;
+ ret = DISAS_NORETURN;
+ goto out;
}
}
@@ -6484,7 +6488,8 @@ static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s)
(insn->spec & SPEC_r1_f128 && !is_fp_pair(get_field(s, r1))) ||
(insn->spec & SPEC_r2_f128 && !is_fp_pair(get_field(s, r2)))) {
gen_program_exception(s, PGM_SPECIFICATION);
- return DISAS_NORETURN;
+ ret = DISAS_NORETURN;
+ goto out;
}
}
@@ -6544,6 +6549,7 @@ static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s)
}
#endif
+out:
/* Advance to the next instruction. */
s->base.pc_next = s->pc_tmp;
return ret;
--
2.29.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v5 2/4] target/arm: Make sure that commpage's tb->size != 0
2021-04-16 15:49 [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation Ilya Leoshkevich
2021-04-16 15:49 ` [PATCH v5 1/4] target/s390x: Fix translation exception on illegal instruction Ilya Leoshkevich
@ 2021-04-16 15:49 ` Ilya Leoshkevich
2021-04-23 17:49 ` Richard Henderson
2021-04-16 15:49 ` [PATCH v5 3/4] target/xtensa: Make sure that " Ilya Leoshkevich
` (3 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Ilya Leoshkevich @ 2021-04-16 15:49 UTC (permalink / raw)
To: Cornelia Huck, Thomas Huth, Richard Henderson, David Hildenbrand,
Paolo Bonzini, Peter Maydell, Max Filippov
Cc: Christian Borntraeger, qemu-s390x, qemu-arm, qemu-devel,
Ilya Leoshkevich
tb_gen_code() assumes that tb->size must never be zero, otherwise it
may produce spurious exceptions. For ARM this may happen when creating
a translation block for the commpage.
Fix by pretending that commpage translation blocks have at least one
instruction.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
target/arm/translate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 62b1c2081b..cb9e30c341 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -9060,6 +9060,7 @@ static void arm_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
unsigned int insn;
if (arm_pre_translate_insn(dc)) {
+ dc->base.pc_next += 4;
return;
}
@@ -9129,6 +9130,7 @@ static void thumb_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
bool is_16bit;
if (arm_pre_translate_insn(dc)) {
+ dc->base.pc_next += 2;
return;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v5 3/4] target/xtensa: Make sure that tb->size != 0
2021-04-16 15:49 [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation Ilya Leoshkevich
2021-04-16 15:49 ` [PATCH v5 1/4] target/s390x: Fix translation exception on illegal instruction Ilya Leoshkevich
2021-04-16 15:49 ` [PATCH v5 2/4] target/arm: Make sure that commpage's tb->size != 0 Ilya Leoshkevich
@ 2021-04-16 15:49 ` Ilya Leoshkevich
2021-04-16 15:49 ` [PATCH v5 4/4] accel/tcg: Assert that tb->size != 0 after translation Ilya Leoshkevich
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Ilya Leoshkevich @ 2021-04-16 15:49 UTC (permalink / raw)
To: Cornelia Huck, Thomas Huth, Richard Henderson, David Hildenbrand,
Paolo Bonzini, Peter Maydell, Max Filippov
Cc: Christian Borntraeger, qemu-s390x, qemu-arm, qemu-devel,
Ilya Leoshkevich
tb_gen_code() assumes that tb->size must never be zero, otherwise it
may produce spurious exceptions. For xtensa this may happen when
decoding an unknown instruction, when handling a write into the
CCOUNT or CCOMPARE special register and when single-stepping the first
instruction of an exception handler.
Fix by pretending that the size of the respective translation block is
1 in all these cases.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Tested-by: Max Filippov <jcmvbkbc@gmail.com>
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
---
target/xtensa/translate.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 0ae4efc48a..73584d9d60 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -917,6 +917,7 @@ static void disas_xtensa_insn(CPUXtensaState *env, DisasContext *dc)
"unknown instruction length (pc = %08x)\n",
dc->pc);
gen_exception_cause(dc, ILLEGAL_INSTRUCTION_CAUSE);
+ dc->base.pc_next = dc->pc + 1;
return;
}
@@ -1274,11 +1275,13 @@ static void xtensa_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
if ((tb_cflags(dc->base.tb) & CF_USE_ICOUNT)
&& (dc->base.tb->flags & XTENSA_TBFLAG_YIELD)) {
gen_exception(dc, EXCP_YIELD);
+ dc->base.pc_next = dc->pc + 1;
dc->base.is_jmp = DISAS_NORETURN;
return;
}
if (dc->base.tb->flags & XTENSA_TBFLAG_EXCEPTION) {
gen_exception(dc, EXCP_DEBUG);
+ dc->base.pc_next = dc->pc + 1;
dc->base.is_jmp = DISAS_NORETURN;
return;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v5 4/4] accel/tcg: Assert that tb->size != 0 after translation
2021-04-16 15:49 [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation Ilya Leoshkevich
` (2 preceding siblings ...)
2021-04-16 15:49 ` [PATCH v5 3/4] target/xtensa: Make sure that " Ilya Leoshkevich
@ 2021-04-16 15:49 ` Ilya Leoshkevich
2021-04-23 10:31 ` [PATCH v5 0/4] accel/tcg: Make sure " Cornelia Huck
2021-04-26 10:01 ` Cornelia Huck
5 siblings, 0 replies; 10+ messages in thread
From: Ilya Leoshkevich @ 2021-04-16 15:49 UTC (permalink / raw)
To: Cornelia Huck, Thomas Huth, Richard Henderson, David Hildenbrand,
Paolo Bonzini, Peter Maydell, Max Filippov
Cc: Christian Borntraeger, qemu-s390x, qemu-arm, qemu-devel,
Ilya Leoshkevich
If arch-specific code generates a translation block of size 0,
tb_gen_code() may generate a spurious exception. Add an assertion in
order to catch such situations early.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
accel/tcg/translate-all.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index ba6ab09790..93b2dae112 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -1913,6 +1913,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu,
tcg_ctx->cpu = env_cpu(env);
gen_intermediate_code(cpu, tb, max_insns);
+ assert(tb->size != 0);
tcg_ctx->cpu = NULL;
max_insns = tb->icount;
--
2.29.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation
2021-04-16 15:49 [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation Ilya Leoshkevich
` (3 preceding siblings ...)
2021-04-16 15:49 ` [PATCH v5 4/4] accel/tcg: Assert that tb->size != 0 after translation Ilya Leoshkevich
@ 2021-04-23 10:31 ` Cornelia Huck
2021-04-23 17:50 ` Richard Henderson
2021-04-26 10:01 ` Cornelia Huck
5 siblings, 1 reply; 10+ messages in thread
From: Cornelia Huck @ 2021-04-23 10:31 UTC (permalink / raw)
To: Ilya Leoshkevich
Cc: Peter Maydell, Thomas Huth, David Hildenbrand, Richard Henderson,
qemu-devel, Max Filippov, qemu-s390x, qemu-arm, Paolo Bonzini,
Christian Borntraeger
On Fri, 16 Apr 2021 17:49:35 +0200
Ilya Leoshkevich <iii@linux.ibm.com> wrote:
> If arch-specific code generates a translation block of size 0,
> tb_gen_code() may generate a spurious exception.
>
> Fix s390x (patch 1), ARM (patch 2) and xtensa (patch 3) and add an
> assertion in order to catch such situations earlier (patch 4).
>
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02037.html
> v1 -> v2: Fix target/s390x instead of trying to tolerate tb->size == 0
> in tb_gen_code().
>
> v2: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02101.html
> v2 -> v3: Split the common code change into a separate patch, add the
> ARM patch in order to fix
> https://gitlab.com/cohuck/qemu/-/jobs/1178409450
>
> v3: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02332.html
> v3 -> v4: Add the xtensa patch in order to fix
> https://gitlab.com/cohuck/qemu/-/jobs/1178409540
>
> v4: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02592.html
> v4 -> v5: Handle thumb: the following C code triggers the assertion:
> typedef void (*funcptr)(void);
> int main() { funcptr f = (funcptr)0xffff0001; f(); }
>
> Ilya Leoshkevich (4):
> target/s390x: Fix translation exception on illegal instruction
> target/arm: Make sure that commpage's tb->size != 0
> target/xtensa: Make sure that tb->size != 0
> accel/tcg: Assert that tb->size != 0 after translation
>
> accel/tcg/translate-all.c | 1 +
> target/arm/translate.c | 2 ++
> target/s390x/translate.c | 16 +++++++++++-----
> target/xtensa/translate.c | 3 +++
> 4 files changed, 17 insertions(+), 5 deletions(-)
>
So, what's the way forward here? I can pick this if I get an ack for
the arm patch. If someone else wants to take this, I'll just ack the
s390x patch.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v5 2/4] target/arm: Make sure that commpage's tb->size != 0
2021-04-16 15:49 ` [PATCH v5 2/4] target/arm: Make sure that commpage's tb->size != 0 Ilya Leoshkevich
@ 2021-04-23 17:49 ` Richard Henderson
0 siblings, 0 replies; 10+ messages in thread
From: Richard Henderson @ 2021-04-23 17:49 UTC (permalink / raw)
To: Ilya Leoshkevich, Cornelia Huck, Thomas Huth, David Hildenbrand,
Paolo Bonzini, Peter Maydell, Max Filippov
Cc: Christian Borntraeger, qemu-s390x, qemu-arm, qemu-devel
On 4/16/21 8:49 AM, Ilya Leoshkevich wrote:
> tb_gen_code() assumes that tb->size must never be zero, otherwise it
> may produce spurious exceptions. For ARM this may happen when creating
> a translation block for the commpage.
>
> Fix by pretending that commpage translation blocks have at least one
> instruction.
>
> Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com>
> ---
> target/arm/translate.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation
2021-04-23 10:31 ` [PATCH v5 0/4] accel/tcg: Make sure " Cornelia Huck
@ 2021-04-23 17:50 ` Richard Henderson
2021-04-26 10:00 ` Cornelia Huck
0 siblings, 1 reply; 10+ messages in thread
From: Richard Henderson @ 2021-04-23 17:50 UTC (permalink / raw)
To: Cornelia Huck, Ilya Leoshkevich
Cc: Peter Maydell, Thomas Huth, Christian Borntraeger,
David Hildenbrand, qemu-devel, Max Filippov, qemu-s390x,
qemu-arm, Paolo Bonzini
On 4/23/21 3:31 AM, Cornelia Huck wrote:
> So, what's the way forward here? I can pick this if I get an ack for
> the arm patch. If someone else wants to take this, I'll just ack the
> s390x patch.
You've volunteered, so that means you get it, I think. ;-)
r~
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation
2021-04-23 17:50 ` Richard Henderson
@ 2021-04-26 10:00 ` Cornelia Huck
0 siblings, 0 replies; 10+ messages in thread
From: Cornelia Huck @ 2021-04-26 10:00 UTC (permalink / raw)
To: Richard Henderson
Cc: Peter Maydell, Thomas Huth, Ilya Leoshkevich, David Hildenbrand,
qemu-devel, Max Filippov, qemu-s390x, qemu-arm, Paolo Bonzini,
Christian Borntraeger
On Fri, 23 Apr 2021 10:50:59 -0700
Richard Henderson <richard.henderson@linaro.org> wrote:
> On 4/23/21 3:31 AM, Cornelia Huck wrote:
> > So, what's the way forward here? I can pick this if I get an ack for
> > the arm patch. If someone else wants to take this, I'll just ack the
> > s390x patch.
>
> You've volunteered, so that means you get it, I think. ;-)
>
>
> r~
>
I guessed as much :) Thanks for your review!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation
2021-04-16 15:49 [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation Ilya Leoshkevich
` (4 preceding siblings ...)
2021-04-23 10:31 ` [PATCH v5 0/4] accel/tcg: Make sure " Cornelia Huck
@ 2021-04-26 10:01 ` Cornelia Huck
5 siblings, 0 replies; 10+ messages in thread
From: Cornelia Huck @ 2021-04-26 10:01 UTC (permalink / raw)
To: Ilya Leoshkevich
Cc: Peter Maydell, Thomas Huth, David Hildenbrand, Richard Henderson,
qemu-devel, Max Filippov, qemu-s390x, qemu-arm, Paolo Bonzini,
Christian Borntraeger
On Fri, 16 Apr 2021 17:49:35 +0200
Ilya Leoshkevich <iii@linux.ibm.com> wrote:
> If arch-specific code generates a translation block of size 0,
> tb_gen_code() may generate a spurious exception.
>
> Fix s390x (patch 1), ARM (patch 2) and xtensa (patch 3) and add an
> assertion in order to catch such situations earlier (patch 4).
>
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02037.html
> v1 -> v2: Fix target/s390x instead of trying to tolerate tb->size == 0
> in tb_gen_code().
>
> v2: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02101.html
> v2 -> v3: Split the common code change into a separate patch, add the
> ARM patch in order to fix
> https://gitlab.com/cohuck/qemu/-/jobs/1178409450
>
> v3: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02332.html
> v3 -> v4: Add the xtensa patch in order to fix
> https://gitlab.com/cohuck/qemu/-/jobs/1178409540
>
> v4: https://lists.nongnu.org/archive/html/qemu-devel/2021-04/msg02592.html
> v4 -> v5: Handle thumb: the following C code triggers the assertion:
> typedef void (*funcptr)(void);
> int main() { funcptr f = (funcptr)0xffff0001; f(); }
>
> Ilya Leoshkevich (4):
> target/s390x: Fix translation exception on illegal instruction
> target/arm: Make sure that commpage's tb->size != 0
> target/xtensa: Make sure that tb->size != 0
> accel/tcg: Assert that tb->size != 0 after translation
>
> accel/tcg/translate-all.c | 1 +
> target/arm/translate.c | 2 ++
> target/s390x/translate.c | 16 +++++++++++-----
> target/xtensa/translate.c | 3 +++
> 4 files changed, 17 insertions(+), 5 deletions(-)
>
Thanks, queued to s390-next.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-04-26 10:03 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 15:49 [PATCH v5 0/4] accel/tcg: Make sure that tb->size != 0 after translation Ilya Leoshkevich
2021-04-16 15:49 ` [PATCH v5 1/4] target/s390x: Fix translation exception on illegal instruction Ilya Leoshkevich
2021-04-16 15:49 ` [PATCH v5 2/4] target/arm: Make sure that commpage's tb->size != 0 Ilya Leoshkevich
2021-04-23 17:49 ` Richard Henderson
2021-04-16 15:49 ` [PATCH v5 3/4] target/xtensa: Make sure that " Ilya Leoshkevich
2021-04-16 15:49 ` [PATCH v5 4/4] accel/tcg: Assert that tb->size != 0 after translation Ilya Leoshkevich
2021-04-23 10:31 ` [PATCH v5 0/4] accel/tcg: Make sure " Cornelia Huck
2021-04-23 17:50 ` Richard Henderson
2021-04-26 10:00 ` Cornelia Huck
2021-04-26 10:01 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).