From: Vivek Goyal <vgoyal@redhat.com>
To: Mahmoud Mandour <ma.mandourr@gmail.com>
Cc: "open list:virtiofs" <virtio-fs@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH v2 1/7] virtiofsd: Changed allocations of fuse_req to GLib functions
Date: Tue, 20 Apr 2021 15:03:34 -0400 [thread overview]
Message-ID: <20210420190334.GE1529659@redhat.com> (raw)
In-Reply-To: <20210420154643.58439-2-ma.mandourr@gmail.com>
On Tue, Apr 20, 2021 at 05:46:36PM +0200, Mahmoud Mandour wrote:
> Replaced the allocation and deallocation of fuse_req structs
> using calloc()/free() call pairs to a GLib's g_try_new0()
> and g_free().
Hi,
What's the context of these patches. I see all of them are switching
to glib functions. Why to do that? What's the advantage.
Vivek
>
> Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> tools/virtiofsd/fuse_lowlevel.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c
> index 58e32fc963..812cef6ef6 100644
> --- a/tools/virtiofsd/fuse_lowlevel.c
> +++ b/tools/virtiofsd/fuse_lowlevel.c
> @@ -106,7 +106,7 @@ static void list_add_req(struct fuse_req *req, struct fuse_req *next)
> static void destroy_req(fuse_req_t req)
> {
> pthread_mutex_destroy(&req->lock);
> - free(req);
> + g_free(req);
> }
>
> void fuse_free_req(fuse_req_t req)
> @@ -130,7 +130,7 @@ static struct fuse_req *fuse_ll_alloc_req(struct fuse_session *se)
> {
> struct fuse_req *req;
>
> - req = (struct fuse_req *)calloc(1, sizeof(struct fuse_req));
> + req = g_try_new0(struct fuse_req, 1);
> if (req == NULL) {
> fuse_log(FUSE_LOG_ERR, "fuse: failed to allocate request\n");
> } else {
> @@ -1684,7 +1684,7 @@ static struct fuse_req *check_interrupt(struct fuse_session *se,
> if (curr->u.i.unique == req->unique) {
> req->interrupted = 1;
> list_del_req(curr);
> - free(curr);
> + g_free(curr);
> return NULL;
> }
> }
> --
> 2.25.1
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://listman.redhat.com/mailman/listinfo/virtio-fs
next prev parent reply other threads:[~2021-04-20 19:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 15:46 [PATCH v2 0/7] virtiofsd: Changed various allocations to GLib functions Mahmoud Mandour
2021-04-20 15:46 ` [PATCH v2 1/7] virtiofsd: Changed allocations of fuse_req " Mahmoud Mandour
2021-04-20 19:03 ` Vivek Goyal [this message]
2021-04-21 0:39 ` [Virtio-fs] " Mahmoud Mandour
2021-04-27 9:48 ` Dr. David Alan Gilbert
2021-04-20 15:46 ` [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions Mahmoud Mandour
2021-04-27 10:24 ` Dr. David Alan Gilbert
2021-04-27 10:53 ` Mahmoud Mandour
2021-04-27 11:01 ` Dr. David Alan Gilbert
2021-04-27 11:08 ` Mahmoud Mandour
2021-04-27 11:33 ` Dr. David Alan Gilbert
2021-04-27 18:13 ` [PATCH v3 2/7] virtiofsd: " Mahmoud Mandour
2021-05-06 9:39 ` Dr. David Alan Gilbert
2021-04-27 18:19 ` [PATCH v2 2/7] virtiofds: " Mahmoud Mandour
2021-04-27 18:41 ` Dr. David Alan Gilbert
2021-04-27 10:57 ` Daniel P. Berrangé
2021-04-20 15:46 ` [PATCH v2 3/7] virtiofsd: Changed allocations of fuse_session " Mahmoud Mandour
2021-04-20 15:46 ` [PATCH v2 4/7] virtiofsd: Changed allocation of lo_map_elems " Mahmoud Mandour
2021-04-20 15:46 ` [PATCH v2 5/7] virtiofsd: Changed allocations of fv_VuDev & its internals to GLib functions Mahmoud Mandour
2021-04-20 15:46 ` [PATCH v2 6/7] virtiofsd/passthrough_ll.c: Changed local allocations " Mahmoud Mandour
2021-04-20 15:46 ` [PATCH v2 7/7] virtiofsd/fuse_virtio.c: Changed allocations of locals to GLib Mahmoud Mandour
2021-05-06 16:27 ` [PATCH v2 0/7] virtiofsd: Changed various allocations to GLib functions Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420190334.GE1529659@redhat.com \
--to=vgoyal@redhat.com \
--cc=ma.mandourr@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).