* [PULL v2 00/32] Misc (mostly i386) patches for 2021-05-11
@ 2021-05-12 8:40 Paolo Bonzini
2021-05-13 19:12 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2021-05-12 8:40 UTC (permalink / raw)
To: qemu-devel
The following changes since commit e58c7a3bba3076890592f02d2b0e596bf191b5c2:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210510-1' into staging (2021-05-10 17:28:11 +0100)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to e804f892b90e58861edd79aafa4d1f4dbdeb3819:
coverity-scan: list components, move model to scripts/coverity-scan (2021-05-12 04:06:50 -0400)
----------------------------------------------------------------
* AccelCPUClass and sysemu/user split for i386 (Claudio)
* i386 page walk unification
* Fix detection of gdbus-codegen
* Misc refactoring
----------------------------------------------------------------
v1->v2: dropped incorrect snapshot-load patch
Claudio Fontana (18):
i386: split cpu accelerators from cpu.c, using AccelCPUClass
cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn
accel: introduce new accessor functions
target/i386: fix host_cpu_adjust_phys_bits error handling
accel-cpu: make cpu_realizefn return a bool
i386: split smm helper (sysemu)
i386: split tcg excp_helper into sysemu and user parts
i386: move TCG bpt_helper into sysemu/
i386: split misc helper user stubs and sysemu part
i386: separate fpu_helper sysemu-only parts
i386: split svm_helper into sysemu and stub-only user
i386: split seg_helper into user-only and sysemu parts
i386: split off sysemu part of cpu.c
target/i386: gdbstub: introduce aux functions to read/write CS64 regs
target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu
i386: make cpu_load_efer sysemu-only
accel: move call to accel_init_interfaces
accel: add init_accel_cpu for adapting accel behavior to CPU type
Paolo Bonzini (12):
i386: split off sysemu-only functionality in tcg-cpu
target/i386: merge SVM_NPTEXIT_* with PF_ERROR_* constants
target/i386: move paging mode constants from SVM to cpu.h
target/i386: extract mmu_translate
target/i386: pass cr3 to mmu_translate
target/i386: extend pg_mode to more CR0 and CR4 bits
target/i386: allow customizing the next phase of the translation
target/i386: use mmu_translate for NPT walk
main-loop: remove dead code
qemu-option: support accept-any QemuOptsList in qemu_opts_absorb_qdict
configure: fix detection of gdbus-codegen
coverity-scan: list components, move model to scripts/coverity-scan
Richard Henderson (2):
target/i386: Rename helper_fldt, helper_fstt
target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor
MAINTAINERS | 2 +-
accel/accel-common.c | 32 +
bsd-user/main.c | 2 +-
configure | 4 +-
cpu.c | 5 +-
hw/core/machine.c | 1 +
hw/i386/pc_piix.c | 1 +
include/hw/core/accel-cpu.h | 2 +-
include/hw/core/cpu.h | 6 +
include/qemu/accel.h | 13 +
include/qemu/main-loop.h | 18 -
linux-user/main.c | 2 +-
scripts/coverity-scan/COMPONENTS.md | 154 ++++
.../{coverity-model.c => coverity-scan/model.c} | 0
softmmu/vl.c | 1 -
target/i386/cpu-internal.h | 70 ++
target/i386/cpu-sysemu.c | 352 ++++++++++
target/i386/cpu.c | 775 ++-------------------
target/i386/cpu.h | 59 +-
target/i386/gdbstub.c | 165 ++---
target/i386/helper.c | 13 +
target/i386/helper.h | 11 +
target/i386/host-cpu.c | 204 ++++++
target/i386/host-cpu.h | 19 +
target/i386/hvf/hvf-cpu.c | 68 ++
target/i386/hvf/meson.build | 1 +
target/i386/kvm/kvm-cpu.c | 151 ++++
target/i386/kvm/kvm-cpu.h | 41 ++
target/i386/kvm/kvm.c | 3 +-
target/i386/kvm/meson.build | 7 +-
target/i386/meson.build | 9 +-
target/i386/svm.h | 10 -
target/i386/tcg/bpt_helper.c | 276 --------
target/i386/tcg/excp_helper.c | 573 ---------------
target/i386/tcg/fpu_helper.c | 106 ++-
target/i386/tcg/helper-tcg.h | 8 +
target/i386/tcg/meson.build | 5 +-
target/i386/tcg/misc_helper.c | 467 -------------
target/i386/tcg/seg_helper.c | 237 +------
target/i386/tcg/seg_helper.h | 66 ++
target/i386/tcg/sysemu/bpt_helper.c | 293 ++++++++
target/i386/tcg/sysemu/excp_helper.c | 471 +++++++++++++
target/i386/tcg/sysemu/fpu_helper.c | 57 ++
target/i386/tcg/sysemu/meson.build | 10 +
target/i386/tcg/sysemu/misc_helper.c | 442 ++++++++++++
target/i386/tcg/sysemu/seg_helper.c | 125 ++++
target/i386/tcg/{ => sysemu}/smm_helper.c | 19 +-
target/i386/tcg/{ => sysemu}/svm_helper.c | 75 +-
target/i386/tcg/sysemu/tcg-cpu.c | 83 +++
target/i386/tcg/tcg-cpu.c | 56 +-
target/i386/tcg/tcg-cpu.h | 21 +-
target/i386/tcg/translate.c | 13 +-
target/i386/tcg/user/excp_helper.c | 39 ++
target/i386/tcg/user/meson.build | 6 +
target/i386/tcg/user/misc_stubs.c | 75 ++
target/i386/tcg/user/seg_helper.c | 109 +++
target/i386/tcg/user/svm_stubs.c | 76 ++
util/main-loop.c | 61 --
util/qemu-option.c | 3 +-
59 files changed, 3299 insertions(+), 2674 deletions(-)
create mode 100644 scripts/coverity-scan/COMPONENTS.md
rename scripts/{coverity-model.c => coverity-scan/model.c} (100%)
create mode 100644 target/i386/cpu-internal.h
create mode 100644 target/i386/cpu-sysemu.c
create mode 100644 target/i386/host-cpu.c
create mode 100644 target/i386/host-cpu.h
create mode 100644 target/i386/hvf/hvf-cpu.c
create mode 100644 target/i386/kvm/kvm-cpu.c
create mode 100644 target/i386/kvm/kvm-cpu.h
create mode 100644 target/i386/tcg/seg_helper.h
create mode 100644 target/i386/tcg/sysemu/bpt_helper.c
create mode 100644 target/i386/tcg/sysemu/excp_helper.c
create mode 100644 target/i386/tcg/sysemu/fpu_helper.c
create mode 100644 target/i386/tcg/sysemu/meson.build
create mode 100644 target/i386/tcg/sysemu/misc_helper.c
create mode 100644 target/i386/tcg/sysemu/seg_helper.c
rename target/i386/tcg/{ => sysemu}/smm_helper.c (98%)
rename target/i386/tcg/{ => sysemu}/svm_helper.c (95%)
create mode 100644 target/i386/tcg/sysemu/tcg-cpu.c
create mode 100644 target/i386/tcg/user/excp_helper.c
create mode 100644 target/i386/tcg/user/meson.build
create mode 100644 target/i386/tcg/user/misc_stubs.c
create mode 100644 target/i386/tcg/user/seg_helper.c
create mode 100644 target/i386/tcg/user/svm_stubs.c
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PULL v2 00/32] Misc (mostly i386) patches for 2021-05-11
2021-05-12 8:40 [PULL v2 00/32] Misc (mostly i386) patches for 2021-05-11 Paolo Bonzini
@ 2021-05-13 19:12 ` Peter Maydell
2021-05-13 20:39 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2021-05-13 19:12 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers
On Wed, 12 May 2021 at 09:43, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The following changes since commit e58c7a3bba3076890592f02d2b0e596bf191b5c2:
>
> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210510-1' into staging (2021-05-10 17:28:11 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to e804f892b90e58861edd79aafa4d1f4dbdeb3819:
>
> coverity-scan: list components, move model to scripts/coverity-scan (2021-05-12 04:06:50 -0400)
>
> ----------------------------------------------------------------
> * AccelCPUClass and sysemu/user split for i386 (Claudio)
> * i386 page walk unification
> * Fix detection of gdbus-codegen
> * Misc refactoring
>
> ----------------------------------------------------------------
> v1->v2: dropped incorrect snapshot-load patch
Something weird has happened here.
I think I applied v1 of this pullreq (merge commit 31589644ba069ba06c5
now in master), and then when I came along to try to process this
one the tag was an entirely different set of commits.
Can you check whether what is in master is what you intended, and
send a revert/fixup patch if necessary, please?
PS: my scripts detected this issue:
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
ERROR: pull request includes tag with UTF-8 error in person name
which you probably want to fix before you send a future pullreq
with those commits in. (This error is what nudged me into looking
more closely and realizing something weird was going on...)
Side note: it is more robust if you don't reuse pullreq tag names...
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PULL v2 00/32] Misc (mostly i386) patches for 2021-05-11
2021-05-13 19:12 ` Peter Maydell
@ 2021-05-13 20:39 ` Paolo Bonzini
2021-05-14 9:07 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2021-05-13 20:39 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Developers
On 13/05/21 21:12, Peter Maydell wrote:
> Something weird has happened here.
>
> I think I applied v1 of this pullreq (merge commit 31589644ba069ba06c5
> now in master), and then when I came along to try to process this
> one the tag was an entirely different set of commits.
>
> Can you check whether what is in master is what you intended, and
> send a revert/fixup patch if necessary, please?
Yes, it is. You processed the tag that had already moved to v2, but
replied to the buggy v1.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PULL v2 00/32] Misc (mostly i386) patches for 2021-05-11
2021-05-13 20:39 ` Paolo Bonzini
@ 2021-05-14 9:07 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2021-05-14 9:07 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: QEMU Developers
On Thu, 13 May 2021 at 21:39, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 13/05/21 21:12, Peter Maydell wrote:
> > Something weird has happened here.
> >
> > I think I applied v1 of this pullreq (merge commit 31589644ba069ba06c5
> > now in master), and then when I came along to try to process this
> > one the tag was an entirely different set of commits.
> >
> > Can you check whether what is in master is what you intended, and
> > send a revert/fixup patch if necessary, please?
>
> Yes, it is. You processed the tag that had already moved to v2, but
> replied to the buggy v1.
If you want me not to process something you do need to reply to
the cover letter. Otherwise I won't see it...
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-14 9:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 8:40 [PULL v2 00/32] Misc (mostly i386) patches for 2021-05-11 Paolo Bonzini
2021-05-13 19:12 ` Peter Maydell
2021-05-13 20:39 ` Paolo Bonzini
2021-05-14 9:07 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).