Re: [PATCH 0/6] pc: support user provided NIC naming/indexing

From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: jusual@redhat.com, qemu-devel@nongnu.org, laine@redhat.com
Subject: Re: [PATCH 0/6] pc: support user provided NIC naming/indexing
Date: Fri, 14 May 2021 09:32:27 -0400	[thread overview]
Message-ID: <20210514093116-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210315180102.3008391-1-imammedo@redhat.com>

On Mon, Mar 15, 2021 at 02:00:56PM -0400, Igor Mammedov wrote:
> 
> Changes since rfc:
>   * make sure that acpi-index unique
>   * use dedicated MMIO register for it
>   * drop syntetic acpi-label field in _DSM
>   * add more comments

Could you rebase and repost please?
Some comments in commit log about use for non-NIC devices
would be helpful (even if it's just that "currently does not seem to be useful for
non-NICs").

> Series implements support for 'onboard' naming scheme for network
> interfaces (1), which is based on PCI firmware spec and lets user
> to explicitly specify index that will be used by guest to name
> network interface, ex:
>     -device e1000,acpi-index=33
> should make guest rename NIC name to 'eno33' where 'eno' is default
> prefix for this scheme.
> 
> Hope is that it will allow to simplify launching VMs from
> template disk images with different set VM configurations
> without need to reconfigure guest network intrfaces or
> risk of loosing network connectivity.
> 
> For more detailed description/examples see patches [3-4/5]
> 
> 1)
>  https://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/ 
> 
> Git repo for testing:
>    https://github.com/imammedo/qemu/branches acpi-index-v1
> 
> 
> CC: laine@redhat.com
> CC: mst@redhat.com
> CC: jusual@redhat.com
> 
> Igor Mammedov (6):
>   tests: acpi: temporary whitelist DSDT changes
>   pci: introduce apci-index property for PCI device
>   pci: acpi: ensure that acpi-index is unique
>   acpi: add aml_to_decimalstring() and aml_call6() helpers
>   pci: acpi: add _DSM method to PCI devices
>   tests: acpi: update expected blobs
> 
>  include/hw/acpi/aml-build.h      |   3 +
>  include/hw/acpi/pci.h            |   1 +
>  include/hw/acpi/pcihp.h          |   9 ++-
>  include/hw/pci/pci.h             |   1 +
>  hw/acpi/aml-build.c              |  28 ++++++++
>  hw/acpi/pci.c                    |   1 -
>  hw/acpi/pcihp.c                  | 104 ++++++++++++++++++++++++++-
>  hw/acpi/piix4.c                  |   3 +-
>  hw/acpi/trace-events             |   2 +
>  hw/i386/acpi-build.c             | 118 +++++++++++++++++++++++++++++--
>  hw/pci/pci.c                     |   1 +
>  tests/data/acpi/pc/DSDT          | Bin 5065 -> 6002 bytes
>  tests/data/acpi/pc/DSDT.acpihmat | Bin 6390 -> 7327 bytes
>  tests/data/acpi/pc/DSDT.bridge   | Bin 6924 -> 8668 bytes
>  tests/data/acpi/pc/DSDT.cphp     | Bin 5529 -> 6466 bytes
>  tests/data/acpi/pc/DSDT.dimmpxm  | Bin 6719 -> 7656 bytes
>  tests/data/acpi/pc/DSDT.hpbridge | Bin 5026 -> 5969 bytes
>  tests/data/acpi/pc/DSDT.ipmikcs  | Bin 5137 -> 6074 bytes
>  tests/data/acpi/pc/DSDT.memhp    | Bin 6424 -> 7361 bytes
>  tests/data/acpi/pc/DSDT.nohpet   | Bin 4923 -> 5860 bytes
>  tests/data/acpi/pc/DSDT.numamem  | Bin 5071 -> 6008 bytes
>  tests/data/acpi/pc/DSDT.roothp   | Bin 5261 -> 6210 bytes
>  22 files changed, 261 insertions(+), 10 deletions(-)
> 
> -- 
> 2.27.0