qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cho, Yu-Chen" <acho@suse.com>
To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Cc: cfontana@suse.com, acho@suse.com,
	Claudio Fontana <cfontana@suse.de>,
	David Hildenbrand <david@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>
Subject: [RFC v5 05/13] target/s390x: remove tcg-stub.c
Date: Tue, 22 Jun 2021 18:17:18 +0800	[thread overview]
Message-ID: <20210622101726.20860-6-acho@suse.com> (raw)
In-Reply-To: <20210622101726.20860-1-acho@suse.com>

now that we protect all calls to the tcg-specific functions
with if (tcg_enabled()), we do not need the TCG stub anymore.

Signed-off-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Cho, Yu-Chen <acho@suse.com>
---
 target/s390x/meson.build |  2 +-
 target/s390x/tcg-stub.c  | 30 ------------------------------
 2 files changed, 1 insertion(+), 31 deletions(-)
 delete mode 100644 target/s390x/tcg-stub.c

diff --git a/target/s390x/meson.build b/target/s390x/meson.build
index 1219f64112..a5e1ded93f 100644
--- a/target/s390x/meson.build
+++ b/target/s390x/meson.build
@@ -21,7 +21,7 @@ s390x_ss.add(when: 'CONFIG_TCG', if_true: files(
   'vec_helper.c',
   'vec_int_helper.c',
   'vec_string_helper.c',
-), if_false: files('tcg-stub.c'))
+))
 
 s390x_ss.add(when: 'CONFIG_KVM', if_true: files('kvm.c'), if_false: files('kvm-stub.c'))
 
diff --git a/target/s390x/tcg-stub.c b/target/s390x/tcg-stub.c
deleted file mode 100644
index d22c898802..0000000000
--- a/target/s390x/tcg-stub.c
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * QEMU TCG support -- s390x specific function stubs.
- *
- * Copyright (C) 2018 Red Hat Inc
- *
- * Authors:
- *   David Hildenbrand <david@redhat.com>
- *
- * This work is licensed under the terms of the GNU GPL, version 2 or later.
- * See the COPYING file in the top-level directory.
- */
-
-#include "qemu/osdep.h"
-#include "qemu-common.h"
-#include "cpu.h"
-#include "tcg_s390x.h"
-
-void tcg_s390_tod_updated(CPUState *cs, run_on_cpu_data opaque)
-{
-}
-void QEMU_NORETURN tcg_s390_program_interrupt(CPUS390XState *env,
-                                              uint32_t code, uintptr_t ra)
-{
-    g_assert_not_reached();
-}
-void QEMU_NORETURN tcg_s390_data_exception(CPUS390XState *env, uint32_t dxc,
-                                           uintptr_t ra)
-{
-    g_assert_not_reached();
-}
-- 
2.32.0



  parent reply	other threads:[~2021-06-22 10:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 10:17 [RFC v5 00/13] s390x cleanup Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 01/13] target/s390x: meson: add target_user_arch Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 03/13] hw/s390x: only build tod-tcg from the CONFIG_TCG build Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 04/13] hw/s390x: tod: make explicit checks for accelerators when initializing Cho, Yu-Chen
2021-06-22 10:17 ` Cho, Yu-Chen [this message]
2021-06-22 10:17 ` [RFC v5 06/13] target/s390x: start moving TCG-only code to tcg/ Cho, Yu-Chen
2021-06-22 11:39   ` Cornelia Huck
2021-06-23 15:20     ` Al Cho
2021-06-22 10:17 ` [RFC v5 07/13] target/s390x: move sysemu-only code out to cpu-sysemu.c Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 08/13] target/s390x: split cpu-dump from helper.c Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 09/13] target/s390x: make helper.c sysemu-only Cho, Yu-Chen
2021-06-22 11:42   ` Cornelia Huck
2021-06-22 14:25     ` Al Cho
2021-06-22 10:17 ` [RFC v5 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 11/13] target/s390x: remove kvm-stub.c Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 12/13] target/s390x: move kvm files into kvm/ Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 13/13] target/s390x: split sysemu part of cpu models Cho, Yu-Chen
2021-06-22 10:31 ` [RFC v5 00/13] s390x cleanup Al Cho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210622101726.20860-6-acho@suse.com \
    --to=acho@suse.com \
    --cc=cfontana@suse.com \
    --cc=cfontana@suse.de \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).