qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Al Cho <ACho@suse.com>
To: Cornelia Huck <cohuck@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"qemu-s390x@nongnu.org" <qemu-s390x@nongnu.org>
Cc: Claudio Fontana <Claudio.Fontana@suse.com>
Subject: Re: [RFC v5 09/13] target/s390x: make helper.c sysemu-only
Date: Tue, 22 Jun 2021 14:25:07 +0000	[thread overview]
Message-ID: <VI1PR0402MB3744FB77876CACA6EADDE4BAA0099@VI1PR0402MB3744.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <87a6ninn1b.fsf@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]

Yes, it should be "sysemu", it's a typo.
________________________________
From: Cornelia Huck <cohuck@redhat.com>
Sent: Tuesday, June 22, 2021 7:42 PM
To: Al Cho <ACho@suse.com>; qemu-devel@nongnu.org <qemu-devel@nongnu.org>; qemu-s390x@nongnu.org <qemu-s390x@nongnu.org>
Cc: Claudio Fontana <Claudio.Fontana@suse.com>; Al Cho <ACho@suse.com>; Claudio Fontana <cfontana@suse.de>
Subject: Re: [RFC v5 09/13] target/s390x: make helper.c sysemu-only

On Tue, Jun 22 2021, "Cho, Yu-Chen" <acho@suse.com> wrote:

> Now that we have moved cpu-dump functionality out of helper.c,
> we can make the module sysemu-only.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Signed-off-by: Cho, Yu-Chen <acho@suse.com>
> Acked-by: Cornelia Huck <cohuck@redhat.com>
> ---
>  target/s390x/helper.c    | 6 +-----
>  target/s390x/meson.build | 2 +-
>  2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> index 41ccc83d11..b9d18325bc 100644
> --- a/target/s390x/helper.c
> +++ b/target/s390x/helper.c
> @@ -1,5 +1,5 @@
>  /*
> - *  S/390 helpers
> + *  S/390 helpers - systemu only

Typo -- you probably meant "sysemu"? (Although I'd probably spell it out
as "system emulation".)

>   *
>   *  Copyright (c) 2009 Ulrich Hecht
>   *  Copyright (c) 2011 Alexander Graf


[-- Attachment #2: Type: text/html, Size: 2495 bytes --]

  reply	other threads:[~2021-06-22 14:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 10:17 [RFC v5 00/13] s390x cleanup Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 01/13] target/s390x: meson: add target_user_arch Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 03/13] hw/s390x: only build tod-tcg from the CONFIG_TCG build Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 04/13] hw/s390x: tod: make explicit checks for accelerators when initializing Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 05/13] target/s390x: remove tcg-stub.c Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 06/13] target/s390x: start moving TCG-only code to tcg/ Cho, Yu-Chen
2021-06-22 11:39   ` Cornelia Huck
2021-06-23 15:20     ` Al Cho
2021-06-22 10:17 ` [RFC v5 07/13] target/s390x: move sysemu-only code out to cpu-sysemu.c Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 08/13] target/s390x: split cpu-dump from helper.c Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 09/13] target/s390x: make helper.c sysemu-only Cho, Yu-Chen
2021-06-22 11:42   ` Cornelia Huck
2021-06-22 14:25     ` Al Cho [this message]
2021-06-22 10:17 ` [RFC v5 10/13] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 11/13] target/s390x: remove kvm-stub.c Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 12/13] target/s390x: move kvm files into kvm/ Cho, Yu-Chen
2021-06-22 10:17 ` [RFC v5 13/13] target/s390x: split sysemu part of cpu models Cho, Yu-Chen
2021-06-22 10:31 ` [RFC v5 00/13] s390x cleanup Al Cho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR0402MB3744FB77876CACA6EADDE4BAA0099@VI1PR0402MB3744.eurprd04.prod.outlook.com \
    --to=acho@suse.com \
    --cc=Claudio.Fontana@suse.com \
    --cc=cohuck@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).