From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, "Bin Meng" <bin.meng@windriver.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Tom Yan" <tom.ty89@gmail.com>,
"Alexander Bulekov" <alxndr@bu.edu>,
"Niek Linnenbank" <nieklinnenbank@gmail.com>,
"Michal Suchánek" <msuchanek@suse.de>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Warner Losh" <imp@bsdimp.com>
Subject: [RFC PATCH 6/9] tests/acceptance: Use image_expand() in test_arm_orangepi_bionic_20_08
Date: Wed, 23 Jun 2021 20:00:18 +0200 [thread overview]
Message-ID: <20210623180021.898286-7-f4bug@amsat.org> (raw)
In-Reply-To: <20210623180021.898286-1-f4bug@amsat.org>
U-Boot expects the SD card size to be at least 2GiB, so
expand the SD card image to this size before using it.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
TODO: U-Boot reference?
---
tests/acceptance/boot_linux_console.py | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
index b10f7257503..c4c0f0b393d 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -820,11 +820,13 @@ def test_arm_orangepi_bionic_20_08(self):
:avocado: tags=arch:arm
:avocado: tags=machine:orangepi-pc
:avocado: tags=device:sd
+ :avocado: tags=u-boot
"""
- # This test download a 275 MiB compressed image and expand it
- # to 1036 MiB, but the underlying filesystem is 1552 MiB...
- # As we expand it to 2 GiB we are safe.
+ # This test download a 275 MiB compressed image and inflate it
+ # to 1036 MiB, but 1/ the underlying filesystem is 1552 MiB,
+ # 2/ U-Boot loads TFTP filenames from the last sector below
+ # 2 GiB, so we need to expand the image further more to 2 GiB.
image_url = ('https://archive.armbian.com/orangepipc/archive/'
'Armbian_20.08.1_Orangepipc_bionic_current_5.8.5.img.xz')
@@ -833,7 +835,7 @@ def test_arm_orangepi_bionic_20_08(self):
image_path_xz = self.fetch_asset(image_url, asset_hash=image_hash,
algorithm='sha256')
image_path = archive.extract(image_path_xz, self.workdir)
- image_pow2ceil_expand(image_path)
+ image_expand(image_path, 2 * 1024 * 1024 * 1024)
self.vm.set_console()
self.vm.add_args('-drive', 'file=' + image_path + ',if=sd,format=raw',
--
2.31.1
next prev parent reply other threads:[~2021-06-23 18:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 18:00 [RFC PATCH 0/9] hw/sd: Allow card size not power of 2 again Philippe Mathieu-Daudé
2021-06-23 18:00 ` [PATCH 1/9] hw/sd: When card is in wrong state, log which state it is Philippe Mathieu-Daudé
2021-08-05 19:37 ` Eric Blake
2021-06-23 18:00 ` [PATCH 2/9] hw/sd: Extract address_in_range() helper, log invalid accesses Philippe Mathieu-Daudé
2021-08-05 19:46 ` Eric Blake
2021-06-23 18:00 ` [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd' Philippe Mathieu-Daudé
2021-07-03 8:41 ` Philippe Mathieu-Daudé
2021-07-03 8:43 ` Philippe Mathieu-Daudé
2021-07-04 12:35 ` Niek Linnenbank
2021-07-05 8:55 ` Philippe Mathieu-Daudé
2021-07-11 21:05 ` Philippe Mathieu-Daudé
2021-07-05 15:25 ` Willian Rampazzo
2021-07-13 16:57 ` Cleber Rosa
2021-06-23 18:00 ` [PATCH 4/9] tests/acceptance: Extract image_expand() helper Philippe Mathieu-Daudé
2021-07-05 15:27 ` Willian Rampazzo
2021-07-13 17:02 ` Cleber Rosa
2021-06-23 18:00 ` [PATCH 5/9] tests/acceptance: Use image_expand() in test_arm_orangepi_uboot_netbsd9 Philippe Mathieu-Daudé
2021-07-05 15:28 ` Willian Rampazzo
2021-08-04 20:54 ` Philippe Mathieu-Daudé
2021-08-05 17:06 ` Niek Linnenbank
2021-06-23 18:00 ` Philippe Mathieu-Daudé [this message]
2021-07-05 15:30 ` [RFC PATCH 6/9] tests/acceptance: Use image_expand() in test_arm_orangepi_bionic_20_08 Willian Rampazzo
2021-08-05 17:11 ` Niek Linnenbank
2021-06-23 18:00 ` [RFC PATCH 7/9] tests/acceptance: Do not expand SD card image in test_arm_orangepi_sd Philippe Mathieu-Daudé
2021-06-23 18:00 ` [PATCH 8/9] tests/acceptance: Remove now unused pow2ceil() Philippe Mathieu-Daudé
2021-07-05 15:32 ` Willian Rampazzo
2021-06-23 18:00 ` [RFC PATCH 9/9] hw/sd: Allow card size not power of 2 again Philippe Mathieu-Daudé
2021-06-24 10:17 ` Daniel P. Berrangé
2021-06-24 10:24 ` Tom Yan
2021-06-24 10:56 ` Peter Maydell
2021-06-24 16:08 ` Warner Losh
2021-06-24 2:50 ` [RFC PATCH 0/9] " Alexander Bulekov
2021-06-24 8:12 ` Philippe Mathieu-Daudé
2021-06-26 4:04 ` Alexander Bulekov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623180021.898286-7-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=alxndr@bu.edu \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=imp@bsdimp.com \
--cc=msuchanek@suse.de \
--cc=nieklinnenbank@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).