From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Alexander Bulekov <alxndr@bu.edu>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, "Bin Meng" <bin.meng@windriver.com>,
qemu-devel@nongnu.org, "Tom Yan" <tom.ty89@gmail.com>,
"Niek Linnenbank" <nieklinnenbank@gmail.com>,
"Michal Suchánek" <msuchanek@suse.de>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Warner Losh" <imp@bsdimp.com>
Subject: Re: [RFC PATCH 0/9] hw/sd: Allow card size not power of 2 again
Date: Thu, 24 Jun 2021 10:12:37 +0200 [thread overview]
Message-ID: <235bae9f-4c24-0a78-2c53-ed08daa282b1@amsat.org> (raw)
In-Reply-To: <20210624025054.57gf3w5fawybm3me@mozz.bu.edu>
On 6/24/21 4:50 AM, Alexander Bulekov wrote:
> On 210623 2000, Philippe Mathieu-Daudé wrote:
>> Hi Ubi-Wan Kenubi and Tom,
>>
>> In commit a9bcedd (SD card size has to be power of 2) we decided
>> to restrict SD card size to avoid security problems (CVE-2020-13253)
>> but this became not practical to some users.
>>
>> This RFC series tries to remove the limitation, keeping our
>> functional tests working. It is unfinished work because I had to
>> attend other topics, but sending it early as RFC to get feedback.
>> I'll keep working when I get more time, except if one if you can
>> help me.
>>
>> Alexander, could you generate a qtest reproducer with the fuzzer
>> corpus? See: https://bugs.launchpad.net/qemu/+bug/1878054
>
> I think that bug was already fixed - the reproducer no logner causes a
> timeout on 6.0. Did I misunderstand something?
That bug was fixed but now I'm changing the code and would like to feel
sure I'm not re-introducing the problem, so having the reproducer in the
tree would help.
> I applied this series and ran the OSS-Fuzz corpus for the sdhci-v3
> config. The only problem it found is this assert() (that exists without the
> patch anyways):
> https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29225
Sigh.
> Let me know if this is something you think I should report on gitlab..
Yes please :(
> I'll leave the fuzzer running for another 24h or so, but otherwise I'm
> happy to leave a Tested-by, once there is a V1 series
> -Alex
Thanks!
Phil.
next prev parent reply other threads:[~2021-06-24 8:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 18:00 [RFC PATCH 0/9] hw/sd: Allow card size not power of 2 again Philippe Mathieu-Daudé
2021-06-23 18:00 ` [PATCH 1/9] hw/sd: When card is in wrong state, log which state it is Philippe Mathieu-Daudé
2021-08-05 19:37 ` Eric Blake
2021-06-23 18:00 ` [PATCH 2/9] hw/sd: Extract address_in_range() helper, log invalid accesses Philippe Mathieu-Daudé
2021-08-05 19:46 ` Eric Blake
2021-06-23 18:00 ` [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd' Philippe Mathieu-Daudé
2021-07-03 8:41 ` Philippe Mathieu-Daudé
2021-07-03 8:43 ` Philippe Mathieu-Daudé
2021-07-04 12:35 ` Niek Linnenbank
2021-07-05 8:55 ` Philippe Mathieu-Daudé
2021-07-11 21:05 ` Philippe Mathieu-Daudé
2021-07-05 15:25 ` Willian Rampazzo
2021-07-13 16:57 ` Cleber Rosa
2021-06-23 18:00 ` [PATCH 4/9] tests/acceptance: Extract image_expand() helper Philippe Mathieu-Daudé
2021-07-05 15:27 ` Willian Rampazzo
2021-07-13 17:02 ` Cleber Rosa
2021-06-23 18:00 ` [PATCH 5/9] tests/acceptance: Use image_expand() in test_arm_orangepi_uboot_netbsd9 Philippe Mathieu-Daudé
2021-07-05 15:28 ` Willian Rampazzo
2021-08-04 20:54 ` Philippe Mathieu-Daudé
2021-08-05 17:06 ` Niek Linnenbank
2021-06-23 18:00 ` [RFC PATCH 6/9] tests/acceptance: Use image_expand() in test_arm_orangepi_bionic_20_08 Philippe Mathieu-Daudé
2021-07-05 15:30 ` Willian Rampazzo
2021-08-05 17:11 ` Niek Linnenbank
2021-06-23 18:00 ` [RFC PATCH 7/9] tests/acceptance: Do not expand SD card image in test_arm_orangepi_sd Philippe Mathieu-Daudé
2021-06-23 18:00 ` [PATCH 8/9] tests/acceptance: Remove now unused pow2ceil() Philippe Mathieu-Daudé
2021-07-05 15:32 ` Willian Rampazzo
2021-06-23 18:00 ` [RFC PATCH 9/9] hw/sd: Allow card size not power of 2 again Philippe Mathieu-Daudé
2021-06-24 10:17 ` Daniel P. Berrangé
2021-06-24 10:24 ` Tom Yan
2021-06-24 10:56 ` Peter Maydell
2021-06-24 16:08 ` Warner Losh
2021-06-24 2:50 ` [RFC PATCH 0/9] " Alexander Bulekov
2021-06-24 8:12 ` Philippe Mathieu-Daudé [this message]
2021-06-26 4:04 ` Alexander Bulekov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=235bae9f-4c24-0a78-2c53-ed08daa282b1@amsat.org \
--to=f4bug@amsat.org \
--cc=alxndr@bu.edu \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=imp@bsdimp.com \
--cc=msuchanek@suse.de \
--cc=nieklinnenbank@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).