Re: [PATCH 04/18] vhost-vdpa: remove the unnecessary check in vhost_vdpa_add()

From: Eli Cohen <elic@nvidia.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: lulu@redhat.com, mst@redhat.com, Jason Wang <jasowang@redhat.com>,
	qemu-devel@nongnu.org, eperezma@redhat.com,
	lingshan.zhu@intel.com
Subject: Re: [PATCH 04/18] vhost-vdpa: remove the unnecessary check in vhost_vdpa_add()
Date: Thu, 24 Jun 2021 09:38:47 +0300	[thread overview]
Message-ID: <20210624063847.GA39216@mtl-vdi-166.wap.labs.mlnx> (raw)
In-Reply-To: <20210623145359.bi4vrsg63la3l3id@steredhat>

On Mon, Jun 21, 2021 at 12:16:36PM +0800, Jason Wang wrote:
> The VhostVDPAState is just allocated by qemu_new_net_client() via
> g_malloc0() in net_vhost_vdpa_init(). So s->vhost_net is NULL for
> sure, let's remove this unnecessary check in vhost_vdpa_add().
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>

Reviewed-by: Eli Cohen <elic@nvidia.com>

> ---
> net/vhost-vdpa.c | 4 ----
> 1 file changed, 4 deletions(-)
> 
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index 18b45ad777..728e63ff54 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -112,10 +112,6 @@ static int vhost_vdpa_add(NetClientState *ncs, void *be)
>         error_report("failed to init vhost_net for queue");
>         goto err;
>     }
> -    if (s->vhost_net) {
> -        vhost_net_cleanup(s->vhost_net);
> -        g_free(s->vhost_net);
> -    }
>     s->vhost_net = net;
>     ret = vhost_vdpa_net_check_device_id(net);
>     if (ret) {
> -- 2.25.1
> 2.25.1
> 
>