From: Jason Wang <jasowang@redhat.com>
To: Eli Cohen <elic@nvidia.com>, Stefano Garzarella <sgarzare@redhat.com>
Cc: eperezma@redhat.com, lingshan.zhu@intel.com,
qemu-devel@nongnu.org, lulu@redhat.com, mst@redhat.com
Subject: Re: [PATCH 06/18] vhost-vdpa: fix leaking of vhost_net in vhost_vdpa_add()
Date: Thu, 24 Jun 2021 15:41:01 +0800 [thread overview]
Message-ID: <79979847-ef14-ade7-b8f9-9b2ad6971757@redhat.com> (raw)
In-Reply-To: <20210624071435.GA41596@mtl-vdi-166.wap.labs.mlnx>
在 2021/6/24 下午3:14, Eli Cohen 写道:
> On Wed, Jun 23, 2021 at 05:00:16PM +0200, Stefano Garzarella wrote:
>> On Mon, Jun 21, 2021 at 12:16:38PM +0800, Jason Wang wrote:
>>> Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client")
>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>> ---
>>> net/vhost-vdpa.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
>>> index f5689a7c32..21f09c546f 100644
>>> --- a/net/vhost-vdpa.c
>>> +++ b/net/vhost-vdpa.c
>>> @@ -111,6 +111,7 @@ static int vhost_vdpa_add(NetClientState *ncs, void *be)
>>> err:
>>> if (net) {
>>> vhost_net_cleanup(net);
>>> + g_free(net);
> Shouldn't this call be part of the implementation of
> vhost_net_cleanup()?
Not sure, at least there's one user that doesn't do the free (see
vhost_user_stop()).
Thanks
>
>>> }
>>> return -1;
>>> }
>>> --
>>> 2.25.1
>>>
>>>
>> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>>
next prev parent reply other threads:[~2021-06-24 7:42 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 4:16 [PATCH 00/18] vhost-vDPA multiqueue Jason Wang
2021-06-21 4:16 ` [PATCH 01/18] vhost_net: remove the meaningless assignment in vhost_net_start_one() Jason Wang
2021-06-21 11:45 ` Eli Cohen
2021-06-24 7:42 ` Jason Wang
2021-06-21 4:16 ` [PATCH 02/18] vhost: use unsigned int for nvqs Jason Wang
2021-06-21 11:46 ` Eli Cohen
2021-06-21 4:16 ` [PATCH 03/18] vhost_net: do not assume nvqs is always 2 Jason Wang
2021-06-23 14:49 ` Stefano Garzarella
2021-06-24 6:22 ` Eli Cohen
2021-06-24 7:42 ` Jason Wang
2021-06-21 4:16 ` [PATCH 04/18] vhost-vdpa: remove the unnecessary check in vhost_vdpa_add() Jason Wang
2021-06-23 14:53 ` Stefano Garzarella
2021-06-24 6:38 ` Eli Cohen
2021-06-24 7:46 ` Jason Wang
2021-06-21 4:16 ` [PATCH 05/18] vhost-vdpa: don't cleanup twice " Jason Wang
2021-06-23 14:56 ` Stefano Garzarella
2021-06-21 4:16 ` [PATCH 06/18] vhost-vdpa: fix leaking of vhost_net " Jason Wang
2021-06-23 15:00 ` Stefano Garzarella
2021-06-24 7:06 ` Eli Cohen
2021-06-24 7:10 ` Jason Wang
2021-06-24 7:32 ` Eli Cohen
2021-06-24 7:14 ` Eli Cohen
2021-06-24 7:41 ` Jason Wang [this message]
2021-06-21 4:16 ` [PATCH 07/18] vhost-vdpa: tweak the error label " Jason Wang
2021-06-23 15:03 ` Stefano Garzarella
2021-07-06 8:03 ` Jason Wang
2021-07-06 8:10 ` Jason Wang
2021-07-06 8:27 ` Stefano Garzarella
2021-07-06 8:28 ` Jason Wang
2021-06-21 4:16 ` [PATCH 08/18] vhost-vdpa: fix the wrong assertion in vhost_vdpa_init() Jason Wang
2021-06-23 15:04 ` Stefano Garzarella
2021-06-21 4:16 ` [PATCH 09/18] vhost-vdpa: remove the unncessary queue_index assignment Jason Wang
2021-06-23 15:05 ` Stefano Garzarella
2021-06-21 4:16 ` [PATCH 10/18] vhost-vdpa: open device fd in net_init_vhost_vdpa() Jason Wang
2021-06-23 15:07 ` Stefano Garzarella
2021-06-21 4:16 ` [PATCH 11/18] vhost-vdpa: classify one time request Jason Wang
2021-06-21 4:16 ` [PATCH 12/18] vhost-vdpa: prepare for the multiqueue support Jason Wang
2021-06-21 4:16 ` [PATCH 13/18] vhost-vdpa: let net_vhost_vdpa_init() returns NetClientState * Jason Wang
2021-06-21 4:16 ` [PATCH 14/18] net: introduce control client Jason Wang
2021-06-21 4:16 ` [PATCH 15/18] vhost-net: control virtqueue support Jason Wang
2021-06-24 7:42 ` Eli Cohen
2021-06-24 7:44 ` Jason Wang
2021-06-30 17:33 ` Eugenio Perez Martin
2021-07-01 3:03 ` Jason Wang
2021-06-21 4:16 ` [PATCH 16/18] virito-net: use "qps" instead of "queues" when possible Jason Wang
2021-06-21 4:16 ` [PATCH 17/18] virtio-net: vhost control virtqueue support Jason Wang
2021-06-21 4:16 ` [PATCH 18/18] vhost-vdpa: multiqueue support Jason Wang
2021-07-01 6:51 ` Eugenio Perez Martin
2021-07-01 8:15 ` Jason Wang
2021-07-06 7:46 ` Jason Wang
2021-06-21 4:33 ` [PATCH 00/18] vhost-vDPA multiqueue no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79979847-ef14-ade7-b8f9-9b2ad6971757@redhat.com \
--to=jasowang@redhat.com \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).