* [PATCH] target/i386: Added consistency checks for event injection
@ 2021-07-25 9:08 Lara Lazier
2021-07-28 9:26 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Lara Lazier @ 2021-07-25 9:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Lara Lazier
VMRUN exits with SVM_EXIT_ERR if either:
* The event injected has a reserved type.
* When the event injected is of type 3 (exception), and the vector that
has been specified does not correspond to an exception.
This does not fix the entire exc_inj test in kvm-unit-tests.
Signed-off-by: Lara Lazier <laramglazier@gmail.com>
---
target/i386/tcg/sysemu/svm_helper.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target/i386/tcg/sysemu/svm_helper.c b/target/i386/tcg/sysemu/svm_helper.c
index a61aa23017..70d5c2e35d 100644
--- a/target/i386/tcg/sysemu/svm_helper.c
+++ b/target/i386/tcg/sysemu/svm_helper.c
@@ -395,6 +395,9 @@ void helper_vmrun(CPUX86State *env, int aflag, int next_eip_addend)
cpu_loop_exit(cs);
break;
case SVM_EVTINJ_TYPE_EXEPT:
+ if (vector == EXCP02_NMI || vector >= 31) {
+ cpu_vmexit(env, SVM_EXIT_ERR, 0, GETPC());
+ }
cs->exception_index = vector;
env->error_code = event_inj_err;
env->exception_is_int = 0;
@@ -410,6 +413,9 @@ void helper_vmrun(CPUX86State *env, int aflag, int next_eip_addend)
qemu_log_mask(CPU_LOG_TB_IN_ASM, "SOFT");
cpu_loop_exit(cs);
break;
+ default:
+ cpu_vmexit(env, SVM_EXIT_ERR, 0, GETPC());
+ break;
}
qemu_log_mask(CPU_LOG_TB_IN_ASM, " %#x %#x\n", cs->exception_index,
env->error_code);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/i386: Added consistency checks for event injection
2021-07-25 9:08 [PATCH] target/i386: Added consistency checks for event injection Lara Lazier
@ 2021-07-28 9:26 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2021-07-28 9:26 UTC (permalink / raw)
To: Lara Lazier, qemu-devel
On 25/07/21 11:08, Lara Lazier wrote:
> VMRUN exits with SVM_EXIT_ERR if either:
> * The event injected has a reserved type.
> * When the event injected is of type 3 (exception), and the vector that
> has been specified does not correspond to an exception.
>
> This does not fix the entire exc_inj test in kvm-unit-tests.
>
> Signed-off-by: Lara Lazier <laramglazier@gmail.com>
> ---
> target/i386/tcg/sysemu/svm_helper.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/target/i386/tcg/sysemu/svm_helper.c b/target/i386/tcg/sysemu/svm_helper.c
> index a61aa23017..70d5c2e35d 100644
> --- a/target/i386/tcg/sysemu/svm_helper.c
> +++ b/target/i386/tcg/sysemu/svm_helper.c
> @@ -395,6 +395,9 @@ void helper_vmrun(CPUX86State *env, int aflag, int next_eip_addend)
> cpu_loop_exit(cs);
> break;
> case SVM_EVTINJ_TYPE_EXEPT:
> + if (vector == EXCP02_NMI || vector >= 31) {
> + cpu_vmexit(env, SVM_EXIT_ERR, 0, GETPC());
> + }
> cs->exception_index = vector;
> env->error_code = event_inj_err;
> env->exception_is_int = 0;
> @@ -410,6 +413,9 @@ void helper_vmrun(CPUX86State *env, int aflag, int next_eip_addend)
> qemu_log_mask(CPU_LOG_TB_IN_ASM, "SOFT");
> cpu_loop_exit(cs);
> break;
> + default:
> + cpu_vmexit(env, SVM_EXIT_ERR, 0, GETPC());
> + break;
> }
> qemu_log_mask(CPU_LOG_TB_IN_ASM, " %#x %#x\n", cs->exception_index,
> env->error_code);
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-28 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-25 9:08 [PATCH] target/i386: Added consistency checks for event injection Lara Lazier
2021-07-28 9:26 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).