From: Igor Mammedov <imammedo@redhat.com>
To: Ani Sinha <ani@anisinha.ca>
Cc: jusual@redhat.com, philmd@redhat.com, qemu-devel@nongnu.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] hw/i386/acpi-build: adjust q35 IO addr range for acpi pci hotplug
Date: Wed, 8 Sep 2021 08:42:56 +0200 [thread overview]
Message-ID: <20210908084256.6077f7a3@redhat.com> (raw)
In-Reply-To: <20210908041139.2219253-1-ani@anisinha.ca>
On Wed, 8 Sep 2021 09:41:39 +0530
Ani Sinha <ani@anisinha.ca> wrote:
> Change caf108bc58790 ("hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35")
> selects an IO address range for acpi based PCI hotplug for q35 arbitrarily. It
> starts at address 0x0cc4 and ends at 0x0cdb. It was assumed that this address
> range was free and available. However, upon more testing, it seems this address
> range to be not available for some latest versions of windows.
The range is something assigned by QEMU, and guest has no say where it should be.
but perhaps we failed to describe it properly or something similar, so one gets
'no resource' error.
We need a find out a reason why Windows doesn't like it. You might get more
detailed error running Windows debug build with ACPI debugger attached.
> Hence, this
> change modifies the IO address range so that windows can allocate the address
> range without any conflict. The new address range would start at 0x0dd4 and end
> at address 0x0deb.
>
> This change has been tested using a Windows Server 2019 guest VM.
>
> Fixes: caf108bc58790 ("hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/561
>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
> ---
> include/hw/acpi/ich9.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
> index a329ce43ab..b68c5a2174 100644
> --- a/include/hw/acpi/ich9.h
> +++ b/include/hw/acpi/ich9.h
> @@ -29,7 +29,7 @@
> #include "hw/acpi/acpi_dev_interface.h"
> #include "hw/acpi/tco.h"
>
> -#define ACPI_PCIHP_ADDR_ICH9 0x0cc4
> +#define ACPI_PCIHP_ADDR_ICH9 0x0dd4
that's ABI change, it must be versioned
>
> typedef struct ICH9LPCPMRegs {
> /*
next prev parent reply other threads:[~2021-09-08 6:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 4:11 [PATCH] hw/i386/acpi-build: adjust q35 IO addr range for acpi pci hotplug Ani Sinha
2021-09-08 4:43 ` Ani Sinha
2021-09-08 6:42 ` Igor Mammedov [this message]
2021-09-08 7:21 ` Ani Sinha
2021-09-08 8:43 ` Ani Sinha
2021-09-08 8:51 ` Igor Mammedov
2021-09-08 8:43 ` Igor Mammedov
2021-09-08 9:25 ` Ani Sinha
2021-09-08 10:21 ` Philippe Mathieu-Daudé
2021-09-08 12:11 ` Igor Mammedov
2021-09-08 16:24 ` Ani Sinha
2021-09-13 14:23 ` Ani Sinha
2021-09-13 19:21 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210908084256.6077f7a3@redhat.com \
--to=imammedo@redhat.com \
--cc=ani@anisinha.ca \
--cc=jusual@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).