From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: jusual@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/i386/acpi-build: adjust q35 IO addr range for acpi pci hotplug
Date: Wed, 8 Sep 2021 12:21:26 +0200 [thread overview]
Message-ID: <55495984-43ba-0b93-db74-e7f8602be178@redhat.com> (raw)
In-Reply-To: <20210908104351.72d0bb19@redhat.com>
On 9/8/21 10:43 AM, Igor Mammedov wrote:
> On Wed, 8 Sep 2021 12:51:04 +0530 (IST)
> Ani Sinha <ani@anisinha.ca> wrote:
>
>> On Wed, 8 Sep 2021, Igor Mammedov wrote:
>>
>>> On Wed, 8 Sep 2021 09:41:39 +0530
>>> Ani Sinha <ani@anisinha.ca> wrote:
>>>
>>>> Change caf108bc58790 ("hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35")
>>>> selects an IO address range for acpi based PCI hotplug for q35 arbitrarily. It
>>>> starts at address 0x0cc4 and ends at 0x0cdb. It was assumed that this address
>>>> range was free and available. However, upon more testing, it seems this address
>>>> range to be not available for some latest versions of windows.
>>>
>>> The range is something assigned by QEMU, and guest has no say where it should be.
>>> but perhaps we failed to describe it properly or something similar, so one gets
>>> 'no resource' error.
>>
>> OK dug deeper. The existing range of IO address conflicts with the CPU
>> hotplug range.
>>
>> CPU hotplug range (ICH9_CPU_HOTPLUG_IO_BASE) is 0x0cd8 to 0x0ce3
>>
>> This intersects with range 0x0cc4 to 0x0cdb for ACPI_PCIHP_ADDR_ICH9 .
>
> Looking at 'info mtree' it's indeed wrong:
>
> 0000000000000cc4-0000000000000cdb (prio 0, i/o): acpi-pci-hotplug
> 0000000000000cd8-0000000000000cf7 (prio 0, i/o): acpi-cpu-hotplug
>
> which of them eventually handles IO request in intersection range?
(qemu) info mtree -f
FlatView #0
AS "I/O", root: io
Root memory region: io
0000000000000cc4-0000000000000cd7 (prio 0, i/o): acpi-pci-hotplug
0000000000000cd8-0000000000000cf7 (prio 0, i/o): acpi-cpu-hotplug
>
> Please, add to commit message your findings, so it would point out
> where problem comes from and what it breaks(doesn't work as expect).
>
> Given it's broken to begin with (and possibly regression if it broke cpu hotplug),
> I'm inclined to fix it without adding compat stuff.
> Michael, what do you think?
next prev parent reply other threads:[~2021-09-08 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 4:11 [PATCH] hw/i386/acpi-build: adjust q35 IO addr range for acpi pci hotplug Ani Sinha
2021-09-08 4:43 ` Ani Sinha
2021-09-08 6:42 ` Igor Mammedov
2021-09-08 7:21 ` Ani Sinha
2021-09-08 8:43 ` Ani Sinha
2021-09-08 8:51 ` Igor Mammedov
2021-09-08 8:43 ` Igor Mammedov
2021-09-08 9:25 ` Ani Sinha
2021-09-08 10:21 ` Philippe Mathieu-Daudé [this message]
2021-09-08 12:11 ` Igor Mammedov
2021-09-08 16:24 ` Ani Sinha
2021-09-13 14:23 ` Ani Sinha
2021-09-13 19:21 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55495984-43ba-0b93-db74-e7f8602be178@redhat.com \
--to=philmd@redhat.com \
--cc=ani@anisinha.ca \
--cc=imammedo@redhat.com \
--cc=jusual@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).