From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, drjones@redhat.com,
shannon.zhaosl@gmail.com, mst@redhat.com,
Eric Auger <eric.auger@redhat.com>,
qemu-arm@nongnu.org, ani@anisinha.ca
Subject: [PATCH v4 30/35] acpi: arm/virt: build_spcr: fix invalid cast
Date: Fri, 24 Sep 2021 08:27:57 -0400 [thread overview]
Message-ID: <20210924122802.1455362-31-imammedo@redhat.com> (raw)
In-Reply-To: <20210924122802.1455362-1-imammedo@redhat.com>
implicit cast to structure uint8_t member didn't raise error when
assigning value from incorrect enum, but when using build_append_gas()
(next patch) it will error out with (clang):
implicit conversion from enumeration type 'AmlRegionSpace'
to different enumeration type 'AmlAddressSpace'
fix cast error by using correct AML_AS_SYSTEM_MEMORY enum
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
---
CC: drjones@redhat.com
CC: peter.maydell@linaro.org
CC: shannon.zhaosl@gmail.com
CC: qemu-arm@nongnu.org
---
hw/arm/virt-acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 8c382915a9..7b8706b305 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -465,7 +465,7 @@ build_spcr(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
spcr->interface_type = 0x3; /* ARM PL011 UART */
- spcr->base_address.space_id = AML_SYSTEM_MEMORY;
+ spcr->base_address.space_id = AML_AS_SYSTEM_MEMORY;
spcr->base_address.bit_width = 8;
spcr->base_address.bit_offset = 0;
spcr->base_address.access_width = 1;
--
2.27.0
next prev parent reply other threads:[~2021-09-24 13:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 12:27 [PATCH v4 00/35] acpi: refactor error prone build_header() and packed structures usage in ACPI tables Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 01/35] acpi: add helper routines to initialize " Igor Mammedov
2021-09-24 20:52 ` Stefan Berger
2021-09-26 9:16 ` wangyanan (Y)
2021-09-24 12:27 ` [PATCH v4 02/35] acpi: build_rsdt: use acpi_table_begin()/acpi_table_end() instead of build_header() Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 03/35] acpi: build_xsdt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 04/35] acpi: build_slit: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 05/35] acpi: build_fadt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 06/35] acpi: build_tpm2: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 07/35] acpi: acpi_build_hest: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 08/35] acpi: build_mcfg: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 09/35] acpi: build_hmat: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 10/35] acpi: nvdimm_build_nfit: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 11/35] acpi: nvdimm_build_ssdt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 12/35] acpi: vmgenid_build_acpi: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 13/35] acpi: x86: build_dsdt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 14/35] acpi: build_hpet: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 15/35] acpi: build_tpm_tcpa: " Igor Mammedov
2021-09-24 20:46 ` Stefan Berger
2021-09-24 12:27 ` [PATCH v4 16/35] acpi: arm/x86: build_srat: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 17/35] acpi: use build_append_int_noprefix() API to compose SRAT table Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 18/35] acpi: build_dmar_q35: use acpi_table_begin()/acpi_table_end() instead of build_header() Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 19/35] acpi: build_waet: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 20/35] acpi: build_amd_iommu: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 21/35] acpi: madt: arm/x86: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 22/35] acpi: x86: remove dead code Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 23/35] acpi: x86: set enabled when composing _MAT entries Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 24/35] acpi: x86: madt: use build_append_int_noprefix() API to compose MADT table Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 25/35] acpi: arm/virt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 26/35] acpi: build_dsdt_microvm: use acpi_table_begin()/acpi_table_end() instead of build_header() Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 27/35] acpi: arm: virt: build_dsdt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 28/35] acpi: arm: virt: build_iort: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 29/35] acpi: arm/virt: convert build_iort() to endian agnostic build_append_FOO() API Igor Mammedov
2021-09-27 9:56 ` Eric Auger
2021-09-24 12:27 ` Igor Mammedov [this message]
2021-09-24 12:27 ` [PATCH v4 31/35] acpi: arm/virt: build_spcr: use acpi_table_begin()/acpi_table_end() instead of build_header() Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 32/35] acpi: arm/virt: build_gtdt: " Igor Mammedov
2021-09-24 12:28 ` [PATCH v4 33/35] acpi: build_facs: use build_append_int_noprefix() API to compose table Igor Mammedov
2021-09-24 12:28 ` [PATCH v4 34/35] acpi: remove no longer used build_header() Igor Mammedov
2021-09-24 12:28 ` [PATCH v4 35/35] acpi: AcpiGenericAddress no longer used to map/access fields of MMIO, drop packed attribute Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924122802.1455362-31-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=ani@anisinha.ca \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).