From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: drjones@redhat.com, Dongjiu Geng <gengdongjiu1@gmail.com>,
mst@redhat.com, Eric Auger <eric.auger@redhat.com>,
qemu-arm@nongnu.org, eauger@redhat.com, ani@anisinha.ca
Subject: [PATCH v4 07/35] acpi: acpi_build_hest: use acpi_table_begin()/acpi_table_end() instead of build_header()
Date: Fri, 24 Sep 2021 08:27:34 -0400 [thread overview]
Message-ID: <20210924122802.1455362-8-imammedo@redhat.com> (raw)
In-Reply-To: <20210924122802.1455362-1-imammedo@redhat.com>
it replaces error-prone pointer arithmetic for build_header() API,
with 2 calls to start and finish table creation,
which hides offsets magic from API user.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Dongjiu Geng <gengdongjiu1@gmail.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
---
v3:
* s/acpi_init_table|acpi_table_composed/acpi_table_begin|acpi_table_end/
CC: qemu-arm@nongnu.org
CC: drjones@redhat.com
CC: gengdongjiu1@gmail.com
CC: eauger@redhat.com
---
hw/acpi/ghes.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index a749b84d62..45d9a809cc 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -362,18 +362,16 @@ static void build_ghes_v2(GArray *table_data, int source_id, BIOSLinker *linker)
void acpi_build_hest(GArray *table_data, BIOSLinker *linker,
const char *oem_id, const char *oem_table_id)
{
- uint64_t hest_start = table_data->len;
+ AcpiTable table = { .sig = "HEST", .rev = 1,
+ .oem_id = oem_id, .oem_table_id = oem_table_id };
- /* Hardware Error Source Table header*/
- acpi_data_push(table_data, sizeof(AcpiTableHeader));
+ acpi_table_begin(&table, table_data);
/* Error Source Count */
build_append_int_noprefix(table_data, ACPI_GHES_ERROR_SOURCE_COUNT, 4);
-
build_ghes_v2(table_data, ACPI_HEST_SRC_ID_SEA, linker);
- build_header(linker, table_data, (void *)(table_data->data + hest_start),
- "HEST", table_data->len - hest_start, 1, oem_id, oem_table_id);
+ acpi_table_end(linker, &table);
}
void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s,
--
2.27.0
next prev parent reply other threads:[~2021-09-24 12:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 12:27 [PATCH v4 00/35] acpi: refactor error prone build_header() and packed structures usage in ACPI tables Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 01/35] acpi: add helper routines to initialize " Igor Mammedov
2021-09-24 20:52 ` Stefan Berger
2021-09-26 9:16 ` wangyanan (Y)
2021-09-24 12:27 ` [PATCH v4 02/35] acpi: build_rsdt: use acpi_table_begin()/acpi_table_end() instead of build_header() Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 03/35] acpi: build_xsdt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 04/35] acpi: build_slit: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 05/35] acpi: build_fadt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 06/35] acpi: build_tpm2: " Igor Mammedov
2021-09-24 12:27 ` Igor Mammedov [this message]
2021-09-24 12:27 ` [PATCH v4 08/35] acpi: build_mcfg: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 09/35] acpi: build_hmat: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 10/35] acpi: nvdimm_build_nfit: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 11/35] acpi: nvdimm_build_ssdt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 12/35] acpi: vmgenid_build_acpi: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 13/35] acpi: x86: build_dsdt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 14/35] acpi: build_hpet: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 15/35] acpi: build_tpm_tcpa: " Igor Mammedov
2021-09-24 20:46 ` Stefan Berger
2021-09-24 12:27 ` [PATCH v4 16/35] acpi: arm/x86: build_srat: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 17/35] acpi: use build_append_int_noprefix() API to compose SRAT table Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 18/35] acpi: build_dmar_q35: use acpi_table_begin()/acpi_table_end() instead of build_header() Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 19/35] acpi: build_waet: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 20/35] acpi: build_amd_iommu: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 21/35] acpi: madt: arm/x86: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 22/35] acpi: x86: remove dead code Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 23/35] acpi: x86: set enabled when composing _MAT entries Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 24/35] acpi: x86: madt: use build_append_int_noprefix() API to compose MADT table Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 25/35] acpi: arm/virt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 26/35] acpi: build_dsdt_microvm: use acpi_table_begin()/acpi_table_end() instead of build_header() Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 27/35] acpi: arm: virt: build_dsdt: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 28/35] acpi: arm: virt: build_iort: " Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 29/35] acpi: arm/virt: convert build_iort() to endian agnostic build_append_FOO() API Igor Mammedov
2021-09-27 9:56 ` Eric Auger
2021-09-24 12:27 ` [PATCH v4 30/35] acpi: arm/virt: build_spcr: fix invalid cast Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 31/35] acpi: arm/virt: build_spcr: use acpi_table_begin()/acpi_table_end() instead of build_header() Igor Mammedov
2021-09-24 12:27 ` [PATCH v4 32/35] acpi: arm/virt: build_gtdt: " Igor Mammedov
2021-09-24 12:28 ` [PATCH v4 33/35] acpi: build_facs: use build_append_int_noprefix() API to compose table Igor Mammedov
2021-09-24 12:28 ` [PATCH v4 34/35] acpi: remove no longer used build_header() Igor Mammedov
2021-09-24 12:28 ` [PATCH v4 35/35] acpi: AcpiGenericAddress no longer used to map/access fields of MMIO, drop packed attribute Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924122802.1455362-8-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=ani@anisinha.ca \
--cc=drjones@redhat.com \
--cc=eauger@redhat.com \
--cc=eric.auger@redhat.com \
--cc=gengdongjiu1@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).