qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Resolves: https://gitlab.com/qemu-project/qemu/-/issues/542
@ 2022-03-12  8:26 zzl
  2022-03-14  7:57 ` Thomas Huth
  0 siblings, 1 reply; 2+ messages in thread
From: zzl @ 2022-03-12  8:26 UTC (permalink / raw)
  To: qemu-devel; +Cc: zzl

---
 hw/audio/intel-hda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
index 5f8a878f20..ff32936cfd 100644
--- a/hw/audio/intel-hda.c
+++ b/hw/audio/intel-hda.c
@@ -328,7 +328,7 @@ static void intel_hda_corb_run(IntelHDAState *d)
             dprint(d, 2, "%s: corb ring empty\n", __func__);
             return;
         }
-        if (d->rirb_count == d->rirb_cnt) {
+        if (d->rirb_count >= d->rirb_cnt) {
             dprint(d, 2, "%s: rirb count reached\n", __func__);
             return;
         }
-- 
2.32.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Resolves: https://gitlab.com/qemu-project/qemu/-/issues/542
  2022-03-12  8:26 [PATCH] Resolves: https://gitlab.com/qemu-project/qemu/-/issues/542 zzl
@ 2022-03-14  7:57 ` Thomas Huth
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2022-03-14  7:57 UTC (permalink / raw)
  To: zzl, qemu-devel; +Cc: Gerd Hoffmann, Philippe Mathieu-Daudé

On 12/03/2022 09.26, zzl wrote:
> ---
>   hw/audio/intel-hda.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
> index 5f8a878f20..ff32936cfd 100644
> --- a/hw/audio/intel-hda.c
> +++ b/hw/audio/intel-hda.c
> @@ -328,7 +328,7 @@ static void intel_hda_corb_run(IntelHDAState *d)
>               dprint(d, 2, "%s: corb ring empty\n", __func__);
>               return;
>           }
> -        if (d->rirb_count == d->rirb_cnt) {
> +        if (d->rirb_count >= d->rirb_cnt) {
>               dprint(d, 2, "%s: rirb count reached\n", __func__);
>               return;
>           }

  Hi!

Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html 
for information how to correclty submit a patch. Especially you need to 
supply a "Signed-off-by" line, too, and please use a proper subject for the 
mail and place the "Resolves:" line into the patch description instead.

Apart from that, the bug ticket already links a patch series with a proposed 
fix ... could you elaborate why this needs a different approach?

  Thomas



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-14  7:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-12  8:26 [PATCH] Resolves: https://gitlab.com/qemu-project/qemu/-/issues/542 zzl
2022-03-14  7:57 ` Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).