From: Salil Mehta via <qemu-devel@nongnu.org> To: <qemu-devel@nongnu.org>, <qemu-arm@nongnu.org> Cc: <salil.mehta@huawei.com>, <maz@kernel.org>, <jean-philippe@linaro.org>, <jonathan.cameron@huawei.com>, <lpieralisi@kernel.org>, <peter.maydell@linaro.org>, <richard.henderson@linaro.org>, <imammedo@redhat.com>, <andrew.jones@linux.dev>, <david@redhat.com>, <philmd@linaro.org>, <eric.auger@redhat.com>, <oliver.upton@linux.dev>, <pbonzini@redhat.com>, <mst@redhat.com>, <will@kernel.org>, <gshan@redhat.com>, <rafael@kernel.org>, <alex.bennee@linaro.org>, <linux@armlinux.org.uk>, <darren@os.amperecomputing.com>, <ilkka@os.amperecomputing.com>, <vishnu@os.amperecomputing.com>, <karl.heubaum@oracle.com>, <miguel.luis@oracle.com>, <salil.mehta@opnsrc.net>, <zhukeqian1@huawei.com>, <wangxiongfeng2@huawei.com>, <wangyanan55@huawei.com>, <jiakernel2@gmail.com>, <maobibo@loongson.cn>, <lixianglai@loongson.cn>, <linuxarm@huawei.com> Subject: [PATCH V5 0/9] Add architecture agnostic code to support vCPU Hotplug Date: Wed, 11 Oct 2023 20:43:46 +0100 [thread overview] Message-ID: <20231011194355.15628-1-salil.mehta@huawei.com> (raw) Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 4,6,7] 3. ACPI CPUs AML code change [Patch 5] 4. Helper functions to support unrealization of CPU objects [Patch 8,9] 5. Misc [Patch 2,3] Repository: [*] https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v2.common.v5 Revision History: RFC V4 -> RFC V5 1. Addressed Gavin Shan's comments - Fixed the trace events print string for kvm_{create,get,park,destroy}_vcpu - Added Reviewed-by tag for patch {1} 2. Added Shaoqin Huang's Reviewed-by tags for Patches {2,3} 3. Added Tested-by Tag from Vishnu Pajjuri to the patch-set 4. Dropped the ARM specific Patch-10 from V4 Link: https://lore.kernel.org/qemu-devel/20231009203601.17584-1-salil.mehta@huawei.com/ RFC V3 -> RFC V4 1. Addressed David Hilderbrand's comments - Fixed the wrong doc comment of kvm_park_vcpu API prototype - Added Reviewed-by tags for patches {2,4} Link: https://lore.kernel.org/qemu-devel/20231009112812.10612-1-salil.mehta@huawei.com/ RFC V2 -> RFC V3 1. Addressed Jonathan Cameron's comments - Fixed 'vcpu-id' type wrongly changed from 'unsigned long' to 'integer' - Removed unnecessary use of variable 'vcpu_id' in kvm_park_vcpu - Updated [Patch V2 03/10] commit-log with details of ACPI_CPU_SCAN_METHOD macro - Updated [Patch V2 05/10] commit-log with details of conditional event handler method - Added Reviewed-by tags for patches {2,3,4,6,7} 2. Addressed Gavin Shan's comments - Remove unnecessary use of variable 'vcpu_id' in kvm_par_vcpu - Fixed return value in kvm_get_vcpu from -1 to -ENOENT - Reset the value of 'gdb_num_g_regs' in gdb_unregister_coprocessor_all - Fixed the kvm_{create,park}_vcpu prototypes docs - Added Reviewed-by tags for patches {2,3,4,5,6,7,9,10} 3. Addressed one earlier missed comment by Alex Bennée in RFC V1 - Added traces instead of DPRINTF in the newly added and some existing functions Link: https://lore.kernel.org/qemu-devel/20230930001933.2660-1-salil.mehta@huawei.com/ RFC V1 -> RFC V2 1. Addressed Alex Bennée's comments - Refactored the kvm_create_vcpu logic to get rid of goto - Added the docs for kvm_{create,park}_vcpu prototypes - Splitted the gdbstub and AddressSpace destruction change into separate patches - Added Reviewed-by tags for patches {2,10} Link: https://lore.kernel.org/qemu-devel/20230929124304.13672-1-salil.mehta@huawei.com/ References: [1] https://lore.kernel.org/qemu-devel/20230926100436.28284-1-salil.mehta@huawei.com/ [2] https://lore.kernel.org/all/20230913163823.7880-1-james.morse@arm.com/ [3] https://lore.kernel.org/qemu-devel/cover.1695697701.git.lixianglai@loongson.cn/ Salil Mehta (9): accel/kvm: Extract common KVM vCPU {creation,parking} code hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file hw/acpi: Add ACPI CPU hotplug init stub hw/acpi: Init GED framework with CPU hotplug events hw/acpi: Update CPUs AML with cpu-(ctrl)dev change hw/acpi: Update GED _EVT method AML with CPU scan hw/acpi: Update ACPI GED framework to support vCPU Hotplug physmem: Add helper function to destroy CPU AddressSpace gdbstub: Add helper function to unregister GDB register space accel/kvm/kvm-all.c | 64 ++++++++++++++++++++------ accel/kvm/trace-events | 4 ++ gdbstub/gdbstub.c | 15 ++++++ hw/acpi/acpi-cpu-hotplug-stub.c | 6 +++ hw/acpi/cpu.c | 27 +++++++---- hw/acpi/generic_event_device.c | 22 +++++++++ hw/i386/acpi-build.c | 2 +- include/exec/cpu-common.h | 8 ++++ include/exec/gdbstub.h | 5 ++ include/hw/acpi/cpu.h | 5 +- include/hw/acpi/cpu_hotplug.h | 4 ++ include/hw/acpi/generic_event_device.h | 5 ++ include/hw/core/cpu.h | 1 + include/sysemu/kvm.h | 16 +++++++ softmmu/physmem.c | 25 ++++++++++ 15 files changed, 182 insertions(+), 27 deletions(-) -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Salil Mehta <salil.mehta@huawei.com> To: <qemu-devel@nongnu.org>, <qemu-arm@nongnu.org> Cc: <salil.mehta@huawei.com>, <maz@kernel.org>, <jean-philippe@linaro.org>, <jonathan.cameron@huawei.com>, <lpieralisi@kernel.org>, <peter.maydell@linaro.org>, <richard.henderson@linaro.org>, <imammedo@redhat.com>, <andrew.jones@linux.dev>, <david@redhat.com>, <philmd@linaro.org>, <eric.auger@redhat.com>, <oliver.upton@linux.dev>, <pbonzini@redhat.com>, <mst@redhat.com>, <will@kernel.org>, <gshan@redhat.com>, <rafael@kernel.org>, <alex.bennee@linaro.org>, <linux@armlinux.org.uk>, <darren@os.amperecomputing.com>, <ilkka@os.amperecomputing.com>, <vishnu@os.amperecomputing.com>, <karl.heubaum@oracle.com>, <miguel.luis@oracle.com>, <salil.mehta@opnsrc.net>, <zhukeqian1@huawei.com>, <wangxiongfeng2@huawei.com>, <wangyanan55@huawei.com>, <jiakernel2@gmail.com>, <maobibo@loongson.cn>, <lixianglai@loongson.cn>, <linuxarm@huawei.com> Subject: [PATCH V5 0/9] Add architecture agnostic code to support vCPU Hotplug Date: Wed, 11 Oct 2023 20:43:46 +0100 [thread overview] Message-ID: <20231011194355.15628-1-salil.mehta@huawei.com> (raw) Message-ID: <20231011194346.m2BwQSwR1wdZ2EbnccUgwNsfPRp2Ai3rT33kvib4bVk@z> (raw) Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 4,6,7] 3. ACPI CPUs AML code change [Patch 5] 4. Helper functions to support unrealization of CPU objects [Patch 8,9] 5. Misc [Patch 2,3] Repository: [*] https://github.com/salil-mehta/qemu.git virt-cpuhp-armv8/rfc-v2.common.v5 Revision History: RFC V4 -> RFC V5 1. Addressed Gavin Shan's comments - Fixed the trace events print string for kvm_{create,get,park,destroy}_vcpu - Added Reviewed-by tag for patch {1} 2. Added Shaoqin Huang's Reviewed-by tags for Patches {2,3} 3. Added Tested-by Tag from Vishnu Pajjuri to the patch-set 4. Dropped the ARM specific Patch-10 from V4 Link: https://lore.kernel.org/qemu-devel/20231009203601.17584-1-salil.mehta@huawei.com/ RFC V3 -> RFC V4 1. Addressed David Hilderbrand's comments - Fixed the wrong doc comment of kvm_park_vcpu API prototype - Added Reviewed-by tags for patches {2,4} Link: https://lore.kernel.org/qemu-devel/20231009112812.10612-1-salil.mehta@huawei.com/ RFC V2 -> RFC V3 1. Addressed Jonathan Cameron's comments - Fixed 'vcpu-id' type wrongly changed from 'unsigned long' to 'integer' - Removed unnecessary use of variable 'vcpu_id' in kvm_park_vcpu - Updated [Patch V2 03/10] commit-log with details of ACPI_CPU_SCAN_METHOD macro - Updated [Patch V2 05/10] commit-log with details of conditional event handler method - Added Reviewed-by tags for patches {2,3,4,6,7} 2. Addressed Gavin Shan's comments - Remove unnecessary use of variable 'vcpu_id' in kvm_par_vcpu - Fixed return value in kvm_get_vcpu from -1 to -ENOENT - Reset the value of 'gdb_num_g_regs' in gdb_unregister_coprocessor_all - Fixed the kvm_{create,park}_vcpu prototypes docs - Added Reviewed-by tags for patches {2,3,4,5,6,7,9,10} 3. Addressed one earlier missed comment by Alex Bennée in RFC V1 - Added traces instead of DPRINTF in the newly added and some existing functions Link: https://lore.kernel.org/qemu-devel/20230930001933.2660-1-salil.mehta@huawei.com/ RFC V1 -> RFC V2 1. Addressed Alex Bennée's comments - Refactored the kvm_create_vcpu logic to get rid of goto - Added the docs for kvm_{create,park}_vcpu prototypes - Splitted the gdbstub and AddressSpace destruction change into separate patches - Added Reviewed-by tags for patches {2,10} Link: https://lore.kernel.org/qemu-devel/20230929124304.13672-1-salil.mehta@huawei.com/ References: [1] https://lore.kernel.org/qemu-devel/20230926100436.28284-1-salil.mehta@huawei.com/ [2] https://lore.kernel.org/all/20230913163823.7880-1-james.morse@arm.com/ [3] https://lore.kernel.org/qemu-devel/cover.1695697701.git.lixianglai@loongson.cn/ Salil Mehta (9): accel/kvm: Extract common KVM vCPU {creation,parking} code hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file hw/acpi: Add ACPI CPU hotplug init stub hw/acpi: Init GED framework with CPU hotplug events hw/acpi: Update CPUs AML with cpu-(ctrl)dev change hw/acpi: Update GED _EVT method AML with CPU scan hw/acpi: Update ACPI GED framework to support vCPU Hotplug physmem: Add helper function to destroy CPU AddressSpace gdbstub: Add helper function to unregister GDB register space accel/kvm/kvm-all.c | 64 ++++++++++++++++++++------ accel/kvm/trace-events | 4 ++ gdbstub/gdbstub.c | 15 ++++++ hw/acpi/acpi-cpu-hotplug-stub.c | 6 +++ hw/acpi/cpu.c | 27 +++++++---- hw/acpi/generic_event_device.c | 22 +++++++++ hw/i386/acpi-build.c | 2 +- include/exec/cpu-common.h | 8 ++++ include/exec/gdbstub.h | 5 ++ include/hw/acpi/cpu.h | 5 +- include/hw/acpi/cpu_hotplug.h | 4 ++ include/hw/acpi/generic_event_device.h | 5 ++ include/hw/core/cpu.h | 1 + include/sysemu/kvm.h | 16 +++++++ softmmu/physmem.c | 25 ++++++++++ 15 files changed, 182 insertions(+), 27 deletions(-) -- 2.34.1
next reply other threads:[~2023-10-11 19:45 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-11 19:43 Salil Mehta via [this message] 2023-10-11 19:43 ` [PATCH V5 0/9] Add architecture agnostic code to support vCPU Hotplug Salil Mehta 2023-10-11 19:43 ` [PATCH V5 1/9] accel/kvm: Extract common KVM vCPU {creation, parking} code Salil Mehta via 2023-10-11 19:43 ` Salil Mehta 2023-10-12 14:36 ` [PATCH V5 1/9] accel/kvm: Extract common KVM vCPU {creation,parking} code Jonathan Cameron via 2023-10-12 14:36 ` Jonathan Cameron 2023-10-12 14:38 ` Salil Mehta via 2023-10-12 14:38 ` Salil Mehta 2023-10-16 2:45 ` [PATCH V5 1/9] accel/kvm: Extract common KVM vCPU {creation, parking} code Shaoqin Huang 2023-10-16 2:47 ` Shaoqin Huang 2023-10-11 19:43 ` [PATCH V5 2/9] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file Salil Mehta via 2023-10-11 19:43 ` Salil Mehta 2023-10-11 19:43 ` [PATCH V5 3/9] hw/acpi: Add ACPI CPU hotplug init stub Salil Mehta via 2023-10-11 19:43 ` Salil Mehta 2023-10-11 19:43 ` [PATCH V5 4/9] hw/acpi: Init GED framework with CPU hotplug events Salil Mehta via 2023-10-11 19:43 ` Salil Mehta 2023-10-16 2:53 ` Shaoqin Huang 2023-10-16 10:01 ` Salil Mehta via 2023-10-16 10:01 ` Salil Mehta 2023-10-11 19:43 ` [PATCH V5 5/9] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change Salil Mehta via 2023-10-11 19:43 ` Salil Mehta 2023-10-12 14:49 ` Jonathan Cameron via 2023-10-12 14:49 ` Jonathan Cameron 2023-10-11 19:43 ` [PATCH V5 6/9] hw/acpi: Update GED _EVT method AML with CPU scan Salil Mehta via 2023-10-11 19:43 ` Salil Mehta 2023-10-11 19:43 ` [PATCH V5 7/9] hw/acpi: Update ACPI GED framework to support vCPU Hotplug Salil Mehta via 2023-10-11 19:43 ` Salil Mehta 2023-10-11 19:43 ` [PATCH V5 8/9] physmem: Add helper function to destroy CPU AddressSpace Salil Mehta via 2023-10-11 19:43 ` Salil Mehta 2023-10-11 23:31 ` Gavin Shan 2023-10-12 0:04 ` Salil Mehta 2023-10-12 0:18 ` Gavin Shan 2023-10-12 9:22 ` Salil Mehta via 2023-10-12 9:22 ` Salil Mehta 2023-10-11 19:43 ` [PATCH V5 9/9] gdbstub: Add helper function to unregister GDB register space Salil Mehta via 2023-10-11 19:43 ` Salil Mehta 2023-10-12 0:07 ` Gavin Shan 2023-10-12 9:19 ` Salil Mehta via 2023-10-12 9:19 ` Salil Mehta 2023-10-13 3:58 ` [PATCH V5 0/9] Add architecture agnostic code to support vCPU Hotplug lixianglai 2023-10-13 10:21 ` Salil Mehta via 2023-10-13 10:21 ` Salil Mehta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231011194355.15628-1-salil.mehta@huawei.com \ --to=qemu-devel@nongnu.org \ --cc=alex.bennee@linaro.org \ --cc=andrew.jones@linux.dev \ --cc=darren@os.amperecomputing.com \ --cc=david@redhat.com \ --cc=eric.auger@redhat.com \ --cc=gshan@redhat.com \ --cc=ilkka@os.amperecomputing.com \ --cc=imammedo@redhat.com \ --cc=jean-philippe@linaro.org \ --cc=jiakernel2@gmail.com \ --cc=jonathan.cameron@huawei.com \ --cc=karl.heubaum@oracle.com \ --cc=linux@armlinux.org.uk \ --cc=linuxarm@huawei.com \ --cc=lixianglai@loongson.cn \ --cc=lpieralisi@kernel.org \ --cc=maobibo@loongson.cn \ --cc=maz@kernel.org \ --cc=miguel.luis@oracle.com \ --cc=mst@redhat.com \ --cc=oliver.upton@linux.dev \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=philmd@linaro.org \ --cc=qemu-arm@nongnu.org \ --cc=rafael@kernel.org \ --cc=richard.henderson@linaro.org \ --cc=salil.mehta@huawei.com \ --cc=salil.mehta@opnsrc.net \ --cc=vishnu@os.amperecomputing.com \ --cc=wangxiongfeng2@huawei.com \ --cc=wangyanan55@huawei.com \ --cc=will@kernel.org \ --cc=zhukeqian1@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).