From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, "Bohdan Kostiv" <bogdan.kostiv@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 0/2] system: Fix handling of '-serial none -serial something'
Date: Mon, 22 Jan 2024 16:36:05 +0000 [thread overview]
Message-ID: <20240122163607.459769-1-peter.maydell@linaro.org> (raw)
(This patchset fixes a bug reported by Bohdan Kostiv at
https://lore.kernel.org/qemu-devel/CAA3Sv1LQ8yDUNLCB5WqLVZjsHffrU0uSbL_YYJW_m+Db2PhEeQ@mail.gmail.com/
-- my patch 1 avoids a bug in his suggested change, and
patch 2 is new, improving the documentation.)
Currently if the user passes multiple -serial options on the command
line, we mostly treat those as applying to the different serial
devices in order, so that for example
-serial stdio -serial file:filename
will connect the first serial port to stdio and the second to the
named file.
The exception to this is the '-serial none' serial device type. This
means "don't allocate this serial device", but a bug means that
following -serial options are not correctly handled, so that
-serial none -serial stdio
has the unexpected effect that stdio is connected to the first serial
port, not the second.
This is a very long-standing bug that dates back at least as far as
commit 998bbd74b9d81 from 2009.
It's possible that some users have commandlines that mistakenly
include a previously-redundant '-serial none'; those users can
simply delete that option in order to produce a command line that
has the same effect on both old and new QEMU. We can mention this
in the release notes.
Our documentation for -serial none and -serial null was also a
bit lacking; I've provided a patch here which tries to improve it.
thanks
-- PMM
Peter Maydell (2):
system/vl.c: Fix handling of '-serial none -serial something'
qemu-options.hx: Improve -serial option documentation
system/vl.c | 22 +++++++++++++---------
qemu-options.hx | 14 +++++++++++---
2 files changed, 24 insertions(+), 12 deletions(-)
--
2.34.1
next reply other threads:[~2024-01-22 16:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 16:36 Peter Maydell [this message]
2024-01-22 16:36 ` [PATCH 1/2] system/vl.c: Fix handling of '-serial none -serial something' Peter Maydell
2024-01-22 16:42 ` Daniel P. Berrangé
2024-01-23 15:57 ` Richard Henderson
2024-01-22 16:36 ` [PATCH 2/2] qemu-options.hx: Improve -serial option documentation Peter Maydell
2024-01-22 16:41 ` Daniel P. Berrangé
2024-01-22 17:46 ` Philippe Mathieu-Daudé
2024-01-22 17:55 ` Peter Maydell
2024-02-01 13:35 ` [PATCH 0/2] system: Fix handling of '-serial none -serial something' Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122163607.459769-1-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=bogdan.kostiv@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).