From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, "Bohdan Kostiv" <bogdan.kostiv@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH 1/2] system/vl.c: Fix handling of '-serial none -serial something'
Date: Wed, 24 Jan 2024 01:57:53 +1000 [thread overview]
Message-ID: <506043f7-e245-437c-a4cc-e6bc0f71d086@linaro.org> (raw)
In-Reply-To: <20240122163607.459769-2-peter.maydell@linaro.org>
On 1/23/24 02:36, Peter Maydell wrote:
> Currently if the user passes multiple -serial options on the command
> line, we mostly treat those as applying to the different serial
> devices in order, so that for example
> -serial stdio -serialfile:filename
> will connect the first serial port to stdio and the second to the
> named file.
>
> The exception to this is the '-serial none' serial device type. This
> means "don't allocate this serial device", but a bug means that
> following -serial options are not correctly handled, so that
> -serial none -serial stdio
> has the unexpected effect that stdio is connected to the first serial
> port, not the second.
>
> This is a very long-standing bug that dates back at least as far as
> commit 998bbd74b9d81 from 2009.
>
> Make the 'none' serial type move forward in the indexing of serial
> devices like all the other serial types, so that any subsequent
> -serial options are correctly handled.
>
> Note that if your commandline mistakenly had a '-serial none' that
> was being overridden by a following '-serial something' option, you
> should delete the unnecessary '-serial none'. This will give you the
> same behaviour as before, on QEMU versions both with and without this
> bug fix.
>
> Cc:qemu-stable@nongnu.org
> Reported-by: Bohdan Kostiv<bohdan.kostiv@tii.ae>
> Fixes: 998bbd74b9d81 ("default devices: core code & serial lines")
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> See the discussion of Bohdan's patch on the mailing list for
> further context:
> https://lore.kernel.org/qemu-devel/CAA3Sv1LQ8yDUNLCB5WqLVZjsHffrU0uSbL_YYJW_m+Db2PhEeQ@mail.gmail.com/
> ---
> system/vl.c | 22 +++++++++++++---------
> 1 file changed, 13 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-01-23 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 16:36 [PATCH 0/2] system: Fix handling of '-serial none -serial something' Peter Maydell
2024-01-22 16:36 ` [PATCH 1/2] system/vl.c: " Peter Maydell
2024-01-22 16:42 ` Daniel P. Berrangé
2024-01-23 15:57 ` Richard Henderson [this message]
2024-01-22 16:36 ` [PATCH 2/2] qemu-options.hx: Improve -serial option documentation Peter Maydell
2024-01-22 16:41 ` Daniel P. Berrangé
2024-01-22 17:46 ` Philippe Mathieu-Daudé
2024-01-22 17:55 ` Peter Maydell
2024-02-01 13:35 ` [PATCH 0/2] system: Fix handling of '-serial none -serial something' Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506043f7-e245-437c-a4cc-e6bc0f71d086@linaro.org \
--to=richard.henderson@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=bogdan.kostiv@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).