* [PATCH] acpi: cpuhp: document CPHP_GET_CPU_ID_CMD command
@ 2020-01-29 14:06 Igor Mammedov
2020-01-29 16:05 ` Laszlo Ersek
2020-02-12 22:27 ` Laszlo Ersek
0 siblings, 2 replies; 4+ messages in thread
From: Igor Mammedov @ 2020-01-29 14:06 UTC (permalink / raw)
To: qemu-devel; +Cc: lersek, philmd, mst
Commit 3a61c8db9d25 introduced CPHP_GET_CPU_ID_CMD command but
did not sufficiently describe it. Fix it by adding missing command
documentation.
Fixes: 3a61c8db9d25 ("acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command")
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
---
docs/specs/acpi_cpu_hotplug.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt
index a8ce5e7..9bb22d1 100644
--- a/docs/specs/acpi_cpu_hotplug.txt
+++ b/docs/specs/acpi_cpu_hotplug.txt
@@ -94,6 +94,8 @@ write access:
register in QEMU
2: following writes to 'Command data' register set OST status
register in QEMU
+ 3: following reads from 'Command data' and 'Command data 2' return
+ architecture specific CPU ID value for currently selected CPU.
other values: reserved
[0x6-0x7] reserved
[0x8] Command data: (DWORD access)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi: cpuhp: document CPHP_GET_CPU_ID_CMD command
2020-01-29 14:06 [PATCH] acpi: cpuhp: document CPHP_GET_CPU_ID_CMD command Igor Mammedov
@ 2020-01-29 16:05 ` Laszlo Ersek
2020-02-12 22:27 ` Laszlo Ersek
1 sibling, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2020-01-29 16:05 UTC (permalink / raw)
To: Igor Mammedov, qemu-devel; +Cc: philmd, mst
On 01/29/20 15:06, Igor Mammedov wrote:
> Commit 3a61c8db9d25 introduced CPHP_GET_CPU_ID_CMD command but
> did not sufficiently describe it. Fix it by adding missing command
> documentation.
>
> Fixes: 3a61c8db9d25 ("acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command")
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> docs/specs/acpi_cpu_hotplug.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt
> index a8ce5e7..9bb22d1 100644
> --- a/docs/specs/acpi_cpu_hotplug.txt
> +++ b/docs/specs/acpi_cpu_hotplug.txt
> @@ -94,6 +94,8 @@ write access:
> register in QEMU
> 2: following writes to 'Command data' register set OST status
> register in QEMU
> + 3: following reads from 'Command data' and 'Command data 2' return
> + architecture specific CPU ID value for currently selected CPU.
> other values: reserved
> [0x6-0x7] reserved
> [0x8] Command data: (DWORD access)
>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi: cpuhp: document CPHP_GET_CPU_ID_CMD command
2020-01-29 14:06 [PATCH] acpi: cpuhp: document CPHP_GET_CPU_ID_CMD command Igor Mammedov
2020-01-29 16:05 ` Laszlo Ersek
@ 2020-02-12 22:27 ` Laszlo Ersek
2020-02-13 10:01 ` Michael S. Tsirkin
1 sibling, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2020-02-12 22:27 UTC (permalink / raw)
To: mst; +Cc: Igor Mammedov, philmd, qemu-devel
Michael,
On 01/29/20 15:06, Igor Mammedov wrote:
> Commit 3a61c8db9d25 introduced CPHP_GET_CPU_ID_CMD command but
> did not sufficiently describe it. Fix it by adding missing command
> documentation.
>
> Fixes: 3a61c8db9d25 ("acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command")
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> docs/specs/acpi_cpu_hotplug.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt
> index a8ce5e7..9bb22d1 100644
> --- a/docs/specs/acpi_cpu_hotplug.txt
> +++ b/docs/specs/acpi_cpu_hotplug.txt
> @@ -94,6 +94,8 @@ write access:
> register in QEMU
> 2: following writes to 'Command data' register set OST status
> register in QEMU
> + 3: following reads from 'Command data' and 'Command data 2' return
> + architecture specific CPU ID value for currently selected CPU.
> other values: reserved
> [0x6-0x7] reserved
> [0x8] Command data: (DWORD access)
>
can you please merge this?
It's a docs patch, but 3a61c8db9d25 (noted in "Fixes:") had gone in
through your tree.
Thank you!
Laszlo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi: cpuhp: document CPHP_GET_CPU_ID_CMD command
2020-02-12 22:27 ` Laszlo Ersek
@ 2020-02-13 10:01 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2020-02-13 10:01 UTC (permalink / raw)
To: Laszlo Ersek; +Cc: Igor Mammedov, philmd, qemu-devel
On Wed, Feb 12, 2020 at 11:27:34PM +0100, Laszlo Ersek wrote:
> Michael,
>
> On 01/29/20 15:06, Igor Mammedov wrote:
> > Commit 3a61c8db9d25 introduced CPHP_GET_CPU_ID_CMD command but
> > did not sufficiently describe it. Fix it by adding missing command
> > documentation.
> >
> > Fixes: 3a61c8db9d25 ("acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command")
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> > docs/specs/acpi_cpu_hotplug.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt
> > index a8ce5e7..9bb22d1 100644
> > --- a/docs/specs/acpi_cpu_hotplug.txt
> > +++ b/docs/specs/acpi_cpu_hotplug.txt
> > @@ -94,6 +94,8 @@ write access:
> > register in QEMU
> > 2: following writes to 'Command data' register set OST status
> > register in QEMU
> > + 3: following reads from 'Command data' and 'Command data 2' return
> > + architecture specific CPU ID value for currently selected CPU.
> > other values: reserved
> > [0x6-0x7] reserved
> > [0x8] Command data: (DWORD access)
> >
>
> can you please merge this?
>
> It's a docs patch, but 3a61c8db9d25 (noted in "Fixes:") had gone in
> through your tree.
>
> Thank you!
> Laszlo
Will do, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-13 10:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 14:06 [PATCH] acpi: cpuhp: document CPHP_GET_CPU_ID_CMD command Igor Mammedov
2020-01-29 16:05 ` Laszlo Ersek
2020-02-12 22:27 ` Laszlo Ersek
2020-02-13 10:01 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).