From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>
Subject: Re: [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error
Date: Fri, 3 Jul 2020 17:16:55 +0200 [thread overview]
Message-ID: <2c77e134-4762-89b2-b60d-aabde740f25f@amsat.org> (raw)
In-Reply-To: <CAFEAcA_dhbr6cjK40H0=e39sD2r8ERTZYrY5nhJtx81Rk+RmUg@mail.gmail.com>
On 7/3/20 3:23 PM, Peter Maydell wrote:
> On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> As we have no interest in the underlying block geometry,
>> directly call blk_getlength(). We have to care about machines
>> creating SD card with not drive attached (probably incorrect
>> API use). Simply emit a warning when such Frankenstein cards
>> of zero size are reset.
>
> Which machines create SD cards without a backing block device?
The Aspeed machines:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg718116.html
> I have a feeling that also the monitor "change" and "eject"
> commands can remove the backing block device from the SD card
> object.
This is what I wanted to talk about on IRC. This seems wrong to me,
we should eject the card and destroy it, and recreate a new card
when plugging in another backing block device.
Keep the reparenting on the bus layer, not on the card.
next prev parent reply other threads:[~2020-07-03 15:18 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 13:38 [PATCH v7 00/17] hw/sd/sdcard: Fix CVE-2020-13253 & cleanups Philippe Mathieu-Daudé
2020-06-30 13:38 ` [PATCH v7 01/17] MAINTAINERS: Cc qemu-block mailing list Philippe Mathieu-Daudé
2020-07-03 13:29 ` Peter Maydell
2020-06-30 13:38 ` [PATCH v7 02/17] hw/sd/sdcard: Update coding style to make checkpatch.pl happy Philippe Mathieu-Daudé
2020-07-06 16:24 ` Alistair Francis
2020-06-30 13:38 ` [PATCH v7 03/17] hw/sd/sdcard: Move some definitions to use them earlier Philippe Mathieu-Daudé
2020-07-03 13:08 ` Peter Maydell
2020-06-30 13:38 ` [PATCH v7 04/17] hw/sd/sdcard: Use the HWBLOCK_SIZE definition Philippe Mathieu-Daudé
2020-07-03 13:11 ` Peter Maydell
2020-06-30 13:38 ` [PATCH v7 05/17] hw/sd/sdcard: Do not switch to ReceivingData if address is invalid Philippe Mathieu-Daudé
2020-07-03 13:12 ` Peter Maydell
2020-07-06 16:26 ` Alistair Francis
2020-07-07 8:30 ` Philippe Mathieu-Daudé
2020-07-07 10:24 ` Philippe Mathieu-Daudé
2020-07-07 10:34 ` Philippe Mathieu-Daudé
2020-06-30 13:39 ` [PATCH v7 06/17] hw/sd/sdcard: Restrict Class 6 commands to SCSD cards Philippe Mathieu-Daudé
2020-07-06 16:27 ` Alistair Francis
2020-06-30 13:39 ` [PATCH v7 07/17] hw/sd/sdcard: Move sd->size initialization Philippe Mathieu-Daudé
2020-07-03 13:13 ` Peter Maydell
2020-06-30 13:39 ` [PATCH v7 08/17] hw/sd/sdcard: Call sd_addr_to_wpnum where it is used, consider zero size Philippe Mathieu-Daudé
2020-07-03 13:15 ` Peter Maydell
2020-06-30 13:39 ` [PATCH v7 09/17] hw/sd/sdcard: Special case the -ENOMEDIUM error Philippe Mathieu-Daudé
2020-07-03 13:23 ` Peter Maydell
2020-07-03 15:16 ` Philippe Mathieu-Daudé [this message]
2020-07-03 23:42 ` Philippe Mathieu-Daudé
2020-07-04 22:10 ` Philippe Mathieu-Daudé
2020-07-04 22:18 ` Philippe Mathieu-Daudé
2020-07-04 22:26 ` Philippe Mathieu-Daudé
2020-07-05 17:33 ` Philippe Mathieu-Daudé
2020-07-06 5:52 ` Markus Armbruster
2020-07-06 9:15 ` Peter Maydell
2020-06-30 13:39 ` [PATCH v7 10/17] hw/sd/sdcard: Check address is in range Philippe Mathieu-Daudé
2020-07-03 13:23 ` Peter Maydell
2020-06-30 13:39 ` [PATCH v7 11/17] hw/sd/sdcard: Update the SDState documentation Philippe Mathieu-Daudé
2020-07-06 16:28 ` Alistair Francis
2020-06-30 13:39 ` [PATCH v7 12/17] hw/sd/sdcard: Simplify cmd_valid_while_locked() Philippe Mathieu-Daudé
2020-07-06 16:30 ` Alistair Francis
2020-06-30 13:39 ` [PATCH v7 13/17] hw/sd/sdcard: Constify sd_crc*()'s message argument Philippe Mathieu-Daudé
2020-07-03 13:24 ` Peter Maydell
2020-06-30 13:39 ` [PATCH v7 14/17] hw/sd/sdcard: Make iolen unsigned Philippe Mathieu-Daudé
2020-07-03 13:25 ` Peter Maydell
2020-07-06 16:32 ` Alistair Francis
2020-06-30 13:39 ` [PATCH v7 15/17] hw/sd/sdcard: Correctly display the command name in trace events Philippe Mathieu-Daudé
2020-07-03 13:28 ` Peter Maydell
2020-07-03 15:09 ` Philippe Mathieu-Daudé
2020-06-30 13:39 ` [PATCH v7 16/17] hw/sd/sdcard: Display offset in read/write_data() " Philippe Mathieu-Daudé
2020-07-06 16:33 ` Alistair Francis
2020-06-30 13:39 ` [PATCH v7 17/17] hw/sd/sdcard: Simplify realize() a bit Philippe Mathieu-Daudé
2020-07-06 16:34 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c77e134-4762-89b2-b60d-aabde740f25f@amsat.org \
--to=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).