* [PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default
@ 2020-02-11 13:19 Philippe Mathieu-Daudé
2020-02-11 13:25 ` Kamil Rytarowski
2020-02-13 20:23 ` Wainer dos Santos Moschetta
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-11 13:19 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Bennée, Wainer dos Santos Moschetta, Kamil Rytarowski,
qemu-ppc, Cleber Rosa, Hervé Poussineau,
Philippe Mathieu-Daudé
The ftp.netbsd.org server is slow and downloading the NetBSD ISO
takes too long. Do not include this test in the default suite.
Similarly to commit 471c97a69b:
Currently the Avocado framework does not distinct the time spent
downloading assets vs. the time spent running a test. With big
assets (like a full VM image) the tests likely fail.
This is a limitation known by the Avocado team.
Until this issue get fixed, do not run this tests automatically.
Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
environment variable.
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/acceptance/ppc_prep_40p.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py
index b27572f212..efe06037ba 100644
--- a/tests/acceptance/ppc_prep_40p.py
+++ b/tests/acceptance/ppc_prep_40p.py
@@ -61,6 +61,7 @@ def test_openbios_192m(self):
wait_for_console_pattern(self, '>> CPU type PowerPC,604')
@skipIf(os.getenv('CONTINUOUS_INTEGRATION'), 'Running on Travis-CI')
+ @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
def test_openbios_and_netbsd(self):
"""
:avocado: tags=arch:ppc
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default
2020-02-11 13:19 [PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default Philippe Mathieu-Daudé
@ 2020-02-11 13:25 ` Kamil Rytarowski
2020-02-13 20:23 ` Wainer dos Santos Moschetta
1 sibling, 0 replies; 3+ messages in thread
From: Kamil Rytarowski @ 2020-02-11 13:25 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Wainer dos Santos Moschetta, Kamil Rytarowski, qemu-ppc,
Cleber Rosa, Hervé Poussineau, Alex Bennée
[-- Attachment #1.1: Type: text/plain, Size: 1490 bytes --]
Please use cdn.netbsd.org always.
On 11.02.2020 14:19, Philippe Mathieu-Daudé wrote:
> The ftp.netbsd.org server is slow and downloading the NetBSD ISO
> takes too long. Do not include this test in the default suite.
>
> Similarly to commit 471c97a69b:
>
> Currently the Avocado framework does not distinct the time spent
> downloading assets vs. the time spent running a test. With big
> assets (like a full VM image) the tests likely fail.
>
> This is a limitation known by the Avocado team.
> Until this issue get fixed, do not run this tests automatically.
>
> Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
> environment variable.
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/acceptance/ppc_prep_40p.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py
> index b27572f212..efe06037ba 100644
> --- a/tests/acceptance/ppc_prep_40p.py
> +++ b/tests/acceptance/ppc_prep_40p.py
> @@ -61,6 +61,7 @@ def test_openbios_192m(self):
> wait_for_console_pattern(self, '>> CPU type PowerPC,604')
>
> @skipIf(os.getenv('CONTINUOUS_INTEGRATION'), 'Running on Travis-CI')
> + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
> def test_openbios_and_netbsd(self):
> """
> :avocado: tags=arch:ppc
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default
2020-02-11 13:19 [PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default Philippe Mathieu-Daudé
2020-02-11 13:25 ` Kamil Rytarowski
@ 2020-02-13 20:23 ` Wainer dos Santos Moschetta
1 sibling, 0 replies; 3+ messages in thread
From: Wainer dos Santos Moschetta @ 2020-02-13 20:23 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-ppc, Kamil Rytarowski, Hervé Poussineau,
Alex Bennée, Cleber Rosa
On 2/11/20 11:19 AM, Philippe Mathieu-Daudé wrote:
> The ftp.netbsd.org server is slow and downloading the NetBSD ISO
> takes too long. Do not include this test in the default suite.
>
> Similarly to commit 471c97a69b:
>
> Currently the Avocado framework does not distinct the time spent
> downloading assets vs. the time spent running a test. With big
> assets (like a full VM image) the tests likely fail.
>
> This is a limitation known by the Avocado team.
> Until this issue get fixed, do not run this tests automatically.
>
> Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
> environment variable.
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/acceptance/ppc_prep_40p.py | 1 +
> 1 file changed, 1 insertion(+)
LGTM.
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py
> index b27572f212..efe06037ba 100644
> --- a/tests/acceptance/ppc_prep_40p.py
> +++ b/tests/acceptance/ppc_prep_40p.py
> @@ -61,6 +61,7 @@ def test_openbios_192m(self):
> wait_for_console_pattern(self, '>> CPU type PowerPC,604')
>
> @skipIf(os.getenv('CONTINUOUS_INTEGRATION'), 'Running on Travis-CI')
> + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
> def test_openbios_and_netbsd(self):
> """
> :avocado: tags=arch:ppc
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-13 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 13:19 [PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default Philippe Mathieu-Daudé
2020-02-11 13:25 ` Kamil Rytarowski
2020-02-13 20:23 ` Wainer dos Santos Moschetta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).