Re: [Qemu-devel] [Qemu-ppc] [GIT PULL for qemu-pseries REPOST] pseries: Update SLOF firmware image

[Aravinda Prasad <aravinda@linux.vnet.ibm.com>]

On Monday 12 August 2019 03:38 PM, David Gibson wrote:
> On Mon, Aug 05, 2019 at 02:14:39PM +0530, Aravinda Prasad wrote:
>> Alexey/David,
>>
>> With the SLOF changes, QEMU cannot resize the RTAS blob. Resizing is
>> required for FWNMI support which extends the RTAS blob to include an
>> error log upon a machine check.
>>
>> The check to valid RTAS buffer fails in the guest because the rtas-size
>> updated in QEMU is not reflecting in the guest.
>>
>> Any workaround for this?
> 
> Well, we should still be able to do it, it just means fwnmi would need
> a SLOF change.  It's an inconvenience, but not really a big deal.

Yes. Alexey and I were discussing about the following changes to SLOf:

diff --git a/lib/libhvcall/hvcall.S b/lib/libhvcall/hvcall.S
index b19f6dbeff2c..880d29a29122 100644
--- a/lib/libhvcall/hvcall.S
+++ b/lib/libhvcall/hvcall.S
@@ -134,6 +134,7 @@ ENTRY(hv_rtas)
        ori     r3,r3,KVMPPC_H_RTAS@l
        HVCALL
        blr
+    .space 2048
        .globl hv_rtas_size
 hv_rtas_size:
        .long . - hv_rtas;


But this will statically reserve space for RTAS even when
SPAPR_CAP_FWNMI_MCE is OFF.

Regards,
Aravinda

> 
>> The following FWNMI work which is under review modifies the rtas-size to
>> accommodate the error log:
>> https://lists.nongnu.org/archive/html/qemu-ppc/2019-06/msg00142.html
>>
>>
>> Regards,
>> Aravinda
>>
>> On Friday 19 July 2019 08:15 AM, Alexey Kardashevskiy wrote:
>>> I messed up with my local git so reposting.
>>>
>>> The following changes since commit 216965b20b04fbf74e0ce3a3175a9171dba210de:
>>>
>>>   ppc/pnv: update skiboot to v6.4 (2019-07-18 16:49:57 +1000)
>>>
>>> are available in the Git repository at:
>>>
>>>   git@github.com:aik/qemu.git tags/qemu-slof-20190719
>>>
>>> for you to fetch changes up to 300118db53cc454b049d64418c7b2588165a1c35:
>>>
>>>   pseries: Update SLOF firmware image (2019-07-19 12:43:27 +1000)
>>>
>>> ----------------------------------------------------------------
>>> Alexey Kardashevskiy (1):
>>>       pseries: Update SLOF firmware image
>>>
>>>  pc-bios/README   |   2 +-
>>>  pc-bios/slof.bin | Bin 926432 -> 926784 bytes
>>>  roms/SLOF        |   2 +-
>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>>
>>> *** Note: this is not for master, this is for pseries
>>>
>>
> 

-- 
Regards,
Aravinda