From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, thuth@redhat.com, chenhuacai@gmail.com,
richard.henderson@linaro.org, laurent@vivier.eu,
maobibo@loongson.cn, yangxiaojuan@loongson.cn,
alistair.francis@wdc.com, pbonzini@redhat.com,
alex.bennee@linaro.org
Subject: Re: [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation
Date: Wed, 21 Jul 2021 19:49:05 +0200 [thread overview]
Message-ID: <380b9896-8f6b-e695-a8ca-447c86f06a89@amsat.org> (raw)
In-Reply-To: <b004b8e6-c0c1-d13d-fae0-81c1ee22a95b@amsat.org>
On 7/21/21 7:38 PM, Philippe Mathieu-Daudé wrote:
> On 7/21/21 11:53 AM, Song Gao wrote:
>> This patch implement fixed point arithemtic instruction translation.
Typo arithmetic.
>>
>> This includes:
>> - ADD.{W/D}, SUB.{W/D}
>> - ADDI.{W/D}, ADDU16ID
>> - ALSL.{W[U]/D}
>> - LU12I.W, LU32I.D LU52I.D
>> - SLT[U], SLT[U]I
>> - PCADDI, PCADDU12I, PCADDU18I, PCALAU12I
>> - AND, OR, NOR, XOR, ANDN, ORN
>> - MUL.{W/D}, MULH.{W[U]/D[U]}
>> - MULW.D.W[U]
>> - DIV.{W[U]/D[U]}, MOD.{W[U]/D[U]}
>> - ANDI, ORI, XORI
>>
>> Signed-off-by: Song Gao <gaosong@loongson.cn>
>> ---
>> target/loongarch/insns.decode | 89 ++++
>> target/loongarch/trans.inc.c | 1090 +++++++++++++++++++++++++++++++++++++++++
>> target/loongarch/translate.c | 12 +
>> target/loongarch/translate.h | 1 +
>> 4 files changed, 1192 insertions(+)
>> create mode 100644 target/loongarch/insns.decode
>> create mode 100644 target/loongarch/trans.inc.c
>
> Please don't include all .inc.c in one big translate.c...
>
>> diff --git a/target/loongarch/translate.c b/target/loongarch/translate.c
>> index 531f7e1..b60bdc2 100644
>> --- a/target/loongarch/translate.c
>> +++ b/target/loongarch/translate.c
>> @@ -57,6 +57,15 @@ void gen_load_gpr(TCGv t, int reg)
>> }
>> }
>>
>> +TCGv get_gpr(int regno)
>> +{
>> + if (regno == 0) {
>> + return tcg_constant_tl(0);
>> + } else {
>> + return cpu_gpr[regno];
>> + }
>> +}
>> +
>> static inline void gen_save_pc(target_ulong pc)
>
> ... expose this one ...
>
>> {
>> tcg_gen_movi_tl(cpu_PC, pc);
>> @@ -287,6 +296,9 @@ static bool loongarch_tr_breakpoint_check(DisasContextBase *dcbase,
>> return true;
>> }
>>
>> +#include "decode-insns.c.inc"
>
> ... and move this include to "trans.c".
Since you have the luck to add a new architecture, you could
start cleanly from scratch and add group of instructions, so
this patch would add "trans_arithmetic.c", etc.. in the series.
>> +#include "trans.inc.c"
>
> removing this include.
>
>> static void loongarch_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs)
>> {
>> CPULoongArchState *env = cs->env_ptr;
>> diff --git a/target/loongarch/translate.h b/target/loongarch/translate.h
>> index 333c3bf..ef4d4e7 100644
>> --- a/target/loongarch/translate.h
>> +++ b/target/loongarch/translate.h
>> @@ -35,6 +35,7 @@ void check_fpu_enabled(DisasContext *ctx);
>>
>> void gen_base_offset_addr(TCGv addr, int base, int offset);
>> void gen_load_gpr(TCGv t, int reg);
>> +TCGv get_gpr(int regno);
>> void gen_load_fpr32(TCGv_i32 t, int reg);
>> void gen_load_fpr64(TCGv_i64 t, int reg);
>> void gen_store_fpr32(TCGv_i32 t, int reg);
>>
>
>
next prev parent reply other threads:[~2021-07-21 17:50 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 9:52 [PATCH v2 00/22] Add LoongArch linux-user emulation support Song Gao
2021-07-21 9:52 ` [PATCH v2 01/22] target/loongarch: Add README Song Gao
2021-07-21 9:52 ` [PATCH v2 02/22] target/loongarch: Add CSR registers definition Song Gao
2021-07-21 9:52 ` [PATCH v2 03/22] target/loongarch: Add core definition Song Gao
2021-07-22 22:43 ` Richard Henderson
2021-07-26 8:47 ` Song Gao
2021-07-26 15:32 ` Richard Henderson
2021-07-21 9:53 ` [PATCH v2 04/22] target/loongarch: Add interrupt handling support Song Gao
2021-07-22 22:47 ` Richard Henderson
2021-07-26 9:23 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 05/22] target/loongarch: Add memory management support Song Gao
2021-07-22 22:48 ` Richard Henderson
2021-07-26 9:25 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 06/22] target/loongarch: Add main translation routines Song Gao
2021-07-22 23:50 ` Richard Henderson
2021-07-26 9:39 ` Song Gao
2021-07-26 15:35 ` Richard Henderson
2021-07-21 9:53 ` [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation Song Gao
2021-07-21 17:38 ` Philippe Mathieu-Daudé
2021-07-21 17:49 ` Philippe Mathieu-Daudé [this message]
2021-07-22 7:41 ` Song Gao
2021-07-23 0:46 ` Richard Henderson
2021-07-26 11:56 ` Song Gao
2021-07-26 15:53 ` Richard Henderson
2021-07-27 1:51 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 08/22] target/loongarch: Add fixed point shift " Song Gao
2021-07-23 0:51 ` Richard Henderson
2021-07-26 11:57 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 09/22] target/loongarch: Add fixed point bit " Song Gao
2021-07-21 17:46 ` Philippe Mathieu-Daudé
2021-07-22 8:17 ` Song Gao
2021-07-23 1:29 ` Richard Henderson
2021-07-26 12:22 ` Song Gao
2021-07-26 16:39 ` Richard Henderson
2021-07-21 9:53 ` [PATCH v2 10/22] target/loongarch: Add fixed point load/store " Song Gao
2021-07-23 1:45 ` Richard Henderson
2021-07-26 12:25 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 11/22] target/loongarch: Add fixed point atomic " Song Gao
2021-07-23 1:49 ` Richard Henderson
2021-07-26 12:25 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 12/22] target/loongarch: Add fixed point extra " Song Gao
2021-07-23 5:12 ` Richard Henderson
2021-07-26 12:57 ` Song Gao
2021-07-26 16:42 ` Richard Henderson
2021-07-27 1:46 ` Song Gao
2021-08-04 7:40 ` Song Gao
2021-08-04 7:51 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 13/22] target/loongarch: Add floating point arithmetic " Song Gao
2021-07-23 5:44 ` Richard Henderson
2021-07-27 7:17 ` Song Gao
2021-07-27 16:12 ` Richard Henderson
2021-07-28 1:18 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 14/22] target/loongarch: Add floating point comparison " Song Gao
2021-07-23 6:11 ` Richard Henderson
2021-07-27 7:56 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 15/22] target/loongarch: Add floating point conversion " Song Gao
2021-07-23 6:16 ` Richard Henderson
2021-07-27 7:57 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 16/22] target/loongarch: Add floating point move " Song Gao
2021-07-23 6:29 ` Richard Henderson
2021-07-27 8:06 ` Song Gao
2021-08-12 9:20 ` Song Gao
2021-08-12 19:31 ` Richard Henderson
2021-07-21 9:53 ` [PATCH v2 17/22] target/loongarch: Add floating point load/store " Song Gao
2021-07-23 6:34 ` Richard Henderson
2021-07-27 8:07 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 18/22] target/loongarch: Add branch " Song Gao
2021-07-23 6:38 ` Richard Henderson
2021-07-27 8:07 ` Song Gao
2021-07-21 9:53 ` [PATCH v2 19/22] target/loongarch: Add disassembler Song Gao
2021-07-23 6:40 ` Richard Henderson
2021-08-12 10:33 ` Philippe Mathieu-Daudé
2021-07-21 9:53 ` [PATCH v2 20/22] LoongArch Linux User Emulation Song Gao
2021-07-21 9:53 ` [PATCH v2 21/22] configs: Add loongarch linux-user config Song Gao
2021-07-23 6:43 ` Richard Henderson
2021-07-21 9:53 ` [PATCH v2 22/22] target/loongarch: Add target build suport Song Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=380b9896-8f6b-e695-a8ca-447c86f06a89@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=chenhuacai@gmail.com \
--cc=gaosong@loongson.cn \
--cc=laurent@vivier.eu \
--cc=maobibo@loongson.cn \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).