* [PATCH v2 0/5] target/mips: Misc patches
@ 2020-10-07 20:37 Aleksandar Markovic
2020-10-07 20:37 ` [PATCH v2 1/5] target/mips: Demacro helpers for <ABS|CHS>.<D|S|PS> Aleksandar Markovic
` (5 more replies)
0 siblings, 6 replies; 16+ messages in thread
From: Aleksandar Markovic @ 2020-10-07 20:37 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, aleksandar.rikalo, f4bug, jiaxun.yang,
Aleksandar Markovic, hpoussin, chenhc, aurelien
A set of several, mostly FP, refactorings and improvements.
v1->v2:
- added a patch on MAINTAINERS
Aleksandar Markovic (5):
target/mips: Demacro helpers for <ABS|CHS>.<D|S|PS>
target/mips: Demacro helpers for M<ADD|SUB>F.<D|S>
target/mips: Demacro helpers for <MAX|MAXA|MIN|MINA>.<D|S>
target/mips: Refactor helpers for fp comparison instructions
MAINTAINERS: Remove myself
target/mips/fpu_helper.c | 276 +++++++++++++++++++++++++++++++++--------------
MAINTAINERS | 17 +--
2 files changed, 200 insertions(+), 93 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH v2 1/5] target/mips: Demacro helpers for <ABS|CHS>.<D|S|PS> 2020-10-07 20:37 [PATCH v2 0/5] target/mips: Misc patches Aleksandar Markovic @ 2020-10-07 20:37 ` Aleksandar Markovic 2020-10-09 14:39 ` Philippe Mathieu-Daudé 2020-10-07 20:37 ` [PATCH v2 2/5] target/mips: Demacro helpers for M<ADD|SUB>F.<D|S> Aleksandar Markovic ` (4 subsequent siblings) 5 siblings, 1 reply; 16+ messages in thread From: Aleksandar Markovic @ 2020-10-07 20:37 UTC (permalink / raw) To: qemu-devel Cc: peter.maydell, aleksandar.rikalo, f4bug, jiaxun.yang, Aleksandar Markovic, hpoussin, chenhc, aurelien Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> --- target/mips/fpu_helper.c | 61 +++++++++++++++++++++++++++++++----------------- 1 file changed, 40 insertions(+), 21 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index 56beda4..f851723 100644 --- a/target/mips/fpu_helper.c +++ b/target/mips/fpu_helper.c @@ -983,27 +983,46 @@ uint32_t helper_float_floor_2008_w_s(CPUMIPSState *env, uint32_t fst0) } /* unary operations, not modifying fp status */ -#define FLOAT_UNOP(name) \ -uint64_t helper_float_ ## name ## _d(uint64_t fdt0) \ -{ \ - return float64_ ## name(fdt0); \ -} \ -uint32_t helper_float_ ## name ## _s(uint32_t fst0) \ -{ \ - return float32_ ## name(fst0); \ -} \ -uint64_t helper_float_ ## name ## _ps(uint64_t fdt0) \ -{ \ - uint32_t wt0; \ - uint32_t wth0; \ - \ - wt0 = float32_ ## name(fdt0 & 0XFFFFFFFF); \ - wth0 = float32_ ## name(fdt0 >> 32); \ - return ((uint64_t)wth0 << 32) | wt0; \ -} -FLOAT_UNOP(abs) -FLOAT_UNOP(chs) -#undef FLOAT_UNOP + +uint64_t helper_float_abs_d(uint64_t fdt0) +{ + return float64_abs(fdt0); +} + +uint32_t helper_float_abs_s(uint32_t fst0) +{ + return float32_abs(fst0); +} + +uint64_t helper_float_abs_ps(uint64_t fdt0) +{ + uint32_t wt0; + uint32_t wth0; + + wt0 = float32_abs(fdt0 & 0XFFFFFFFF); + wth0 = float32_abs(fdt0 >> 32); + return ((uint64_t)wth0 << 32) | wt0; +} + +uint64_t helper_float_chs_d(uint64_t fdt0) +{ + return float64_chs(fdt0); +} + +uint32_t helper_float_chs_s(uint32_t fst0) +{ + return float32_chs(fst0); +} + +uint64_t helper_float_chs_ps(uint64_t fdt0) +{ + uint32_t wt0; + uint32_t wth0; + + wt0 = float32_chs(fdt0 & 0XFFFFFFFF); + wth0 = float32_chs(fdt0 >> 32); + return ((uint64_t)wth0 << 32) | wt0; +} /* MIPS specific unary operations */ uint64_t helper_float_recip_d(CPUMIPSState *env, uint64_t fdt0) -- 2.7.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/5] target/mips: Demacro helpers for <ABS|CHS>.<D|S|PS> 2020-10-07 20:37 ` [PATCH v2 1/5] target/mips: Demacro helpers for <ABS|CHS>.<D|S|PS> Aleksandar Markovic @ 2020-10-09 14:39 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 16+ messages in thread From: Philippe Mathieu-Daudé @ 2020-10-09 14:39 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel Cc: peter.maydell, aleksandar.rikalo, hpoussin, chenhc, aurelien On 10/7/20 10:37 PM, Aleksandar Markovic wrote: > Remove function definitions via macros to achieve better code clarity. > > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- > target/mips/fpu_helper.c | 61 +++++++++++++++++++++++++++++++----------------- > 1 file changed, 40 insertions(+), 21 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v2 2/5] target/mips: Demacro helpers for M<ADD|SUB>F.<D|S> 2020-10-07 20:37 [PATCH v2 0/5] target/mips: Misc patches Aleksandar Markovic 2020-10-07 20:37 ` [PATCH v2 1/5] target/mips: Demacro helpers for <ABS|CHS>.<D|S|PS> Aleksandar Markovic @ 2020-10-07 20:37 ` Aleksandar Markovic 2020-10-09 14:42 ` Philippe Mathieu-Daudé 2020-10-07 20:37 ` [PATCH v2 3/5] target/mips: Demacro helpers for <MAX|MAXA|MIN|MINA>.<D|S> Aleksandar Markovic ` (3 subsequent siblings) 5 siblings, 1 reply; 16+ messages in thread From: Aleksandar Markovic @ 2020-10-07 20:37 UTC (permalink / raw) To: qemu-devel Cc: peter.maydell, aleksandar.rikalo, f4bug, jiaxun.yang, Aleksandar Markovic, hpoussin, chenhc, aurelien Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> --- target/mips/fpu_helper.c | 63 +++++++++++++++++++++++++++++++++++------------- 1 file changed, 46 insertions(+), 17 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index f851723..b3c7154 100644 --- a/target/mips/fpu_helper.c +++ b/target/mips/fpu_helper.c @@ -1666,25 +1666,54 @@ uint64_t helper_float_nmsub_ps(CPUMIPSState *env, uint64_t fdt0, } -#define FLOAT_FMADDSUB(name, bits, muladd_arg) \ -uint ## bits ## _t helper_float_ ## name(CPUMIPSState *env, \ - uint ## bits ## _t fs, \ - uint ## bits ## _t ft, \ - uint ## bits ## _t fd) \ -{ \ - uint ## bits ## _t fdret; \ - \ - fdret = float ## bits ## _muladd(fs, ft, fd, muladd_arg, \ - &env->active_fpu.fp_status); \ - update_fcr31(env, GETPC()); \ - return fdret; \ +uint32_t helper_float_maddf_s(CPUMIPSState *env, uint32_t fs, + uint32_t ft, uint32_t fd) +{ + uint32_t fdret; + + fdret = float32_muladd(fs, ft, fd, 0, + &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; +} + +uint64_t helper_float_maddf_d(CPUMIPSState *env, uint64_t fs, + uint64_t ft, uint64_t fd) +{ + uint64_t fdret; + + fdret = float64_muladd(fs, ft, fd, 0, + &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; +} + +uint32_t helper_float_msubf_s(CPUMIPSState *env, uint32_t fs, + uint32_t ft, uint32_t fd) +{ + uint32_t fdret; + + fdret = float32_muladd(fs, ft, fd, float_muladd_negate_product, + &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; +} + +uint64_t helper_float_msubf_d(CPUMIPSState *env, uint64_t fs, + uint64_t ft, uint64_t fd) +{ + uint64_t fdret; + + fdret = float64_muladd(fs, ft, fd, float_muladd_negate_product, + &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; } -FLOAT_FMADDSUB(maddf_s, 32, 0) -FLOAT_FMADDSUB(maddf_d, 64, 0) -FLOAT_FMADDSUB(msubf_s, 32, float_muladd_negate_product) -FLOAT_FMADDSUB(msubf_d, 64, float_muladd_negate_product) -#undef FLOAT_FMADDSUB /* compare operations */ #define FOP_COND_D(op, cond) \ -- 2.7.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v2 2/5] target/mips: Demacro helpers for M<ADD|SUB>F.<D|S> 2020-10-07 20:37 ` [PATCH v2 2/5] target/mips: Demacro helpers for M<ADD|SUB>F.<D|S> Aleksandar Markovic @ 2020-10-09 14:42 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 16+ messages in thread From: Philippe Mathieu-Daudé @ 2020-10-09 14:42 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel Cc: peter.maydell, aleksandar.rikalo, hpoussin, chenhc, aurelien On 10/7/20 10:37 PM, Aleksandar Markovic wrote: > Remove function definitions via macros to achieve better code clarity. > > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- > target/mips/fpu_helper.c | 63 +++++++++++++++++++++++++++++++++++------------- > 1 file changed, 46 insertions(+), 17 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v2 3/5] target/mips: Demacro helpers for <MAX|MAXA|MIN|MINA>.<D|S> 2020-10-07 20:37 [PATCH v2 0/5] target/mips: Misc patches Aleksandar Markovic 2020-10-07 20:37 ` [PATCH v2 1/5] target/mips: Demacro helpers for <ABS|CHS>.<D|S|PS> Aleksandar Markovic 2020-10-07 20:37 ` [PATCH v2 2/5] target/mips: Demacro helpers for M<ADD|SUB>F.<D|S> Aleksandar Markovic @ 2020-10-07 20:37 ` Aleksandar Markovic 2020-10-09 14:44 ` Philippe Mathieu-Daudé 2020-10-07 20:37 ` [PATCH v2 4/5] target/mips: Refactor helpers for fp comparison instructions Aleksandar Markovic ` (2 subsequent siblings) 5 siblings, 1 reply; 16+ messages in thread From: Aleksandar Markovic @ 2020-10-07 20:37 UTC (permalink / raw) To: qemu-devel Cc: peter.maydell, aleksandar.rikalo, f4bug, jiaxun.yang, Aleksandar Markovic, hpoussin, chenhc, aurelien Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> --- target/mips/fpu_helper.c | 104 ++++++++++++++++++++++++++++++++++++----------- 1 file changed, 81 insertions(+), 23 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index b3c7154..6cc956c 100644 --- a/target/mips/fpu_helper.c +++ b/target/mips/fpu_helper.c @@ -1475,29 +1475,87 @@ uint64_t helper_float_mulr_ps(CPUMIPSState *env, uint64_t fdt0, uint64_t fdt1) return ((uint64_t)fsth2 << 32) | fstl2; } -#define FLOAT_MINMAX(name, bits, minmaxfunc) \ -uint ## bits ## _t helper_float_ ## name(CPUMIPSState *env, \ - uint ## bits ## _t fs, \ - uint ## bits ## _t ft) \ -{ \ - uint ## bits ## _t fdret; \ - \ - fdret = float ## bits ## _ ## minmaxfunc(fs, ft, \ - &env->active_fpu.fp_status); \ - update_fcr31(env, GETPC()); \ - return fdret; \ -} - -FLOAT_MINMAX(max_s, 32, maxnum) -FLOAT_MINMAX(max_d, 64, maxnum) -FLOAT_MINMAX(maxa_s, 32, maxnummag) -FLOAT_MINMAX(maxa_d, 64, maxnummag) - -FLOAT_MINMAX(min_s, 32, minnum) -FLOAT_MINMAX(min_d, 64, minnum) -FLOAT_MINMAX(mina_s, 32, minnummag) -FLOAT_MINMAX(mina_d, 64, minnummag) -#undef FLOAT_MINMAX + +uint32_t helper_float_max_s(CPUMIPSState *env, uint32_t fs, uint32_t ft) +{ + uint32_t fdret; + + fdret = float32_maxnum(fs, ft, &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; +} + +uint64_t helper_float_max_d(CPUMIPSState *env, uint64_t fs, uint64_t ft) +{ + uint64_t fdret; + + fdret = float64_maxnum(fs, ft, &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; +} + +uint32_t helper_float_maxa_s(CPUMIPSState *env, uint32_t fs, uint32_t ft) +{ + uint32_t fdret; + + fdret = float32_maxnummag(fs, ft, &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; +} + +uint64_t helper_float_maxa_d(CPUMIPSState *env, uint64_t fs, uint64_t ft) +{ + uint64_t fdret; + + fdret = float64_maxnummag(fs, ft, &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; +} + +uint32_t helper_float_min_s(CPUMIPSState *env, uint32_t fs, uint32_t ft) +{ + uint32_t fdret; + + fdret = float32_minnum(fs, ft, &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; +} + +uint64_t helper_float_min_d(CPUMIPSState *env, uint64_t fs, uint64_t ft) +{ + uint64_t fdret; + + fdret = float64_minnum(fs, ft, &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; +} + +uint32_t helper_float_mina_s(CPUMIPSState *env, uint32_t fs, uint32_t ft) +{ + uint32_t fdret; + + fdret = float32_minnummag(fs, ft, &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; +} + +uint64_t helper_float_mina_d(CPUMIPSState *env, uint64_t fs, uint64_t ft) +{ + uint64_t fdret; + + fdret = float64_minnummag(fs, ft, &env->active_fpu.fp_status); + + update_fcr31(env, GETPC()); + return fdret; +} + /* ternary operations */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v2 3/5] target/mips: Demacro helpers for <MAX|MAXA|MIN|MINA>.<D|S> 2020-10-07 20:37 ` [PATCH v2 3/5] target/mips: Demacro helpers for <MAX|MAXA|MIN|MINA>.<D|S> Aleksandar Markovic @ 2020-10-09 14:44 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 16+ messages in thread From: Philippe Mathieu-Daudé @ 2020-10-09 14:44 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel Cc: peter.maydell, aleksandar.rikalo, hpoussin, chenhc, aurelien On 10/7/20 10:37 PM, Aleksandar Markovic wrote: > Remove function definitions via macros to achieve better code clarity. > > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- > target/mips/fpu_helper.c | 104 ++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 81 insertions(+), 23 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v2 4/5] target/mips: Refactor helpers for fp comparison instructions 2020-10-07 20:37 [PATCH v2 0/5] target/mips: Misc patches Aleksandar Markovic ` (2 preceding siblings ...) 2020-10-07 20:37 ` [PATCH v2 3/5] target/mips: Demacro helpers for <MAX|MAXA|MIN|MINA>.<D|S> Aleksandar Markovic @ 2020-10-07 20:37 ` Aleksandar Markovic 2020-10-09 14:47 ` Philippe Mathieu-Daudé 2020-10-07 20:37 ` [PATCH v2 5/5] MAINTAINERS: Remove myself Aleksandar Markovic 2020-10-09 15:00 ` [PATCH v2 0/5] target/mips: Misc patches Philippe Mathieu-Daudé 5 siblings, 1 reply; 16+ messages in thread From: Aleksandar Markovic @ 2020-10-07 20:37 UTC (permalink / raw) To: qemu-devel Cc: peter.maydell, aleksandar.rikalo, f4bug, jiaxun.yang, Aleksandar Markovic, hpoussin, chenhc, aurelien This change causes slighlty better performance of emulation of fp comparison instructions via better compiler optimization of refactored code. The functionality is otherwise unchanged. Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> --- target/mips/fpu_helper.c | 56 +++++++++++++++++++++++++++--------------------- 1 file changed, 32 insertions(+), 24 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index 6cc956c..8d48a5b 100644 --- a/target/mips/fpu_helper.c +++ b/target/mips/fpu_helper.c @@ -1780,11 +1780,12 @@ void helper_cmp_d_ ## op(CPUMIPSState *env, uint64_t fdt0, \ { \ int c; \ c = cond; \ - update_fcr31(env, GETPC()); \ - if (c) \ + if (c) { \ SET_FP_COND(cc, env->active_fpu); \ - else \ + } else { \ CLEAR_FP_COND(cc, env->active_fpu); \ + } \ + update_fcr31(env, GETPC()); \ } \ void helper_cmpabs_d_ ## op(CPUMIPSState *env, uint64_t fdt0, \ uint64_t fdt1, int cc) \ @@ -1793,11 +1794,12 @@ void helper_cmpabs_d_ ## op(CPUMIPSState *env, uint64_t fdt0, \ fdt0 = float64_abs(fdt0); \ fdt1 = float64_abs(fdt1); \ c = cond; \ - update_fcr31(env, GETPC()); \ - if (c) \ + if (c) { \ SET_FP_COND(cc, env->active_fpu); \ - else \ + } else { \ CLEAR_FP_COND(cc, env->active_fpu); \ + } \ + update_fcr31(env, GETPC()); \ } /* @@ -1859,11 +1861,12 @@ void helper_cmp_s_ ## op(CPUMIPSState *env, uint32_t fst0, \ { \ int c; \ c = cond; \ - update_fcr31(env, GETPC()); \ - if (c) \ + if (c) { \ SET_FP_COND(cc, env->active_fpu); \ - else \ + } else { \ CLEAR_FP_COND(cc, env->active_fpu); \ + } \ + update_fcr31(env, GETPC()); \ } \ void helper_cmpabs_s_ ## op(CPUMIPSState *env, uint32_t fst0, \ uint32_t fst1, int cc) \ @@ -1872,11 +1875,12 @@ void helper_cmpabs_s_ ## op(CPUMIPSState *env, uint32_t fst0, \ fst0 = float32_abs(fst0); \ fst1 = float32_abs(fst1); \ c = cond; \ - update_fcr31(env, GETPC()); \ - if (c) \ + if (c) { \ SET_FP_COND(cc, env->active_fpu); \ - else \ + } else { \ CLEAR_FP_COND(cc, env->active_fpu); \ + } \ + update_fcr31(env, GETPC()); \ } /* @@ -1944,15 +1948,17 @@ void helper_cmp_ps_ ## op(CPUMIPSState *env, uint64_t fdt0, \ fsth1 = fdt1 >> 32; \ cl = condl; \ ch = condh; \ - update_fcr31(env, GETPC()); \ - if (cl) \ + if (cl) { \ SET_FP_COND(cc, env->active_fpu); \ - else \ + } else { \ CLEAR_FP_COND(cc, env->active_fpu); \ - if (ch) \ + } \ + if (ch) { \ SET_FP_COND(cc + 1, env->active_fpu); \ - else \ + } else { \ CLEAR_FP_COND(cc + 1, env->active_fpu); \ + } \ + update_fcr31(env, GETPC()); \ } \ void helper_cmpabs_ps_ ## op(CPUMIPSState *env, uint64_t fdt0, \ uint64_t fdt1, int cc) \ @@ -1965,15 +1971,17 @@ void helper_cmpabs_ps_ ## op(CPUMIPSState *env, uint64_t fdt0, \ fsth1 = float32_abs(fdt1 >> 32); \ cl = condl; \ ch = condh; \ - update_fcr31(env, GETPC()); \ - if (cl) \ + if (cl) { \ SET_FP_COND(cc, env->active_fpu); \ - else \ + } else { \ CLEAR_FP_COND(cc, env->active_fpu); \ - if (ch) \ + } \ + if (ch) { \ SET_FP_COND(cc + 1, env->active_fpu); \ - else \ + } else { \ CLEAR_FP_COND(cc + 1, env->active_fpu); \ + } \ + update_fcr31(env, GETPC()); \ } /* @@ -2080,12 +2088,12 @@ uint64_t helper_r6_cmp_d_ ## op(CPUMIPSState *env, uint64_t fdt0, \ { \ uint64_t c; \ c = cond; \ - update_fcr31(env, GETPC()); \ if (c) { \ return -1; \ } else { \ return 0; \ } \ + update_fcr31(env, GETPC()); \ } /* @@ -2175,12 +2183,12 @@ uint32_t helper_r6_cmp_s_ ## op(CPUMIPSState *env, uint32_t fst0, \ { \ uint64_t c; \ c = cond; \ - update_fcr31(env, GETPC()); \ if (c) { \ return -1; \ } else { \ return 0; \ } \ + update_fcr31(env, GETPC()); \ } /* -- 2.7.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v2 4/5] target/mips: Refactor helpers for fp comparison instructions 2020-10-07 20:37 ` [PATCH v2 4/5] target/mips: Refactor helpers for fp comparison instructions Aleksandar Markovic @ 2020-10-09 14:47 ` Philippe Mathieu-Daudé 2020-10-16 20:17 ` Philippe Mathieu-Daudé 0 siblings, 1 reply; 16+ messages in thread From: Philippe Mathieu-Daudé @ 2020-10-09 14:47 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel Cc: peter.maydell, aleksandar.rikalo, hpoussin, chenhc, aurelien Hi Aleksandar, On 10/7/20 10:37 PM, Aleksandar Markovic wrote: > This change causes slighlty better performance of emulation of fp > comparison instructions via better compiler optimization of refactored > code. The functionality is otherwise unchanged. > > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- > target/mips/fpu_helper.c | 56 +++++++++++++++++++++++++++--------------------- > 1 file changed, 32 insertions(+), 24 deletions(-) > [...] > /* > @@ -2080,12 +2088,12 @@ uint64_t helper_r6_cmp_d_ ## op(CPUMIPSState *env, uint64_t fdt0, \ > { \ > uint64_t c; \ > c = cond; \ > - update_fcr31(env, GETPC()); \ > if (c) { \ > return -1; \ > } else { \ > return 0; \ > } \ > + update_fcr31(env, GETPC()); \ Isn't it now never called (dead code)? > } > > /* > @@ -2175,12 +2183,12 @@ uint32_t helper_r6_cmp_s_ ## op(CPUMIPSState *env, uint32_t fst0, \ > { \ > uint64_t c; \ > c = cond; \ > - update_fcr31(env, GETPC()); \ > if (c) { \ > return -1; \ > } else { \ > return 0; \ > } \ > + update_fcr31(env, GETPC()); \ Ditto. > } > > /* > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 4/5] target/mips: Refactor helpers for fp comparison instructions 2020-10-09 14:47 ` Philippe Mathieu-Daudé @ 2020-10-16 20:17 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 16+ messages in thread From: Philippe Mathieu-Daudé @ 2020-10-16 20:17 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel Cc: peter.maydell, aleksandar.rikalo, hpoussin, aurelien, chenhc On 10/9/20 4:47 PM, Philippe Mathieu-Daudé wrote: > Hi Aleksandar, > > On 10/7/20 10:37 PM, Aleksandar Markovic wrote: >> This change causes slighlty better performance of emulation of fp >> comparison instructions via better compiler optimization of refactored >> code. The functionality is otherwise unchanged. >> >> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> --- >> target/mips/fpu_helper.c | 56 >> +++++++++++++++++++++++++++--------------------- >> 1 file changed, 32 insertions(+), 24 deletions(-) >> > [...] > >> /* >> @@ -2080,12 +2088,12 @@ uint64_t helper_r6_cmp_d_ ## op(CPUMIPSState >> *env, uint64_t fdt0, \ >> { \ >> uint64_t c; \ >> c = cond; \ >> - update_fcr31(env, GETPC()); \ >> if (c) { \ >> return -1; \ >> } else { \ >> return 0; \ >> } \ >> + update_fcr31(env, GETPC()); \ > > Isn't it now never called (dead code)? Confirmed: target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_af’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2103:1: note: in expansion of macro ‘FOP_CONDN_D’ 2103 | FOP_CONDN_D(af, (float64_unordered_quiet(fdt1, fdt0, | ^~~~~~~~~~~ Compiling C object libqemu-mips-softmmu.fa.p/target_mips_dsp_helper.c.o target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_un’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2105:1: note: in expansion of macro ‘FOP_CONDN_D’ 2105 | FOP_CONDN_D(un, (float64_unordered_quiet(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_eq’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2107:1: note: in expansion of macro ‘FOP_CONDN_D’ 2107 | FOP_CONDN_D(eq, (float64_eq_quiet(fdt0, fdt1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_ueq’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2109:1: note: in expansion of macro ‘FOP_CONDN_D’ 2109 | FOP_CONDN_D(ueq, (float64_unordered_quiet(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_lt’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2113:1: note: in expansion of macro ‘FOP_CONDN_D’ 2113 | FOP_CONDN_D(lt, (float64_lt_quiet(fdt0, fdt1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_ult’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2115:1: note: in expansion of macro ‘FOP_CONDN_D’ 2115 | FOP_CONDN_D(ult, (float64_unordered_quiet(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_le’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2119:1: note: in expansion of macro ‘FOP_CONDN_D’ 2119 | FOP_CONDN_D(le, (float64_le_quiet(fdt0, fdt1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_ule’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2121:1: note: in expansion of macro ‘FOP_CONDN_D’ 2121 | FOP_CONDN_D(ule, (float64_unordered_quiet(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_saf’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2129:1: note: in expansion of macro ‘FOP_CONDN_D’ 2129 | FOP_CONDN_D(saf, (float64_unordered(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_sun’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2131:1: note: in expansion of macro ‘FOP_CONDN_D’ 2131 | FOP_CONDN_D(sun, (float64_unordered(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_seq’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2133:1: note: in expansion of macro ‘FOP_CONDN_D’ 2133 | FOP_CONDN_D(seq, (float64_eq(fdt0, fdt1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_sueq’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2135:1: note: in expansion of macro ‘FOP_CONDN_D’ 2135 | FOP_CONDN_D(sueq, (float64_unordered(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_slt’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2139:1: note: in expansion of macro ‘FOP_CONDN_D’ 2139 | FOP_CONDN_D(slt, (float64_lt(fdt0, fdt1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_sult’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2141:1: note: in expansion of macro ‘FOP_CONDN_D’ 2141 | FOP_CONDN_D(sult, (float64_unordered(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_sle’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2145:1: note: in expansion of macro ‘FOP_CONDN_D’ 2145 | FOP_CONDN_D(sle, (float64_le(fdt0, fdt1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_sule’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2147:1: note: in expansion of macro ‘FOP_CONDN_D’ 2147 | FOP_CONDN_D(sule, (float64_unordered(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_or’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2151:1: note: in expansion of macro ‘FOP_CONDN_D’ 2151 | FOP_CONDN_D(or, (float64_le_quiet(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_une’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2155:1: note: in expansion of macro ‘FOP_CONDN_D’ 2155 | FOP_CONDN_D(une, (float64_unordered_quiet(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_ne’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2161:1: note: in expansion of macro ‘FOP_CONDN_D’ 2161 | FOP_CONDN_D(ne, (float64_lt_quiet(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_sor’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2165:1: note: in expansion of macro ‘FOP_CONDN_D’ 2165 | FOP_CONDN_D(sor, (float64_le(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_sune’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2169:1: note: in expansion of macro ‘FOP_CONDN_D’ 2169 | FOP_CONDN_D(sune, (float64_unordered(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_d_sne’: target/mips/fpu_helper.c:2097:1: error: control reaches end of non-void function [-Werror=return-type] 2097 | } | ^ target/mips/fpu_helper.c:2175:1: note: in expansion of macro ‘FOP_CONDN_D’ 2175 | FOP_CONDN_D(sne, (float64_lt(fdt1, fdt0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_af’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2198:1: note: in expansion of macro ‘FOP_CONDN_S’ 2198 | FOP_CONDN_S(af, (float32_unordered_quiet(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_un’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2200:1: note: in expansion of macro ‘FOP_CONDN_S’ 2200 | FOP_CONDN_S(un, (float32_unordered_quiet(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_eq’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2202:1: note: in expansion of macro ‘FOP_CONDN_S’ 2202 | FOP_CONDN_S(eq, (float32_eq_quiet(fst0, fst1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_ueq’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2204:1: note: in expansion of macro ‘FOP_CONDN_S’ 2204 | FOP_CONDN_S(ueq, (float32_unordered_quiet(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_lt’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2208:1: note: in expansion of macro ‘FOP_CONDN_S’ 2208 | FOP_CONDN_S(lt, (float32_lt_quiet(fst0, fst1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_ult’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2210:1: note: in expansion of macro ‘FOP_CONDN_S’ 2210 | FOP_CONDN_S(ult, (float32_unordered_quiet(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_le’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2214:1: note: in expansion of macro ‘FOP_CONDN_S’ 2214 | FOP_CONDN_S(le, (float32_le_quiet(fst0, fst1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_ule’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2216:1: note: in expansion of macro ‘FOP_CONDN_S’ 2216 | FOP_CONDN_S(ule, (float32_unordered_quiet(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_saf’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2224:1: note: in expansion of macro ‘FOP_CONDN_S’ 2224 | FOP_CONDN_S(saf, (float32_unordered(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_sun’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2226:1: note: in expansion of macro ‘FOP_CONDN_S’ 2226 | FOP_CONDN_S(sun, (float32_unordered(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_seq’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2228:1: note: in expansion of macro ‘FOP_CONDN_S’ 2228 | FOP_CONDN_S(seq, (float32_eq(fst0, fst1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_sueq’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2230:1: note: in expansion of macro ‘FOP_CONDN_S’ 2230 | FOP_CONDN_S(sueq, (float32_unordered(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_slt’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2234:1: note: in expansion of macro ‘FOP_CONDN_S’ 2234 | FOP_CONDN_S(slt, (float32_lt(fst0, fst1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_sult’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2236:1: note: in expansion of macro ‘FOP_CONDN_S’ 2236 | FOP_CONDN_S(sult, (float32_unordered(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_sle’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2240:1: note: in expansion of macro ‘FOP_CONDN_S’ 2240 | FOP_CONDN_S(sle, (float32_le(fst0, fst1, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_sule’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2242:1: note: in expansion of macro ‘FOP_CONDN_S’ 2242 | FOP_CONDN_S(sule, (float32_unordered(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_or’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2246:1: note: in expansion of macro ‘FOP_CONDN_S’ 2246 | FOP_CONDN_S(or, (float32_le_quiet(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_une’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2250:1: note: in expansion of macro ‘FOP_CONDN_S’ 2250 | FOP_CONDN_S(une, (float32_unordered_quiet(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_ne’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2256:1: note: in expansion of macro ‘FOP_CONDN_S’ 2256 | FOP_CONDN_S(ne, (float32_lt_quiet(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_sor’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2260:1: note: in expansion of macro ‘FOP_CONDN_S’ 2260 | FOP_CONDN_S(sor, (float32_le(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_sune’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2264:1: note: in expansion of macro ‘FOP_CONDN_S’ 2264 | FOP_CONDN_S(sune, (float32_unordered(fst1, fst0, | ^~~~~~~~~~~ target/mips/fpu_helper.c: In function ‘helper_r6_cmp_s_sne’: target/mips/fpu_helper.c:2192:1: error: control reaches end of non-void function [-Werror=return-type] 2192 | } | ^ target/mips/fpu_helper.c:2270:1: note: in expansion of macro ‘FOP_CONDN_S’ 2270 | FOP_CONDN_S(sne, (float32_lt(fst1, fst0, | ^~~~~~~~~~~ Compiling C object libqemu-mips-softmmu.fa.p/target_mips_cpu.c.o cc1: all warnings being treated as errors Makefile.ninja:3848: recipe for target 'libqemu-mips-softmmu.fa.p/target_mips_fpu_helper.c.o' failed make: *** [libqemu-mips-softmmu.fa.p/target_mips_fpu_helper.c.o] Error 1 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v2 5/5] MAINTAINERS: Remove myself 2020-10-07 20:37 [PATCH v2 0/5] target/mips: Misc patches Aleksandar Markovic ` (3 preceding siblings ...) 2020-10-07 20:37 ` [PATCH v2 4/5] target/mips: Refactor helpers for fp comparison instructions Aleksandar Markovic @ 2020-10-07 20:37 ` Aleksandar Markovic 2020-10-08 7:21 ` chen huacai 2020-10-09 15:00 ` [PATCH v2 0/5] target/mips: Misc patches Philippe Mathieu-Daudé 5 siblings, 1 reply; 16+ messages in thread From: Aleksandar Markovic @ 2020-10-07 20:37 UTC (permalink / raw) To: qemu-devel Cc: peter.maydell, aleksandar.rikalo, f4bug, jiaxun.yang, Aleksandar Markovic, hpoussin, chenhc, aurelien I have been working on project other than QEMU for some time, and would like to devote myself to that project. It is imposible for me to find enough time to perform maintainer's duties with needed meticulousness and patience. I wish prosperous future to QEMU and all colegues in QEMU community. Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> --- MAINTAINERS | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e9d85cc..426f52c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -221,11 +221,10 @@ F: hw/microblaze/ F: disas/microblaze.c MIPS TCG CPUs -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> R: Aurelien Jarno <aurelien@aurel32.net> R: Jiaxun Yang <jiaxun.yang@flygoat.com> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> -S: Maintained +S: Orphaned F: target/mips/ F: default-configs/*mips* F: disas/*mips* @@ -387,7 +386,6 @@ F: target/arm/kvm.c MIPS KVM CPUs M: Huacai Chen <chenhc@lemote.com> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> S: Odd Fixes F: target/mips/kvm.c @@ -1124,10 +1122,9 @@ F: hw/display/jazz_led.c F: hw/dma/rc4030.c Malta -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> M: Philippe Mathieu-Daudé <f4bug@amsat.org> R: Aurelien Jarno <aurelien@aurel32.net> -S: Maintained +S: Odd Fixes F: hw/isa/piix4.c F: hw/acpi/piix4.c F: hw/mips/malta.c @@ -1137,14 +1134,12 @@ F: tests/acceptance/linux_ssh_mips_malta.py F: tests/acceptance/machine_mips_malta.py Mipssim -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> -S: Odd Fixes +S: Orphaned F: hw/mips/mipssim.c F: hw/net/mipsnet.c R4000 -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> R: Aurelien Jarno <aurelien@aurel32.net> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> S: Obsolete @@ -1153,7 +1148,6 @@ F: hw/mips/r4k.c Fuloong 2E M: Huacai Chen <chenhc@lemote.com> M: Philippe Mathieu-Daudé <f4bug@amsat.org> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> R: Jiaxun Yang <jiaxun.yang@flygoat.com> S: Odd Fixes F: hw/mips/fuloong2e.c @@ -2821,12 +2815,11 @@ F: tcg/i386/ F: disas/i386.c MIPS TCG target -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> R: Aurelien Jarno <aurelien@aurel32.net> R: Huacai Chen <chenhc@lemote.com> R: Jiaxun Yang <jiaxun.yang@flygoat.com> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> -S: Maintained +S: Orphaned F: tcg/mips/ PPC TCG target @@ -3167,7 +3160,7 @@ S: Odd Fixes F: scripts/git-submodule.sh UI translations -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> +S: Orphaned F: po/*.po Sphinx documentation configuration and build machinery -- 2.7.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v2 5/5] MAINTAINERS: Remove myself 2020-10-07 20:37 ` [PATCH v2 5/5] MAINTAINERS: Remove myself Aleksandar Markovic @ 2020-10-08 7:21 ` chen huacai 2020-10-08 10:21 ` Philippe Mathieu-Daudé 0 siblings, 1 reply; 16+ messages in thread From: chen huacai @ 2020-10-08 7:21 UTC (permalink / raw) To: Aleksandar Markovic Cc: Peter Maydell, Aleksandar Rikalo, qemu-level, Jiaxun Yang, Philippe Mathieu-Daudé, hpoussin, Huacai Chen, Aurelien Jarno Hi, Aleksandar, On Thu, Oct 8, 2020 at 4:40 AM Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> wrote: > > I have been working on project other than QEMU for some time, and would > like to devote myself to that project. It is imposible for me to find > enough time to perform maintainer's duties with needed meticulousness > and patience. > > I wish prosperous future to QEMU and all colegues in QEMU community. I'm very sorry to hear that. I hope you can be still here if possible... I found that there are many reviewers, so, if it is a must that Aleksandar will leave us, can these reviewers be maintainers? Huacai > > Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > --- > MAINTAINERS | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e9d85cc..426f52c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -221,11 +221,10 @@ F: hw/microblaze/ > F: disas/microblaze.c > > MIPS TCG CPUs > -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > R: Aurelien Jarno <aurelien@aurel32.net> > R: Jiaxun Yang <jiaxun.yang@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > -S: Maintained > +S: Orphaned > F: target/mips/ > F: default-configs/*mips* > F: disas/*mips* > @@ -387,7 +386,6 @@ F: target/arm/kvm.c > > MIPS KVM CPUs > M: Huacai Chen <chenhc@lemote.com> > -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > S: Odd Fixes > F: target/mips/kvm.c > > @@ -1124,10 +1122,9 @@ F: hw/display/jazz_led.c > F: hw/dma/rc4030.c > > Malta > -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > M: Philippe Mathieu-Daudé <f4bug@amsat.org> > R: Aurelien Jarno <aurelien@aurel32.net> > -S: Maintained > +S: Odd Fixes > F: hw/isa/piix4.c > F: hw/acpi/piix4.c > F: hw/mips/malta.c > @@ -1137,14 +1134,12 @@ F: tests/acceptance/linux_ssh_mips_malta.py > F: tests/acceptance/machine_mips_malta.py > > Mipssim > -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > -S: Odd Fixes > +S: Orphaned > F: hw/mips/mipssim.c > F: hw/net/mipsnet.c > > R4000 > -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > R: Aurelien Jarno <aurelien@aurel32.net> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > S: Obsolete > @@ -1153,7 +1148,6 @@ F: hw/mips/r4k.c > Fuloong 2E > M: Huacai Chen <chenhc@lemote.com> > M: Philippe Mathieu-Daudé <f4bug@amsat.org> > -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > R: Jiaxun Yang <jiaxun.yang@flygoat.com> > S: Odd Fixes > F: hw/mips/fuloong2e.c > @@ -2821,12 +2815,11 @@ F: tcg/i386/ > F: disas/i386.c > > MIPS TCG target > -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > R: Aurelien Jarno <aurelien@aurel32.net> > R: Huacai Chen <chenhc@lemote.com> > R: Jiaxun Yang <jiaxun.yang@flygoat.com> > R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> > -S: Maintained > +S: Orphaned > F: tcg/mips/ > > PPC TCG target > @@ -3167,7 +3160,7 @@ S: Odd Fixes > F: scripts/git-submodule.sh > > UI translations > -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> > +S: Orphaned > F: po/*.po > > Sphinx documentation configuration and build machinery > -- > 2.7.4 > > -- Huacai Chen ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 5/5] MAINTAINERS: Remove myself 2020-10-08 7:21 ` chen huacai @ 2020-10-08 10:21 ` Philippe Mathieu-Daudé 2020-10-08 10:51 ` Philippe Mathieu-Daudé 2020-10-09 2:52 ` Jiaxun Yang 0 siblings, 2 replies; 16+ messages in thread From: Philippe Mathieu-Daudé @ 2020-10-08 10:21 UTC (permalink / raw) To: chen huacai, Aleksandar Markovic Cc: Peter Maydell, Aleksandar Rikalo, qemu-level, Jiaxun Yang, hpoussin, Huacai Chen, Aurelien Jarno On 10/8/20 9:21 AM, chen huacai wrote: > Hi, Aleksandar, > > On Thu, Oct 8, 2020 at 4:40 AM Aleksandar Markovic > <aleksandar.qemu.devel@gmail.com> wrote: >> >> I have been working on project other than QEMU for some time, and would >> like to devote myself to that project. It is imposible for me to find >> enough time to perform maintainer's duties with needed meticulousness >> and patience. Thanks Aleksandar for your contributions and keeping MIPS in good shape during 2 years! >> >> I wish prosperous future to QEMU and all colegues in QEMU community. > I'm very sorry to hear that. I hope you can be still here if possible... > I found that there are many reviewers, so, if it is a must that > Aleksandar will leave us, can these reviewers be maintainers? Thanks for volunteering! Aleksandar Rikalo hasn't sent anything to the list since 4 months. Is Jiaxun Yang also volunteering? Regards, Phil. > > Huacai >> >> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> --- >> MAINTAINERS | 17 +++++------------ >> 1 file changed, 5 insertions(+), 12 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index e9d85cc..426f52c 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -221,11 +221,10 @@ F: hw/microblaze/ >> F: disas/microblaze.c >> >> MIPS TCG CPUs >> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> R: Aurelien Jarno <aurelien@aurel32.net> >> R: Jiaxun Yang <jiaxun.yang@flygoat.com> >> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >> -S: Maintained >> +S: Orphaned >> F: target/mips/ >> F: default-configs/*mips* >> F: disas/*mips* >> @@ -387,7 +386,6 @@ F: target/arm/kvm.c >> >> MIPS KVM CPUs >> M: Huacai Chen <chenhc@lemote.com> >> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> S: Odd Fixes >> F: target/mips/kvm.c >> >> @@ -1124,10 +1122,9 @@ F: hw/display/jazz_led.c >> F: hw/dma/rc4030.c >> >> Malta >> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> M: Philippe Mathieu-Daudé <f4bug@amsat.org> >> R: Aurelien Jarno <aurelien@aurel32.net> >> -S: Maintained >> +S: Odd Fixes >> F: hw/isa/piix4.c >> F: hw/acpi/piix4.c >> F: hw/mips/malta.c >> @@ -1137,14 +1134,12 @@ F: tests/acceptance/linux_ssh_mips_malta.py >> F: tests/acceptance/machine_mips_malta.py >> >> Mipssim >> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >> -S: Odd Fixes >> +S: Orphaned >> F: hw/mips/mipssim.c >> F: hw/net/mipsnet.c >> >> R4000 >> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> R: Aurelien Jarno <aurelien@aurel32.net> >> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >> S: Obsolete >> @@ -1153,7 +1148,6 @@ F: hw/mips/r4k.c >> Fuloong 2E >> M: Huacai Chen <chenhc@lemote.com> >> M: Philippe Mathieu-Daudé <f4bug@amsat.org> >> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> R: Jiaxun Yang <jiaxun.yang@flygoat.com> >> S: Odd Fixes >> F: hw/mips/fuloong2e.c >> @@ -2821,12 +2815,11 @@ F: tcg/i386/ >> F: disas/i386.c >> >> MIPS TCG target >> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> R: Aurelien Jarno <aurelien@aurel32.net> >> R: Huacai Chen <chenhc@lemote.com> >> R: Jiaxun Yang <jiaxun.yang@flygoat.com> >> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >> -S: Maintained >> +S: Orphaned >> F: tcg/mips/ >> >> PPC TCG target >> @@ -3167,7 +3160,7 @@ S: Odd Fixes >> F: scripts/git-submodule.sh >> >> UI translations >> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >> +S: Orphaned >> F: po/*.po >> >> Sphinx documentation configuration and build machinery >> -- >> 2.7.4 >> >> > > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 5/5] MAINTAINERS: Remove myself 2020-10-08 10:21 ` Philippe Mathieu-Daudé @ 2020-10-08 10:51 ` Philippe Mathieu-Daudé 2020-10-09 2:52 ` Jiaxun Yang 1 sibling, 0 replies; 16+ messages in thread From: Philippe Mathieu-Daudé @ 2020-10-08 10:51 UTC (permalink / raw) To: chen huacai, Aleksandar Markovic Cc: Peter Maydell, Aleksandar Rikalo, qemu-level, Jiaxun Yang, hpoussin, Huacai Chen, Aurelien Jarno On 10/8/20 12:21 PM, Philippe Mathieu-Daudé wrote: > On 10/8/20 9:21 AM, chen huacai wrote: >> Hi, Aleksandar, >> >> On Thu, Oct 8, 2020 at 4:40 AM Aleksandar Markovic >> <aleksandar.qemu.devel@gmail.com> wrote: >>> >>> I have been working on project other than QEMU for some time, and would >>> like to devote myself to that project. It is imposible for me to find >>> enough time to perform maintainer's duties with needed meticulousness >>> and patience. > > Thanks Aleksandar for your contributions and keeping MIPS in good > shape during 2 years! > >>> >>> I wish prosperous future to QEMU and all colegues in QEMU community. >> I'm very sorry to hear that. I hope you can be still here if possible... >> I found that there are many reviewers, so, if it is a must that >> Aleksandar will leave us, can these reviewers be maintainers? Note the problem with QEMU MIPS is not there is few maintainers, is really there are no reviewers... See, there are about 25 patches unreviewed on the list since various weeks. I don't have problem merging/testing them once reviewed and doing maintenance, but I can not review them all (in particular the one I send...). Maintaining is not about merging your own area patches, it is also about trying to understand what the other are doing, eventually having to verify the specs, understand the use case, and so on. Like I intend to do with your Loongson-3 series. Note that I do that in my free time, and I certainly do not want to be the single maintainer, I don't have the bandwidth. > > Thanks for volunteering! Aleksandar Rikalo hasn't sent anything > to the list since 4 months. Is Jiaxun Yang also volunteering? > > Regards, > > Phil. > >> >> Huacai >>> >>> Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> --- >>> MAINTAINERS | 17 +++++------------ >>> 1 file changed, 5 insertions(+), 12 deletions(-) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index e9d85cc..426f52c 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -221,11 +221,10 @@ F: hw/microblaze/ >>> F: disas/microblaze.c >>> >>> MIPS TCG CPUs >>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> R: Aurelien Jarno <aurelien@aurel32.net> >>> R: Jiaxun Yang <jiaxun.yang@flygoat.com> >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >>> -S: Maintained >>> +S: Orphaned >>> F: target/mips/ >>> F: default-configs/*mips* >>> F: disas/*mips* >>> @@ -387,7 +386,6 @@ F: target/arm/kvm.c >>> >>> MIPS KVM CPUs >>> M: Huacai Chen <chenhc@lemote.com> >>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> S: Odd Fixes >>> F: target/mips/kvm.c >>> >>> @@ -1124,10 +1122,9 @@ F: hw/display/jazz_led.c >>> F: hw/dma/rc4030.c >>> >>> Malta >>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> M: Philippe Mathieu-Daudé <f4bug@amsat.org> >>> R: Aurelien Jarno <aurelien@aurel32.net> >>> -S: Maintained >>> +S: Odd Fixes >>> F: hw/isa/piix4.c >>> F: hw/acpi/piix4.c >>> F: hw/mips/malta.c >>> @@ -1137,14 +1134,12 @@ F: tests/acceptance/linux_ssh_mips_malta.py >>> F: tests/acceptance/machine_mips_malta.py >>> >>> Mipssim >>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >>> -S: Odd Fixes >>> +S: Orphaned >>> F: hw/mips/mipssim.c >>> F: hw/net/mipsnet.c >>> >>> R4000 >>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> R: Aurelien Jarno <aurelien@aurel32.net> >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >>> S: Obsolete >>> @@ -1153,7 +1148,6 @@ F: hw/mips/r4k.c >>> Fuloong 2E >>> M: Huacai Chen <chenhc@lemote.com> >>> M: Philippe Mathieu-Daudé <f4bug@amsat.org> >>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> R: Jiaxun Yang <jiaxun.yang@flygoat.com> >>> S: Odd Fixes >>> F: hw/mips/fuloong2e.c >>> @@ -2821,12 +2815,11 @@ F: tcg/i386/ >>> F: disas/i386.c >>> >>> MIPS TCG target >>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> R: Aurelien Jarno <aurelien@aurel32.net> >>> R: Huacai Chen <chenhc@lemote.com> >>> R: Jiaxun Yang <jiaxun.yang@flygoat.com> >>> R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com> >>> -S: Maintained >>> +S: Orphaned >>> F: tcg/mips/ >>> >>> PPC TCG target >>> @@ -3167,7 +3160,7 @@ S: Odd Fixes >>> F: scripts/git-submodule.sh >>> >>> UI translations >>> -M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> >>> +S: Orphaned >>> F: po/*.po >>> >>> Sphinx documentation configuration and build machinery >>> -- >>> 2.7.4 >>> >>> >> >> > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 5/5] MAINTAINERS: Remove myself 2020-10-08 10:21 ` Philippe Mathieu-Daudé 2020-10-08 10:51 ` Philippe Mathieu-Daudé @ 2020-10-09 2:52 ` Jiaxun Yang 1 sibling, 0 replies; 16+ messages in thread From: Jiaxun Yang @ 2020-10-09 2:52 UTC (permalink / raw) To: Philippe Mathieu-Daudé, chen huacai, Aleksandar Markovic Cc: Peter Maydell, Aleksandar Rikalo, qemu-level, hpoussin, Huacai Chen, Aurelien Jarno 在 2020/10/8 18:21, Philippe Mathieu-Daudé 写道: > On 10/8/20 9:21 AM, chen huacai wrote: >> Hi, Aleksandar, >> >> On Thu, Oct 8, 2020 at 4:40 AM Aleksandar Markovic >> <aleksandar.qemu.devel@gmail.com> wrote: >>> I have been working on project other than QEMU for some time, and would >>> like to devote myself to that project. It is imposible for me to find >>> enough time to perform maintainer's duties with needed meticulousness >>> and patience. > Thanks Aleksandar for your contributions and keeping MIPS in good > shape during 2 years! > >>> I wish prosperous future to QEMU and all colegues in QEMU community. >> I'm very sorry to hear that. I hope you can be still here if possible... >> I found that there are many reviewers, so, if it is a must that >> Aleksandar will leave us, can these reviewers be maintainers? > Thanks for volunteering! Aleksandar Rikalo hasn't sent anything > to the list since 4 months. Is Jiaxun Yang also volunteering? Hi all, Thanks for the inviation. I'm busy with real world recently (probably until Dec) so I can't promise anything. But I can start with helping reviewing blocking patches. - Jiaxun > Regards, > > Phil. > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 0/5] target/mips: Misc patches 2020-10-07 20:37 [PATCH v2 0/5] target/mips: Misc patches Aleksandar Markovic ` (4 preceding siblings ...) 2020-10-07 20:37 ` [PATCH v2 5/5] MAINTAINERS: Remove myself Aleksandar Markovic @ 2020-10-09 15:00 ` Philippe Mathieu-Daudé 5 siblings, 0 replies; 16+ messages in thread From: Philippe Mathieu-Daudé @ 2020-10-09 15:00 UTC (permalink / raw) To: Aleksandar Markovic, qemu-devel Cc: peter.maydell, aleksandar.rikalo, hpoussin, chenhc, aurelien On 10/7/20 10:37 PM, Aleksandar Markovic wrote: > A set of several, mostly FP, refactorings and improvements. > > v1->v2: > > - added a patch on MAINTAINERS > > Aleksandar Markovic (5): > target/mips: Demacro helpers for <ABS|CHS>.<D|S|PS> > target/mips: Demacro helpers for M<ADD|SUB>F.<D|S> > target/mips: Demacro helpers for <MAX|MAXA|MIN|MINA>.<D|S> > target/mips: Refactor helpers for fp comparison instructions > MAINTAINERS: Remove myself Thanks, patches 1-3 & 5 applied to mips-next tree. ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2020-10-16 20:24 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-10-07 20:37 [PATCH v2 0/5] target/mips: Misc patches Aleksandar Markovic 2020-10-07 20:37 ` [PATCH v2 1/5] target/mips: Demacro helpers for <ABS|CHS>.<D|S|PS> Aleksandar Markovic 2020-10-09 14:39 ` Philippe Mathieu-Daudé 2020-10-07 20:37 ` [PATCH v2 2/5] target/mips: Demacro helpers for M<ADD|SUB>F.<D|S> Aleksandar Markovic 2020-10-09 14:42 ` Philippe Mathieu-Daudé 2020-10-07 20:37 ` [PATCH v2 3/5] target/mips: Demacro helpers for <MAX|MAXA|MIN|MINA>.<D|S> Aleksandar Markovic 2020-10-09 14:44 ` Philippe Mathieu-Daudé 2020-10-07 20:37 ` [PATCH v2 4/5] target/mips: Refactor helpers for fp comparison instructions Aleksandar Markovic 2020-10-09 14:47 ` Philippe Mathieu-Daudé 2020-10-16 20:17 ` Philippe Mathieu-Daudé 2020-10-07 20:37 ` [PATCH v2 5/5] MAINTAINERS: Remove myself Aleksandar Markovic 2020-10-08 7:21 ` chen huacai 2020-10-08 10:21 ` Philippe Mathieu-Daudé 2020-10-08 10:51 ` Philippe Mathieu-Daudé 2020-10-09 2:52 ` Jiaxun Yang 2020-10-09 15:00 ` [PATCH v2 0/5] target/mips: Misc patches Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).