From: "wangyanan (Y)" <wangyanan55@huawei.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Andrew Jones" <drjones@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Pierre Morel" <pmorel@linux.ibm.com>,
"Pankaj Gupta" <pankaj.gupta.linux@gmail.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org, wanghaibin.wang@huawei.com,
yuzenghui@huawei.com, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero
Date: Fri, 23 Jul 2021 09:57:14 +0800 [thread overview]
Message-ID: <38c23728-e2b4-cbd2-450f-ed4c95c7fba4@huawei.com> (raw)
In-Reply-To: <874kcm0ywx.fsf@p50.localhost.localdomain>
Hi Cleber,
On 2021/7/23 6:25, Cleber Rosa wrote:
> Yanan Wang writes:
>
>> In the SMP configuration, we should either specify a topology
>> parameter with a reasonable value (equal to or greater than 1)
>> or just leave it omitted and QEMU will calculate its value.
>> Configurations which explicitly specify the topology parameters
>> as zero like "sockets=0" are meaningless, so disallow them.
>>
>> However, the commit 1e63fe685804d
>> (machine: pass QAPI struct to mc->smp_parse) has documented that
>> '0' has the same semantics as omitting a parameter in the qapi
>> comment for SMPConfiguration. So this patch fixes the doc and
>> also adds the corresponding sanity check in the smp parsers.
>>
>> Suggested-by: Andrew Jones <drjones@redhat.com>
>> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
>> ---
>> hw/core/machine.c | 14 ++++++++++++++
>> qapi/machine.json | 6 +++---
>> qemu-options.hx | 12 +++++++-----
>> 3 files changed, 24 insertions(+), 8 deletions(-)
> Hi Yanan,
>
> This looks somewhat similar to this very old patch of mine:
>
> https://mail.gnu.org/archive/html/qemu-devel/2020-10/msg03039.html
>
> I'm putting a reference here because I believe the test can be salvaged
> and slightly adapted for this patch of yours.
>
> Let me know if I can help anyhow.
>
Thanks for this.
I was introducing an unit test for the smp parsing in [1], in which all
possible valid and invalid smp configs were covered, and actually the
"parameter=0" stuff was also covered. You can have a look, and
suggestions are welcome. I'm not sure we need two different tests
for the same part. :)
[1]
https://lore.kernel.org/qemu-devel/20210719032043.25416-12-wangyanan55@huawei.com/
Thanks,
Yanan
.
next prev parent reply other threads:[~2021-07-23 1:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 15:43 [PATCH for-6.1 v2 0/1] machine: Disallow specifying topology parameters as zero Yanan Wang
2021-07-22 15:43 ` [PATCH for-6.1 v2] " Yanan Wang
2021-07-22 16:01 ` Daniel P. Berrangé
2021-07-23 8:02 ` Markus Armbruster
2021-07-23 8:40 ` wangyanan (Y)
2021-07-23 8:46 ` Cornelia Huck
2021-07-22 16:15 ` Andrew Jones
2021-07-22 22:25 ` Cleber Rosa
2021-07-23 1:57 ` wangyanan (Y) [this message]
2021-07-23 14:14 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38c23728-e2b4-cbd2-450f-ed4c95c7fba4@huawei.com \
--to=wangyanan55@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=crosa@redhat.com \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).