From: Cornelia Huck <cohuck@redhat.com>
To: "wangyanan (Y)" <wangyanan55@huawei.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Andrew Jones <drjones@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Pierre Morel <pmorel@linux.ibm.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
qemu-devel@nongnu.org, wanghaibin.wang@huawei.com,
yuzenghui@huawei.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH for-6.1 v2] machine: Disallow specifying topology parameters as zero
Date: Fri, 23 Jul 2021 10:46:55 +0200 [thread overview]
Message-ID: <87zgud5se8.fsf@redhat.com> (raw)
In-Reply-To: <553158b7-3705-8570-d3b8-e772ae49ed2c@huawei.com>
On Fri, Jul 23 2021, "wangyanan (Y)" <wangyanan55@huawei.com> wrote:
> On 2021/7/23 16:02, Markus Armbruster wrote:
>> Daniel P. Berrangé <berrange@redhat.com> writes:
>>
>>> On Thu, Jul 22, 2021 at 11:43:26PM +0800, Yanan Wang wrote:
>>>> + /*
>>>> + * The topology parameters must be specified equal to or great than one
>>>> + * or just omitted, explicit configuration like "cpus=0" is not allowed.
>>>> + */
>>>> + if ((config->has_cpus && config->cpus == 0) ||
>>>> + (config->has_sockets && config->sockets == 0) ||
>>>> + (config->has_dies && config->dies == 0) ||
>>>> + (config->has_cores && config->cores == 0) ||
>>>> + (config->has_threads && config->threads == 0) ||
>>>> + (config->has_maxcpus && config->maxcpus == 0)) {
>>>> + error_setg(errp, "parameters must be equal to or greater than one if provided");
>>> I'd suggest a slight tweak since when seen it lacks context:
>>>
>>> $ ./qemu-system-x86_64 -smp 4,cores=0,sockets=2
>>> qemu-system-x86_64: parameters must be equal to or greater than one if provided
>>>
>>>
>>> error_setg(errp, "CPU topology parameters must be equal to or greater than one if provided");
>> Let's scratch "if provided".
>>
>> I'd replace "must be equal to or greater than one" by "must be
>> positive", or maybe "must be greater than zero".
> How about we use "must be greater than zero" ?
> After a grep search of these two sentences in QEMU, they both show up
> in several places. "must be positive" always reports an invalid value that
> is "< 0". While the check in this patch actually reject an invalid zero
> value.
Of the two, I'd prefer "greater than zero".
next prev parent reply other threads:[~2021-07-23 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 15:43 [PATCH for-6.1 v2 0/1] machine: Disallow specifying topology parameters as zero Yanan Wang
2021-07-22 15:43 ` [PATCH for-6.1 v2] " Yanan Wang
2021-07-22 16:01 ` Daniel P. Berrangé
2021-07-23 8:02 ` Markus Armbruster
2021-07-23 8:40 ` wangyanan (Y)
2021-07-23 8:46 ` Cornelia Huck [this message]
2021-07-22 16:15 ` Andrew Jones
2021-07-22 22:25 ` Cleber Rosa
2021-07-23 1:57 ` wangyanan (Y)
2021-07-23 14:14 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgud5se8.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=wanghaibin.wang@huawei.com \
--cc=wangyanan55@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).